openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Oskar Senft <osk@google.com>, openbmc@lists.ozlabs.org, joel@jms.id.au
Cc: Ed Tanous <ed@tanous.net>,
	Vijay Khemka <vijaykhemkalinux@gmail.com>,
	Jason Hargis <jason.hargis@equuscs.com>
Subject: Re: [PATCH linux dev-5.10] ARM: dts: aspeed: Add TYAN S7106 BMC machine
Date: Wed, 08 Sep 2021 09:14:50 +0800	[thread overview]
Message-ID: <7ac0aa41c2136e17117d1709d1cddc7552b8b948.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20210907205200.1193552-1-osk@google.com>

Hi Oskar,

> The TYAN S7106 is a server platform with an ASPEED AST2500 BMC.
> 
> Submitted to upstream in
> https://lists.ozlabs.org/pipermail/linux-aspeed/2021-
> September/006326.html

Pending Joel's comments there, all looks good to me.

In case it's useful to include, I also have the multiplexer on i2c6
defined in my dts:

+       i2cmux {
+               compatible = "i2c-mux-gpio";
+               #address-cells = <1>;
+               #size-cells = <0>;
+               i2c-parent = <&i2c6>;
+               mux-gpios = <&gpio ASPEED_GPIO(Q,4) GPIO_ACTIVE_HIGH
+                            &gpio ASPEED_GPIO(Q,5) GPIO_ACTIVE_HIGH
+                            &gpio ASPEED_GPIO(G,0) GPIO_ACTIVE_LOW
+                            &gpio ASPEED_GPIO(G,1) GPIO_ACTIVE_LOW>;
+
+               i2c_pcie_s1b1: i2c@4 {
+                       reg = <0x4>;
+               };
+               i2c_pcie_s1b2: i2c@5 {
+                       reg = <0x5>;
+               };
+               i2c_pcie_s2b1: i2c@6 {
+                       reg = <0x6>;
+               };
+               i2c_pcie_s2b2: i2c@7 {
+                       reg = <0x7>;
+               };
+
+               i2c_ocp0a: i2c@8 {
+                       reg = <0x8>;
+               };
+               i2c_ocp0c: i2c@9 {
+                       reg = <0x9>;
+               };
+               i2c_ocp1a: i2c@a {
+                       reg = <0xa>;
+               };
+	};

- but I've only done light testing on that.

Regardless, if you CC me on v2, I'd be happy to add my ack.

Cheers,


Jeremy


      parent reply	other threads:[~2021-09-08  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 20:52 [PATCH linux dev-5.10] ARM: dts: aspeed: Add TYAN S7106 BMC machine Oskar Senft
2021-09-07 23:44 ` Oskar Senft
2021-09-08  1:14 ` Jeremy Kerr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ac0aa41c2136e17117d1709d1cddc7552b8b948.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=ed@tanous.net \
    --cc=jason.hargis@equuscs.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=osk@google.com \
    --cc=vijaykhemkalinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).