* [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting
@ 2022-09-22 15:38 Tomer Maimon
2022-09-22 15:49 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Tomer Maimon @ 2022-09-22 15:38 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
p.zabel, arnd
Cc: openbmc, linux-kernel, Tomer Maimon
In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
and iprst4 register wasn´t set.
This fix sets the correct IP reset values in iprst2 and iprst4 registers
in NPCM8XX USB reset sequence.
Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
drivers/reset/reset-npcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
index 24c55efa98e5..f2333506b0a6 100644
--- a/drivers/reset/reset-npcm.c
+++ b/drivers/reset/reset-npcm.c
@@ -291,7 +291,7 @@ static void npcm_usb_reset_npcm8xx(struct npcm_rc_data *rc)
iprst2 |= ipsrst2_bits;
iprst3 |= (ipsrst3_bits | NPCM_IPSRST3_USBPHY1 |
NPCM_IPSRST3_USBPHY2);
- iprst2 |= ipsrst4_bits;
+ iprst4 |= ipsrst4_bits;
writel(iprst1, rc->base + NPCM_IPSRST1);
writel(iprst2, rc->base + NPCM_IPSRST2);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting
2022-09-22 15:38 [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting Tomer Maimon
@ 2022-09-22 15:49 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2022-09-22 15:49 UTC (permalink / raw)
To: Tomer Maimon, avifishman70, tali.perry1, joel, venture, yuenn,
benjaminfair, arnd
Cc: openbmc, linux-kernel
On Do, 2022-09-22 at 18:38 +0300, Tomer Maimon wrote:
> In NPCM8XX USB reset sequence, iprst2 register was set with iprst4 value
> and iprst4 register wasn´t set.
>
> This fix sets the correct IP reset values in iprst2 and iprst4 registers
> in NPCM8XX USB reset sequence.
>
> Fixes: fc5d2a2f4aa5 ("reset: npcm: Add NPCM8XX support")
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
Thank you, applied to reset/fixes.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-22 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 15:38 [PATCH v1] reset: npcm: fix iprst2 and iprst4 setting Tomer Maimon
2022-09-22 15:49 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).