* [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
@ 2019-03-12 16:50 Adriana Kobylak
2019-03-12 23:21 ` Andrew Jeffery
2019-03-27 6:20 ` Joel Stanley
0 siblings, 2 replies; 8+ messages in thread
From: Adriana Kobylak @ 2019-03-12 16:50 UTC (permalink / raw)
To: linux-aspeed, openbmc; +Cc: Edward A. James, Joel Stanley
From: "Edward A. James" <eajames@us.ibm.com>
Add simplified partitions for BMC and alternate flash. Include these by
default in Witherspoon.
Signed-off-by: Edward A. James <eajames@us.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
.../boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 ++-
3 files changed, 38 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
diff --git a/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
new file mode 100644
index 0000000..9277599
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
@@ -0,0 +1,18 @@
+ label = "alt-bmc";
+ partitions {
+ #address-cells = < 1 >;
+ #size-cells = < 1 >;
+ compatible = "fixed-partitions";
+ u-boot@0 {
+ reg = < 0 0x60000 >;
+ label = "alt-u-boot";
+ };
+ u-boot-env@60000 {
+ reg = < 0x60000 0x20000 >;
+ label = "alt-u-boot-env";
+ };
+ obmc-ubi@80000 {
+ reg = < 0x80000 0x1F80000 >;
+ label = "alt-obmc-ubi";
+ };
+ };
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
new file mode 100644
index 0000000..0059ad1
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
@@ -0,0 +1,18 @@
+ label = "bmc";
+ partitions {
+ #address-cells = < 1 >;
+ #size-cells = < 1 >;
+ compatible = "fixed-partitions";
+ u-boot@0 {
+ reg = < 0 0x60000 >;
+ label = "u-boot";
+ };
+ u-boot-env@60000 {
+ reg = < 0x60000 0x20000 >;
+ label = "u-boot-env";
+ };
+ obmc-ubi@80000 {
+ reg = < 0x80000 0x1F80000 >;
+ label = "obmc-ubi";
+ };
+ };
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index c51e3e8..058b9b7 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -191,7 +191,7 @@
label = "bmc";
m25p,fast-read;
spi-max-frequency = <50000000>;
-#include "openbmc-flash-layout.dtsi"
+#include "aspeed-bmc-opp-flash-layout-ubi.dtsi"
};
flash@1 {
@@ -199,6 +199,7 @@
label = "alt";
m25p,fast-read;
spi-max-frequency = <50000000>;
+#include "aspeed-bmc-alt-opp-flash-layout-ubi.dtsi"
};
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-03-12 16:50 [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning Adriana Kobylak
@ 2019-03-12 23:21 ` Andrew Jeffery
2019-03-27 6:20 ` Joel Stanley
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2019-03-12 23:21 UTC (permalink / raw)
To: Adriana Kobylak, linux-aspeed, openbmc; +Cc: Edward A. James
On Wed, 13 Mar 2019, at 03:21, Adriana Kobylak wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Add simplified partitions for BMC and alternate flash. Include these by
> default in Witherspoon.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
Yes please! Lets apply this so I can stop bashing my head against the desk when doing
kernel work on a Witherspoon.
> ---
> .../boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 ++-
> 3 files changed, 38 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> new file mode 100644
> index 0000000..9277599
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> @@ -0,0 +1,18 @@
> + label = "alt-bmc";
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "alt-u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "alt-u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "alt-obmc-ubi";
> + };
> + };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
> b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
> new file mode 100644
> index 0000000..0059ad1
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
> @@ -0,0 +1,18 @@
> + label = "bmc";
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "obmc-ubi";
> + };
> + };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index c51e3e8..058b9b7 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -191,7 +191,7 @@
> label = "bmc";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> -#include "openbmc-flash-layout.dtsi"
> +#include "aspeed-bmc-opp-flash-layout-ubi.dtsi"
> };
>
> flash@1 {
> @@ -199,6 +199,7 @@
> label = "alt";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> +#include "aspeed-bmc-alt-opp-flash-layout-ubi.dtsi"
> };
> };
>
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-03-12 16:50 [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning Adriana Kobylak
2019-03-12 23:21 ` Andrew Jeffery
@ 2019-03-27 6:20 ` Joel Stanley
2019-03-27 15:10 ` Eddie James
1 sibling, 1 reply; 8+ messages in thread
From: Joel Stanley @ 2019-03-27 6:20 UTC (permalink / raw)
To: Adriana Kobylak; +Cc: linux-aspeed, OpenBMC Maillist, Edward A. James
On Tue, 12 Mar 2019 at 16:50, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Add simplified partitions for BMC and alternate flash. Include these by
> default in Witherspoon.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 ++-
> 3 files changed, 38 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> new file mode 100644
> index 0000000..9277599
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
As there are no other machines that use this layout, I think you
should have the layout in the dts file.
> @@ -0,0 +1,18 @@
> + label = "alt-bmc";
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "alt-u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "alt-u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "alt-obmc-ubi";
> + };
> + };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
> new file mode 100644
> index 0000000..0059ad1
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
> @@ -0,0 +1,18 @@
> + label = "bmc";
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "obmc-ubi";
> + };
> + };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index c51e3e8..058b9b7 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -191,7 +191,7 @@
> label = "bmc";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> -#include "openbmc-flash-layout.dtsi"
> +#include "aspeed-bmc-opp-flash-layout-ubi.dtsi"
> };
>
> flash@1 {
> @@ -199,6 +199,7 @@
> label = "alt";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> +#include "aspeed-bmc-alt-opp-flash-layout-ubi.dtsi"
> };
> };
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-03-27 6:20 ` Joel Stanley
@ 2019-03-27 15:10 ` Eddie James
2019-04-03 15:51 ` Adriana Kobylak
0 siblings, 1 reply; 8+ messages in thread
From: Eddie James @ 2019-03-27 15:10 UTC (permalink / raw)
To: Joel Stanley, Adriana Kobylak; +Cc: OpenBMC Maillist, linux-aspeed
On 3/27/19 1:20 AM, Joel Stanley wrote:
> On Tue, 12 Mar 2019 at 16:50, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>> From: "Edward A. James" <eajames@us.ibm.com>
>>
>> Add simplified partitions for BMC and alternate flash. Include these by
>> default in Witherspoon.
>>
>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> .../boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
>> arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi | 18 ++++++++++++++++++
>> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 ++-
>> 3 files changed, 38 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>> new file mode 100644
>> index 0000000..9277599
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
> As there are no other machines that use this layout, I think you
> should have the layout in the dts file.
I think the idea was we might have more machines that use this layout in
the future...
>
>> @@ -0,0 +1,18 @@
>> + label = "alt-bmc";
>> + partitions {
>> + #address-cells = < 1 >;
>> + #size-cells = < 1 >;
>> + compatible = "fixed-partitions";
>> + u-boot@0 {
>> + reg = < 0 0x60000 >;
>> + label = "alt-u-boot";
>> + };
>> + u-boot-env@60000 {
>> + reg = < 0x60000 0x20000 >;
>> + label = "alt-u-boot-env";
>> + };
>> + obmc-ubi@80000 {
>> + reg = < 0x80000 0x1F80000 >;
>> + label = "alt-obmc-ubi";
>> + };
>> + };
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>> new file mode 100644
>> index 0000000..0059ad1
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>> @@ -0,0 +1,18 @@
>> + label = "bmc";
>> + partitions {
>> + #address-cells = < 1 >;
>> + #size-cells = < 1 >;
>> + compatible = "fixed-partitions";
>> + u-boot@0 {
>> + reg = < 0 0x60000 >;
>> + label = "u-boot";
>> + };
>> + u-boot-env@60000 {
>> + reg = < 0x60000 0x20000 >;
>> + label = "u-boot-env";
>> + };
>> + obmc-ubi@80000 {
>> + reg = < 0x80000 0x1F80000 >;
>> + label = "obmc-ubi";
>> + };
>> + };
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> index c51e3e8..058b9b7 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>> @@ -191,7 +191,7 @@
>> label = "bmc";
>> m25p,fast-read;
>> spi-max-frequency = <50000000>;
>> -#include "openbmc-flash-layout.dtsi"
>> +#include "aspeed-bmc-opp-flash-layout-ubi.dtsi"
>> };
>>
>> flash@1 {
>> @@ -199,6 +199,7 @@
>> label = "alt";
>> m25p,fast-read;
>> spi-max-frequency = <50000000>;
>> +#include "aspeed-bmc-alt-opp-flash-layout-ubi.dtsi"
>> };
>> };
>>
>> --
>> 1.8.3.1
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-03-27 15:10 ` Eddie James
@ 2019-04-03 15:51 ` Adriana Kobylak
2019-04-03 16:59 ` [PATCH v2] " Adriana Kobylak
0 siblings, 1 reply; 8+ messages in thread
From: Adriana Kobylak @ 2019-04-03 15:51 UTC (permalink / raw)
To: Eddie James; +Cc: Joel Stanley, OpenBMC Maillist, linux-aspeed
On 2019-03-27 10:10, Eddie James wrote:
> On 3/27/19 1:20 AM, Joel Stanley wrote:
>> On Tue, 12 Mar 2019 at 16:50, Adriana Kobylak <anoo@linux.ibm.com>
>> wrote:
>>> From: "Edward A. James" <eajames@us.ibm.com>
>>>
>>> Add simplified partitions for BMC and alternate flash. Include these
>>> by
>>> default in Witherspoon.
>>>
>>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>>> ---
>>> .../boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi | 18
>>> ++++++++++++++++++
>>> arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi | 18
>>> ++++++++++++++++++
>>> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 ++-
>>> 3 files changed, 38 insertions(+), 1 deletion(-)
>>> create mode 100644
>>> arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>>> create mode 100644
>>> arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>>>
>>> diff --git
>>> a/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>>> b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>>> new file mode 100644
>>> index 0000000..9277599
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-alt-opp-flash-layout-ubi.dtsi
>> As there are no other machines that use this layout, I think you
>> should have the layout in the dts file.
>
> I think the idea was we might have more machines that use this layout
> in the future...
>
Yeah that was the idea. Although since Witherspoon is the only machine
using this layout I can move it to its dts file, and the layout can be
moved out if/when another machine needs it. Will re-submit a v2.
>>
>>> @@ -0,0 +1,18 @@
>>> + label = "alt-bmc";
>>> + partitions {
>>> + #address-cells = < 1 >;
>>> + #size-cells = < 1 >;
>>> + compatible = "fixed-partitions";
>>> + u-boot@0 {
>>> + reg = < 0 0x60000 >;
>>> + label = "alt-u-boot";
>>> + };
>>> + u-boot-env@60000 {
>>> + reg = < 0x60000 0x20000 >;
>>> + label = "alt-u-boot-env";
>>> + };
>>> + obmc-ubi@80000 {
>>> + reg = < 0x80000 0x1F80000 >;
>>> + label = "alt-obmc-ubi";
>>> + };
>>> + };
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>>> b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>>> new file mode 100644
>>> index 0000000..0059ad1
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-flash-layout-ubi.dtsi
>>> @@ -0,0 +1,18 @@
>>> + label = "bmc";
>>> + partitions {
>>> + #address-cells = < 1 >;
>>> + #size-cells = < 1 >;
>>> + compatible = "fixed-partitions";
>>> + u-boot@0 {
>>> + reg = < 0 0x60000 >;
>>> + label = "u-boot";
>>> + };
>>> + u-boot-env@60000 {
>>> + reg = < 0x60000 0x20000 >;
>>> + label = "u-boot-env";
>>> + };
>>> + obmc-ubi@80000 {
>>> + reg = < 0x80000 0x1F80000 >;
>>> + label = "obmc-ubi";
>>> + };
>>> + };
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>>> b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>>> index c51e3e8..058b9b7 100644
>>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
>>> @@ -191,7 +191,7 @@
>>> label = "bmc";
>>> m25p,fast-read;
>>> spi-max-frequency = <50000000>;
>>> -#include "openbmc-flash-layout.dtsi"
>>> +#include "aspeed-bmc-opp-flash-layout-ubi.dtsi"
>>> };
>>>
>>> flash@1 {
>>> @@ -199,6 +199,7 @@
>>> label = "alt";
>>> m25p,fast-read;
>>> spi-max-frequency = <50000000>;
>>> +#include "aspeed-bmc-alt-opp-flash-layout-ubi.dtsi"
>>> };
>>> };
>>>
>>> --
>>> 1.8.3.1
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-04-03 15:51 ` Adriana Kobylak
@ 2019-04-03 16:59 ` Adriana Kobylak
2019-04-03 17:02 ` Cédric Le Goater
0 siblings, 1 reply; 8+ messages in thread
From: Adriana Kobylak @ 2019-04-03 16:59 UTC (permalink / raw)
To: joel, linux-aspeed, openbmc; +Cc: Edward A. James, Adriana Kobylak
From: "Edward A. James" <eajames@us.ibm.com>
Add simplified partitions for BMC and alternate flash. Include these by
default in Witherspoon.
Signed-off-by: Edward A. James <eajames@us.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 37 ++++++++++++++++++++++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index 1cdc96d..82f63aa 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -194,14 +194,47 @@
label = "bmc";
m25p,fast-read;
spi-max-frequency = <50000000>;
-#include "openbmc-flash-layout.dtsi"
+ partitions {
+ #address-cells = < 1 >;
+ #size-cells = < 1 >;
+ compatible = "fixed-partitions";
+ u-boot@0 {
+ reg = < 0 0x60000 >;
+ label = "u-boot";
+ };
+ u-boot-env@60000 {
+ reg = < 0x60000 0x20000 >;
+ label = "u-boot-env";
+ };
+ obmc-ubi@80000 {
+ reg = < 0x80000 0x1F80000 >;
+ label = "obmc-ubi";
+ };
+ };
};
flash@1 {
status = "okay";
- label = "alt";
+ label = "alt-bmc";
m25p,fast-read;
spi-max-frequency = <50000000>;
+ partitions {
+ #address-cells = < 1 >;
+ #size-cells = < 1 >;
+ compatible = "fixed-partitions";
+ u-boot@0 {
+ reg = < 0 0x60000 >;
+ label = "alt-u-boot";
+ };
+ u-boot-env@60000 {
+ reg = < 0x60000 0x20000 >;
+ label = "alt-u-boot-env";
+ };
+ obmc-ubi@80000 {
+ reg = < 0x80000 0x1F80000 >;
+ label = "alt-obmc-ubi";
+ };
+ };
};
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-04-03 16:59 ` [PATCH v2] " Adriana Kobylak
@ 2019-04-03 17:02 ` Cédric Le Goater
2019-04-04 0:34 ` Andrew Jeffery
0 siblings, 1 reply; 8+ messages in thread
From: Cédric Le Goater @ 2019-04-03 17:02 UTC (permalink / raw)
To: Adriana Kobylak, joel, linux-aspeed, openbmc
Cc: Edward A. James, Adriana Kobylak
On 4/3/19 6:59 PM, Adriana Kobylak wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Add simplified partitions for BMC and alternate flash. Include these by
> default in Witherspoon.
at last ! :
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 37 ++++++++++++++++++++++--
> 1 file changed, 35 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 1cdc96d..82f63aa 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -194,14 +194,47 @@
> label = "bmc";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> -#include "openbmc-flash-layout.dtsi"
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "obmc-ubi";
> + };
> + };
> };
>
> flash@1 {
> status = "okay";
> - label = "alt";
> + label = "alt-bmc";
> m25p,fast-read;
> spi-max-frequency = <50000000>;
> + partitions {
> + #address-cells = < 1 >;
> + #size-cells = < 1 >;
> + compatible = "fixed-partitions";
> + u-boot@0 {
> + reg = < 0 0x60000 >;
> + label = "alt-u-boot";
> + };
> + u-boot-env@60000 {
> + reg = < 0x60000 0x20000 >;
> + label = "alt-u-boot-env";
> + };
> + obmc-ubi@80000 {
> + reg = < 0x80000 0x1F80000 >;
> + label = "alt-obmc-ubi";
> + };
> + };
> };
> };
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning
2019-04-03 17:02 ` Cédric Le Goater
@ 2019-04-04 0:34 ` Andrew Jeffery
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2019-04-04 0:34 UTC (permalink / raw)
To: Cédric Le Goater, Adriana Kobylak, Joel Stanley,
linux-aspeed, openbmc
Cc: Edward A. James, Adriana Kobylak
On Thu, 4 Apr 2019, at 04:09, Cédric Le Goater wrote:
> On 4/3/19 6:59 PM, Adriana Kobylak wrote:
> > From: "Edward A. James" <eajames@us.ibm.com>
> >
> > Add simplified partitions for BMC and alternate flash. Include these by
> > default in Witherspoon.
>
> at last ! :
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Piling on:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> Thanks,
>
> C.
>
> >
> > Signed-off-by: Edward A. James <eajames@us.ibm.com>
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 37 ++++++++++++++++++++++--
> > 1 file changed, 35 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > index 1cdc96d..82f63aa 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > @@ -194,14 +194,47 @@
> > label = "bmc";
> > m25p,fast-read;
> > spi-max-frequency = <50000000>;
> > -#include "openbmc-flash-layout.dtsi"
> > + partitions {
> > + #address-cells = < 1 >;
> > + #size-cells = < 1 >;
> > + compatible = "fixed-partitions";
> > + u-boot@0 {
> > + reg = < 0 0x60000 >;
> > + label = "u-boot";
> > + };
> > + u-boot-env@60000 {
> > + reg = < 0x60000 0x20000 >;
> > + label = "u-boot-env";
> > + };
> > + obmc-ubi@80000 {
> > + reg = < 0x80000 0x1F80000 >;
> > + label = "obmc-ubi";
> > + };
> > + };
> > };
> >
> > flash@1 {
> > status = "okay";
> > - label = "alt";
> > + label = "alt-bmc";
> > m25p,fast-read;
> > spi-max-frequency = <50000000>;
> > + partitions {
> > + #address-cells = < 1 >;
> > + #size-cells = < 1 >;
> > + compatible = "fixed-partitions";
> > + u-boot@0 {
> > + reg = < 0 0x60000 >;
> > + label = "alt-u-boot";
> > + };
> > + u-boot-env@60000 {
> > + reg = < 0x60000 0x20000 >;
> > + label = "alt-u-boot-env";
> > + };
> > + obmc-ubi@80000 {
> > + reg = < 0x80000 0x1F80000 >;
> > + label = "alt-obmc-ubi";
> > + };
> > + };
> > };
> > };
> >
> >
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-04 0:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 16:50 [PATCH] ARM: dts: Aspeed: Witherspoon: Update BMC partitioning Adriana Kobylak
2019-03-12 23:21 ` Andrew Jeffery
2019-03-27 6:20 ` Joel Stanley
2019-03-27 15:10 ` Eddie James
2019-04-03 15:51 ` Adriana Kobylak
2019-04-03 16:59 ` [PATCH v2] " Adriana Kobylak
2019-04-03 17:02 ` Cédric Le Goater
2019-04-04 0:34 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).