openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-i2c@vger.kernel.org, Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support
Date: Mon, 28 Feb 2022 10:10:23 -0800	[thread overview]
Message-ID: <9edce888-8e7c-9c97-dc70-17df7f348832@roeck-us.net> (raw)
In-Reply-To: <Yh0CUzBzGJc4zyTR@hatter.bewilderbeest.net>

On 2/28/22 09:11, Zev Weiss wrote:
> On Mon, Feb 28, 2022 at 05:57:27AM PST, Guenter Roeck wrote:
>> On 2/28/22 00:43, Zev Weiss wrote:
>>> On Mon, Jan 31, 2022 at 04:18:08PM PST, Zev Weiss wrote:
>>>> Hello,
>>>>
>>>> This series adds support for a new pca9541 device-tree property
>>>> ("release-delay-us"), which delays releasing ownership of the bus
>>>> after a transaction for a configurable duration, anticipating that
>>>> another transaction may follow shortly.  By avoiding a
>>>> release/reacquisition between transactions, this can provide a
>>>> substantial performance improvement for back-to-back operations -- on
>>>> a Delta AHE-50DC (ASPEED AST1250) system running OpenBMC with dozens
>>>> of LM25066 PMICs on PCA9541-arbitrated busses, a setting of 10000 (10
>>>> ms) reduces the median latency the psusensor daemon's hwmon sysfs file
>>>> reads from 2.28 ms to 0.99 ms (a 57% improvement).
>>>>
>>>
>>> Ping...Guenter, any thoughts on this?
>>>
>>
>> It sounds reasonable to me, but I don't have access to hardware anymore
>> to test it, so I have no means to confirm that it actually works.
>>
> 
> Ack, thanks.  In that case, what's the path forward on getting changes to this driver merged?  I see sign-offs from Wolfram and Peter on the last few commits that touched it -- any input from the i2c/i2c-mux maintainers?
> 

The i2c/i2c-mux maintainers will need to accept it, and you'll need
approval for the DT changes from a DT maintainer (presumably Rob).

Guenter

  parent reply	other threads:[~2022-02-28 18:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  0:18 [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support Zev Weiss
2022-02-01  0:18 ` [PATCH v2 1/2] i2c: " Zev Weiss
2022-02-01  0:18 ` [PATCH v2 2/2] dt-bindings: i2c: add nxp, pca9541 release-delay-us property Zev Weiss
2022-02-09 21:47   ` [PATCH v2 2/2] dt-bindings: i2c: add nxp,pca9541 " Rob Herring
2022-02-28  8:43 ` [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support Zev Weiss
2022-02-28 13:57   ` Guenter Roeck
2022-02-28 17:11     ` Zev Weiss
2022-02-28 17:19       ` Wolfram Sang
2022-02-28 18:10       ` Guenter Roeck [this message]
2022-02-28 21:54 ` Peter Rosin
2022-02-28 22:38   ` Zev Weiss
2022-03-02 14:43     ` Peter Rosin
2022-03-03  0:43       ` Zev Weiss
2022-03-18 11:00         ` Wolfram Sang
2022-03-21 22:32           ` Zev Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9edce888-8e7c-9c97-dc70-17df7f348832@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    --cc=wsa@kernel.org \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).