From: Peter Rosin <peda@axentia.se>
To: Zev Weiss <zev@bewilderbeest.net>,
linux-i2c@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support
Date: Mon, 28 Feb 2022 22:54:09 +0100 [thread overview]
Message-ID: <ae14fd3c-2f50-b982-c61c-9db3bb28c809@axentia.se> (raw)
In-Reply-To: <20220201001810.19516-1-zev@bewilderbeest.net>
On 2022-02-01 01:18, Zev Weiss wrote:
> Hello,
>
> This series adds support for a new pca9541 device-tree property
> ("release-delay-us"), which delays releasing ownership of the bus
> after a transaction for a configurable duration, anticipating that
> another transaction may follow shortly. By avoiding a
> release/reacquisition between transactions, this can provide a
> substantial performance improvement for back-to-back operations -- on
> a Delta AHE-50DC (ASPEED AST1250) system running OpenBMC with dozens
> of LM25066 PMICs on PCA9541-arbitrated busses, a setting of 10000 (10
> ms) reduces the median latency the psusensor daemon's hwmon sysfs file
> reads from 2.28 ms to 0.99 ms (a 57% improvement).
Hi!
Sorry for the late reply. It seems I'm forever swamped...
There is a risk with this scheme. If you have two (or more) of these
chips on the same bus, and there are clients behind these two chips
that have the same address, accesses to one of the clients might
"leak through" the other arb to an unexpected client when its arb
is in it's release-delay state.
In other words, it is no coincidence that the segment lock is held
over the whole acquire-access-release cycle.
Sure, you can always say "don't add a release-delay when ...", but I
see no such documentation.
I have no access to this HW either.
Cheers,
Peter
next prev parent reply other threads:[~2022-02-28 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 0:18 [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support Zev Weiss
2022-02-01 0:18 ` [PATCH v2 1/2] i2c: " Zev Weiss
2022-02-01 0:18 ` [PATCH v2 2/2] dt-bindings: i2c: add nxp, pca9541 release-delay-us property Zev Weiss
2022-02-09 21:47 ` [PATCH v2 2/2] dt-bindings: i2c: add nxp,pca9541 " Rob Herring
2022-02-28 8:43 ` [PATCH v2 0/2] ic2: mux: pca9541: add delayed-release support Zev Weiss
2022-02-28 13:57 ` Guenter Roeck
2022-02-28 17:11 ` Zev Weiss
2022-02-28 17:19 ` Wolfram Sang
2022-02-28 18:10 ` Guenter Roeck
2022-02-28 21:54 ` Peter Rosin [this message]
2022-02-28 22:38 ` Zev Weiss
2022-03-02 14:43 ` Peter Rosin
2022-03-03 0:43 ` Zev Weiss
2022-03-18 11:00 ` Wolfram Sang
2022-03-21 22:32 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae14fd3c-2f50-b982-c61c-9db3bb28c809@axentia.se \
--to=peda@axentia.se \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).