openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: karthikeyan P <pkarthikeyan1509@gmail.com>
To: Zev Weiss <zweiss@equinix.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card
Date: Tue, 27 Sep 2022 11:09:59 +0530	[thread overview]
Message-ID: <CA+ezb7hdM7KZrEVVFHGQmMbeFe-5-WXKnnVOzR6p+=SGW1mMvg@mail.gmail.com> (raw)
In-Reply-To: <20220927015130.GG30806@packtop>

[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]

Thanks!

On Tue, Sep 27, 2022 at 7:21 AM Zev Weiss <zweiss@equinix.com> wrote:

> On Mon, Sep 26, 2022 at 05:43:13AM PDT, Karthikeyan Pasupathi wrote:
> >Added IPMB-13 channel for Debug Card communication.
> >which improves the readability of the machine and makes
> >it easier to debug the server and it will display some
> >pieces of information about the server like "system info",
> >"Critical sensors" and "critical sel".
> >
> >---
> >--- v5- Updated commit message
> >--- v4- Resolved syntax error
> >--- v3- Updated the title and commit
> >--- v2- Updated the title
> >--- v1- Initial draft
> >---
> >
>
> Note that git treats a '---' line as a separator, so everything past the
> first one above will be discarded when this patch is applied (e.g. via
> 'git am')...
>
> >Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
>
> ...including your S-O-B line here.
>
> If you're aiming to do something like what Joel describes on his blog
> (https://shenki.github.io/git-patch-workflow/), you should make sure put
> your first '---' line and any non-commit-message notes *after* your
> S-O-B and any other tags.
>
> >---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >index 8864e9c312a8..84236df522dc 100644
> >--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >@@ -215,6 +215,17 @@
> >       };
> > };
> >
> >+&i2c13 {
> >+      status = "okay";
> >+      // Debug Card
> >+      multi-master;
> >+      ipmb13@10 {
> >+              compatible = "ipmb-dev";
> >+              reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> >+              i2c-protocol;
> >+      };
> >+};
> >+
> > &pwm_tacho {
> >       status = "okay";
> >       //FSC
> >--
> >2.17.1
> >

[-- Attachment #2: Type: text/html, Size: 2844 bytes --]

      reply	other threads:[~2022-09-28  2:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 12:43 [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card Karthikeyan Pasupathi
2022-09-27  1:51 ` Zev Weiss
2022-09-27  5:39   ` karthikeyan P [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ezb7hdM7KZrEVVFHGQmMbeFe-5-WXKnnVOzR6p+=SGW1mMvg@mail.gmail.com' \
    --to=pkarthikeyan1509@gmail.com \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=zweiss@equinix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).