* [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card
@ 2022-09-26 12:43 Karthikeyan Pasupathi
2022-09-27 1:51 ` Zev Weiss
0 siblings, 1 reply; 3+ messages in thread
From: Karthikeyan Pasupathi @ 2022-09-26 12:43 UTC (permalink / raw)
To: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, openbmc
Added IPMB-13 channel for Debug Card communication.
which improves the readability of the machine and makes
it easier to debug the server and it will display some
pieces of information about the server like "system info",
"Critical sensors" and "critical sel".
---
--- v5- Updated commit message
--- v4- Resolved syntax error
--- v3- Updated the title and commit
--- v2- Updated the title
--- v1- Initial draft
---
Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
index 8864e9c312a8..84236df522dc 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
@@ -215,6 +215,17 @@
};
};
+&i2c13 {
+ status = "okay";
+ // Debug Card
+ multi-master;
+ ipmb13@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
&pwm_tacho {
status = "okay";
//FSC
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card
2022-09-26 12:43 [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card Karthikeyan Pasupathi
@ 2022-09-27 1:51 ` Zev Weiss
2022-09-27 5:39 ` karthikeyan P
0 siblings, 1 reply; 3+ messages in thread
From: Zev Weiss @ 2022-09-27 1:51 UTC (permalink / raw)
To: Karthikeyan Pasupathi
Cc: devicetree, linux-aspeed, Andrew Jeffery, openbmc, linux-kernel,
Rob Herring, Joel Stanley, linux-arm-kernel
On Mon, Sep 26, 2022 at 05:43:13AM PDT, Karthikeyan Pasupathi wrote:
>Added IPMB-13 channel for Debug Card communication.
>which improves the readability of the machine and makes
>it easier to debug the server and it will display some
>pieces of information about the server like "system info",
>"Critical sensors" and "critical sel".
>
>---
>--- v5- Updated commit message
>--- v4- Resolved syntax error
>--- v3- Updated the title and commit
>--- v2- Updated the title
>--- v1- Initial draft
>---
>
Note that git treats a '---' line as a separator, so everything past the
first one above will be discarded when this patch is applied (e.g. via
'git am')...
>Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
...including your S-O-B line here.
If you're aiming to do something like what Joel describes on his blog
(https://shenki.github.io/git-patch-workflow/), you should make sure put
your first '---' line and any non-commit-message notes *after* your
S-O-B and any other tags.
>---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
>index 8864e9c312a8..84236df522dc 100644
>--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
>+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
>@@ -215,6 +215,17 @@
> };
> };
>
>+&i2c13 {
>+ status = "okay";
>+ // Debug Card
>+ multi-master;
>+ ipmb13@10 {
>+ compatible = "ipmb-dev";
>+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
>+ i2c-protocol;
>+ };
>+};
>+
> &pwm_tacho {
> status = "okay";
> //FSC
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card
2022-09-27 1:51 ` Zev Weiss
@ 2022-09-27 5:39 ` karthikeyan P
0 siblings, 0 replies; 3+ messages in thread
From: karthikeyan P @ 2022-09-27 5:39 UTC (permalink / raw)
To: Zev Weiss
Cc: devicetree, linux-aspeed, Andrew Jeffery, openbmc, linux-kernel,
Rob Herring, Joel Stanley, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]
Thanks!
On Tue, Sep 27, 2022 at 7:21 AM Zev Weiss <zweiss@equinix.com> wrote:
> On Mon, Sep 26, 2022 at 05:43:13AM PDT, Karthikeyan Pasupathi wrote:
> >Added IPMB-13 channel for Debug Card communication.
> >which improves the readability of the machine and makes
> >it easier to debug the server and it will display some
> >pieces of information about the server like "system info",
> >"Critical sensors" and "critical sel".
> >
> >---
> >--- v5- Updated commit message
> >--- v4- Resolved syntax error
> >--- v3- Updated the title and commit
> >--- v2- Updated the title
> >--- v1- Initial draft
> >---
> >
>
> Note that git treats a '---' line as a separator, so everything past the
> first one above will be discarded when this patch is applied (e.g. via
> 'git am')...
>
> >Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
>
> ...including your S-O-B line here.
>
> If you're aiming to do something like what Joel describes on his blog
> (https://shenki.github.io/git-patch-workflow/), you should make sure put
> your first '---' line and any non-commit-message notes *after* your
> S-O-B and any other tags.
>
> >---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >index 8864e9c312a8..84236df522dc 100644
> >--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> >@@ -215,6 +215,17 @@
> > };
> > };
> >
> >+&i2c13 {
> >+ status = "okay";
> >+ // Debug Card
> >+ multi-master;
> >+ ipmb13@10 {
> >+ compatible = "ipmb-dev";
> >+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> >+ i2c-protocol;
> >+ };
> >+};
> >+
> > &pwm_tacho {
> > status = "okay";
> > //FSC
> >--
> >2.17.1
> >
[-- Attachment #2: Type: text/html, Size: 2844 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 12:43 [PATCH v5] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card Karthikeyan Pasupathi
2022-09-27 1:51 ` Zev Weiss
2022-09-27 5:39 ` karthikeyan P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).