* [PATCH u-boot v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings
@ 2022-07-15 3:33 Joel Stanley
2022-07-15 7:25 ` Paul Menzel
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2022-07-15 3:33 UTC (permalink / raw)
To: openbmc
mkimage is linked against the host version of OpenSSL. If the distro
happens to be using OpenSSL 3.0 then several warnings about using
depreciated functions will be emitted.
warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
These functions still work for now, so suppress the warning and delay
the need to move to the new API.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
The backport to move to the newer OpenSSL APIs are complicated. Instead
of focusing on fixing the old branch, work is being done to move to a
newer u-boot base.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
tools/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index 81aa374a32dd..9e7a8e85435d 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -159,10 +159,12 @@ HOSTLOADLIBES_mkimage += \
ifeq ($(HOSTOS),darwin)
HOSTCFLAGS_mxsimage.o += -Wno-deprecated-declarations
HOSTCFLAGS_image-sig.o += -Wno-deprecated-declarations
-HOSTCFLAGS_rsa-sign.o += -Wno-deprecated-declarations
endif
endif
+# Disable warnings on systems with OpenSSL 3.0
+HOSTCFLAGS_rsa-sign.o += -Wno-deprecated-declarations
+
HOSTCFLAGS_fit_image.o += -DMKIMAGE_DTC=\"$(CONFIG_MKIMAGE_DTC_PATH)\"
HOSTLOADLIBES_dumpimage := $(HOSTLOADLIBES_mkimage)
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH u-boot v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings
2022-07-15 3:33 [PATCH u-boot v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings Joel Stanley
@ 2022-07-15 7:25 ` Paul Menzel
2022-07-18 8:31 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Paul Menzel @ 2022-07-15 7:25 UTC (permalink / raw)
To: Joel Stanley; +Cc: openbmc
Dear Joel,
Thank you for the patch.
Am 15.07.22 um 05:33 schrieb Joel Stanley:
> mkimage is linked against the host version of OpenSSL. If the distro
> happens to be using OpenSSL 3.0 then several warnings about using
> depreciated functions will be emitted.
sdepreciated/deprecated/
>
> warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
>
> These functions still work for now, so suppress the warning and delay
> the need to move to the new API.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
[…]
Reviewed-by: Paul Menzel <pmenzel@molgne.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH u-boot v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings
2022-07-15 7:25 ` Paul Menzel
@ 2022-07-18 8:31 ` Joel Stanley
0 siblings, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2022-07-18 8:31 UTC (permalink / raw)
To: Paul Menzel; +Cc: OpenBMC Maillist
On Fri, 15 Jul 2022 at 07:25, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Joel,
>
>
> Thank you for the patch.
>
> Am 15.07.22 um 05:33 schrieb Joel Stanley:
> > mkimage is linked against the host version of OpenSSL. If the distro
> > happens to be using OpenSSL 3.0 then several warnings about using
> > depreciated functions will be emitted.
>
> sdepreciated/deprecated/
>
> >
> > warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
> >
> > These functions still work for now, so suppress the warning and delay
> > the need to move to the new API.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> […]
>
> Reviewed-by: Paul Menzel <pmenzel@molgne.mpg.de>
Thanks for the review. I fixed the grammar and committed it.
Cheers,
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 3:33 [PATCH u-boot v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings Joel Stanley
2022-07-15 7:25 ` Paul Menzel
2022-07-18 8:31 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).