* [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip
@ 2019-02-08 17:28 Adriana Kobylak
2019-02-08 17:55 ` [PATCH] " Adriana Kobylak
2019-04-03 12:36 ` [PATCH u-boot] " Brad Bishop
0 siblings, 2 replies; 7+ messages in thread
From: Adriana Kobylak @ 2019-02-08 17:28 UTC (permalink / raw)
To: openbmc; +Cc: Adriana Kobylak
From: Adriana Kobylak <anoo@us.linux.com>
The MT25QL01GB is a 128MB NOR flash chip planned to be used on
a Witherspoon system (AST2500).
Signed-off-by: Adriana Kobylak <anoo@us.linux.com>
---
arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
index 907e785..54a6059 100644
--- a/arch/arm/mach-aspeed/flash.c
+++ b/arch/arm/mach-aspeed/flash.c
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* FLASH chips info */
#define SST25VF040B 0x8d25bf
#define AT25DF161 0x02461F
#define AT25DF321 0x01471F
+#define MT25QL01GB 0x21ba20
/* SPI Define */
#define CS0_CTRL 0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
ReadClk = 50;
break;
+ case MT25QL01GB:
+ info->sector_count = 2048;
+ info->size = 0x8000000;
+ erase_region_size = 0x10000;
+ info->readcmd = 0x0b;
+ info->dualport = 0;
+ info->dummybyte = 1;
+ info->buffersize = 1;
+ WriteClk = 50;
+ EraseClk = 25;
+ ReadClk = 50;
+ break;
+
default: /* use JEDEC ID */
printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
erase_region_size = 0x10000;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] aspeed: flash: Add MT25QL01GB chip
2019-02-08 17:28 [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip Adriana Kobylak
@ 2019-02-08 17:55 ` Adriana Kobylak
2019-04-03 12:36 ` [PATCH u-boot] " Brad Bishop
1 sibling, 0 replies; 7+ messages in thread
From: Adriana Kobylak @ 2019-02-08 17:55 UTC (permalink / raw)
To: openbmc
The MT25QL01GB is a 128MB NOR flash chip planned to be used on
a Witherspoon system (AST2500).
Signed-off-by: Adriana Kobylak <anoo@linux.ibm.com>
---
arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
index 907e785..54a6059 100644
--- a/arch/arm/mach-aspeed/flash.c
+++ b/arch/arm/mach-aspeed/flash.c
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* FLASH chips info */
#define SST25VF040B 0x8d25bf
#define AT25DF161 0x02461F
#define AT25DF321 0x01471F
+#define MT25QL01GB 0x21ba20
/* SPI Define */
#define CS0_CTRL 0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
ReadClk = 50;
break;
+ case MT25QL01GB:
+ info->sector_count = 2048;
+ info->size = 0x8000000;
+ erase_region_size = 0x10000;
+ info->readcmd = 0x0b;
+ info->dualport = 0;
+ info->dummybyte = 1;
+ info->buffersize = 1;
+ WriteClk = 50;
+ EraseClk = 25;
+ ReadClk = 50;
+ break;
+
default: /* use JEDEC ID */
printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
erase_region_size = 0x10000;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip
2019-02-08 17:28 [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip Adriana Kobylak
2019-02-08 17:55 ` [PATCH] " Adriana Kobylak
@ 2019-04-03 12:36 ` Brad Bishop
2019-04-04 6:24 ` Joel Stanley
1 sibling, 1 reply; 7+ messages in thread
From: Brad Bishop @ 2019-04-03 12:36 UTC (permalink / raw)
To: joel; +Cc: openbmc, Adriana Kobylak
On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
>From: Adriana Kobylak <anoo@us.linux.com>
>
>The MT25QL01GB is a 128MB NOR flash chip planned to be used on
>a Witherspoon system (AST2500).
>
>Signed-off-by: Adriana Kobylak <anoo@us.linux.com>
>---
> arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
>index 907e785..54a6059 100644
>--- a/arch/arm/mach-aspeed/flash.c
>+++ b/arch/arm/mach-aspeed/flash.c
>@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* FLASH chips info */
> #define SST25VF040B 0x8d25bf
> #define AT25DF161 0x02461F
> #define AT25DF321 0x01471F
>+#define MT25QL01GB 0x21ba20
>
> /* SPI Define */
> #define CS0_CTRL 0x10
>@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
> ReadClk = 50;
> break;
>
>+ case MT25QL01GB:
>+ info->sector_count = 2048;
>+ info->size = 0x8000000;
>+ erase_region_size = 0x10000;
>+ info->readcmd = 0x0b;
>+ info->dualport = 0;
>+ info->dummybyte = 1;
>+ info->buffersize = 1;
>+ WriteClk = 50;
>+ EraseClk = 25;
>+ ReadClk = 50;
>+ break;
>+
> default: /* use JEDEC ID */
> printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
> erase_region_size = 0x10000;
>--
>1.8.3.1
Hi Joel
Would you be willing to carry this u-boot patch and if so, what all
would you like to see from our end to enable that?
thx - Brad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip
2019-04-03 12:36 ` [PATCH u-boot] " Brad Bishop
@ 2019-04-04 6:24 ` Joel Stanley
2019-04-04 6:30 ` Joel Stanley
0 siblings, 1 reply; 7+ messages in thread
From: Joel Stanley @ 2019-04-04 6:24 UTC (permalink / raw)
To: Brad Bishop; +Cc: OpenBMC Maillist, Adriana Kobylak
On Wed, 3 Apr 2019 at 12:35, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote:
>
> On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
> >From: Adriana Kobylak <anoo@us.linux.com>
> >
> >The MT25QL01GB is a 128MB NOR flash chip planned to be used on
> >a Witherspoon system (AST2500).
> >
>
> Would you be willing to carry this u-boot patch and if so, what all
> would you like to see from our end to enable that?
Where does Adriana want it applied? The subject doesn't indicate a branch.
I didn't look at it becuase I assumed it was an upstream patch.
Looking at it now it is obviously meant for the ancient openbmc tree.
I have applied it to v2016.07-aspeed-openbmc.
In the future, adding the correct tags to the subject, and sending
reviewed and tested tags will help me apply your patch.
Cheers,
Joel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip
2019-04-04 6:24 ` Joel Stanley
@ 2019-04-04 6:30 ` Joel Stanley
2019-04-04 14:29 ` [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: " Adriana Kobylak
0 siblings, 1 reply; 7+ messages in thread
From: Joel Stanley @ 2019-04-04 6:30 UTC (permalink / raw)
To: Brad Bishop; +Cc: OpenBMC Maillist, Adriana Kobylak
On Thu, 4 Apr 2019 at 06:24, Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 3 Apr 2019 at 12:35, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote:
> >
> > On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
> > >From: Adriana Kobylak <anoo@us.linux.com>
Adriana, you need to fix up your email address. Once you've done that
regenerate the patch with --reset-author and make sure the
signed-off-by is correct.
Cheers,
Joel
> > >
> > >The MT25QL01GB is a 128MB NOR flash chip planned to be used on
> > >a Witherspoon system (AST2500).
> > >
>
> >
> > Would you be willing to carry this u-boot patch and if so, what all
> > would you like to see from our end to enable that?
>
> Where does Adriana want it applied? The subject doesn't indicate a branch.
>
> I didn't look at it becuase I assumed it was an upstream patch.
> Looking at it now it is obviously meant for the ancient openbmc tree.
> I have applied it to v2016.07-aspeed-openbmc.
>
> In the future, adding the correct tags to the subject, and sending
> reviewed and tested tags will help me apply your patch.
>
> Cheers,
>
> Joel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: Add MT25QL01GB chip
2019-04-04 6:30 ` Joel Stanley
@ 2019-04-04 14:29 ` Adriana Kobylak
2019-04-05 3:55 ` Joel Stanley
0 siblings, 1 reply; 7+ messages in thread
From: Adriana Kobylak @ 2019-04-04 14:29 UTC (permalink / raw)
To: joel, openbmc; +Cc: Adriana Kobylak
From: Adriana Kobylak <anoo@us.ibm.com>
The MT25QL01GB is a 128MB NOR flash chip planned to be used on
a Witherspoon system (AST2500).
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Tested-by: Adriana Kobylak <anoo@us.ibm.com>
---
arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
index 907e785..54a6059 100644
--- a/arch/arm/mach-aspeed/flash.c
+++ b/arch/arm/mach-aspeed/flash.c
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* FLASH chips info */
#define SST25VF040B 0x8d25bf
#define AT25DF161 0x02461F
#define AT25DF321 0x01471F
+#define MT25QL01GB 0x21ba20
/* SPI Define */
#define CS0_CTRL 0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
ReadClk = 50;
break;
+ case MT25QL01GB:
+ info->sector_count = 2048;
+ info->size = 0x8000000;
+ erase_region_size = 0x10000;
+ info->readcmd = 0x0b;
+ info->dualport = 0;
+ info->dummybyte = 1;
+ info->buffersize = 1;
+ WriteClk = 50;
+ EraseClk = 25;
+ ReadClk = 50;
+ break;
+
default: /* use JEDEC ID */
printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
erase_region_size = 0x10000;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: Add MT25QL01GB chip
2019-04-04 14:29 ` [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: " Adriana Kobylak
@ 2019-04-05 3:55 ` Joel Stanley
0 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2019-04-05 3:55 UTC (permalink / raw)
To: Adriana Kobylak; +Cc: OpenBMC Maillist, Adriana Kobylak
On Thu, 4 Apr 2019 at 14:30, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> The MT25QL01GB is a 128MB NOR flash chip planned to be used on
> a Witherspoon system (AST2500).
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> Tested-by: Adriana Kobylak <anoo@us.ibm.com>
That looks better. I've applied this one.
Thanks,
Joel
> ---
> arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
> index 907e785..54a6059 100644
> --- a/arch/arm/mach-aspeed/flash.c
> +++ b/arch/arm/mach-aspeed/flash.c
> @@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* FLASH chips info */
> #define SST25VF040B 0x8d25bf
> #define AT25DF161 0x02461F
> #define AT25DF321 0x01471F
> +#define MT25QL01GB 0x21ba20
>
> /* SPI Define */
> #define CS0_CTRL 0x10
> @@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
> ReadClk = 50;
> break;
>
> + case MT25QL01GB:
> + info->sector_count = 2048;
> + info->size = 0x8000000;
> + erase_region_size = 0x10000;
> + info->readcmd = 0x0b;
> + info->dualport = 0;
> + info->dummybyte = 1;
> + info->buffersize = 1;
> + WriteClk = 50;
> + EraseClk = 25;
> + ReadClk = 50;
> + break;
> +
> default: /* use JEDEC ID */
> printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
> erase_region_size = 0x10000;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-05 3:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 17:28 [PATCH u-boot] aspeed: flash: Add MT25QL01GB chip Adriana Kobylak
2019-02-08 17:55 ` [PATCH] " Adriana Kobylak
2019-04-03 12:36 ` [PATCH u-boot] " Brad Bishop
2019-04-04 6:24 ` Joel Stanley
2019-04-04 6:30 ` Joel Stanley
2019-04-04 14:29 ` [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: " Adriana Kobylak
2019-04-05 3:55 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).