From: Joel Stanley <joel@jms.id.au>
To: Willy Tu <wltu@google.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
William Kennington <wak@google.com>
Subject: Re: [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
Date: Thu, 27 May 2021 04:48:56 +0000 [thread overview]
Message-ID: <CACPK8XemenVwv-n-mi6mpHUFKXaLtbAxRKbQQKnXf==zymR5TQ@mail.gmail.com> (raw)
In-Reply-To: <CAHwn2X=pYrX0ZCrSuzSZ-cW86EP9gaDCLTDjeWHBq35Nhg2KBg@mail.gmail.com>
Hi WIlly,
I know that Google's mail clients make this harder than it should be,
but please do not top post when replying on the mailing list.
On Thu, 27 May 2021 at 03:02, Willy Tu <wltu@google.com> wrote:
>
> ah, good catch.
>
> I didn't realize that was the case. It looks like it is up to Nuvoton to upstream it.
>
> https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800
>
> Or maybe I can just make the change for them? Not sure.
I suggest sending a patch to mainline to support the features that
Nuvoton have in that tree.
Cheers,
Joel
>
> Willy Tu
>
> On Wed, May 26, 2021 at 6:51 PM Joel Stanley <joel@jms.id.au> wrote:
>>
>> On Wed, 26 May 2021 at 15:48, Willy Tu <wltu@google.com> wrote:
>> >
>> > ping
>> >
>> > On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
>> >>
>> >> gsj platform sometimes also see low fan speed issue that can be partly
>> >> prevented with this fan filter.
>>
>> This property is not supported by the kernel, so it will not do
>> anything. Do you intend to submit driver support?
>>
>> >>
>> >> Signed-off-by: Willy Tu <wltu@google.com>
>> >> ---
>> >> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
>> >> 1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> index 3ff116aaacb3..86facfc08c6e 100644
>> >> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> @@ -408,18 +408,21 @@ fan@0 {
>> >> reg = <0x00>;
>> >> fan-tach-ch = /bits/ 8 <0x00 0x01>;
>> >> cooling-levels = <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >>
>> >> fan@1 {
>> >> reg = <0x01>;
>> >> fan-tach-ch = /bits/ 8 <0x02 0x03>;
>> >> cooling-levels = /bits/ 8 <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >>
>> >> fan@2 {
>> >> reg = <0x02>;
>> >> fan-tach-ch = /bits/ 8 <0x04 0x05>;
>> >> cooling-levels = /bits/ 8 <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >> };
>> >>
>> >> --
>> >> 2.31.1.498.g6c1eba8ee3d-goog
>> >>
prev parent reply other threads:[~2021-05-27 4:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 0:38 [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter Willy Tu
2021-05-26 15:48 ` Willy Tu
2021-05-27 1:51 ` Joel Stanley
2021-05-27 3:02 ` Willy Tu
2021-05-27 4:48 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XemenVwv-n-mi6mpHUFKXaLtbAxRKbQQKnXf==zymR5TQ@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=wak@google.com \
--cc=wltu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).