* [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
@ 2021-04-24 0:38 Willy Tu
2021-05-26 15:48 ` Willy Tu
0 siblings, 1 reply; 5+ messages in thread
From: Willy Tu @ 2021-04-24 0:38 UTC (permalink / raw)
To: openbmc; +Cc: Willy Tu, wak
gsj platform sometimes also see low fan speed issue that can be partly
prevented with this fan filter.
Signed-off-by: Willy Tu <wltu@google.com>
---
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
index 3ff116aaacb3..86facfc08c6e 100644
--- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
@@ -408,18 +408,21 @@ fan@0 {
reg = <0x00>;
fan-tach-ch = /bits/ 8 <0x00 0x01>;
cooling-levels = <127 255>;
+ fan_filter_en;
};
fan@1 {
reg = <0x01>;
fan-tach-ch = /bits/ 8 <0x02 0x03>;
cooling-levels = /bits/ 8 <127 255>;
+ fan_filter_en;
};
fan@2 {
reg = <0x02>;
fan-tach-ch = /bits/ 8 <0x04 0x05>;
cooling-levels = /bits/ 8 <127 255>;
+ fan_filter_en;
};
};
--
2.31.1.498.g6c1eba8ee3d-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
2021-04-24 0:38 [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter Willy Tu
@ 2021-05-26 15:48 ` Willy Tu
2021-05-27 1:51 ` Joel Stanley
0 siblings, 1 reply; 5+ messages in thread
From: Willy Tu @ 2021-05-26 15:48 UTC (permalink / raw)
To: OpenBMC Maillist; +Cc: William Kennington
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
ping
On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
> gsj platform sometimes also see low fan speed issue that can be partly
> prevented with this fan filter.
>
> Signed-off-by: Willy Tu <wltu@google.com>
> ---
> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> index 3ff116aaacb3..86facfc08c6e 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> @@ -408,18 +408,21 @@ fan@0 {
> reg = <0x00>;
> fan-tach-ch = /bits/ 8 <0x00 0x01>;
> cooling-levels = <127 255>;
> + fan_filter_en;
> };
>
> fan@1 {
> reg = <0x01>;
> fan-tach-ch = /bits/ 8 <0x02 0x03>;
> cooling-levels = /bits/ 8 <127 255>;
> + fan_filter_en;
> };
>
> fan@2 {
> reg = <0x02>;
> fan-tach-ch = /bits/ 8 <0x04 0x05>;
> cooling-levels = /bits/ 8 <127 255>;
> + fan_filter_en;
> };
> };
>
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
>
[-- Attachment #2: Type: text/html, Size: 1859 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
2021-05-26 15:48 ` Willy Tu
@ 2021-05-27 1:51 ` Joel Stanley
2021-05-27 3:02 ` Willy Tu
0 siblings, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2021-05-27 1:51 UTC (permalink / raw)
To: Willy Tu; +Cc: OpenBMC Maillist, William Kennington
On Wed, 26 May 2021 at 15:48, Willy Tu <wltu@google.com> wrote:
>
> ping
>
> On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
>>
>> gsj platform sometimes also see low fan speed issue that can be partly
>> prevented with this fan filter.
This property is not supported by the kernel, so it will not do
anything. Do you intend to submit driver support?
>>
>> Signed-off-by: Willy Tu <wltu@google.com>
>> ---
>> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> index 3ff116aaacb3..86facfc08c6e 100644
>> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> @@ -408,18 +408,21 @@ fan@0 {
>> reg = <0x00>;
>> fan-tach-ch = /bits/ 8 <0x00 0x01>;
>> cooling-levels = <127 255>;
>> + fan_filter_en;
>> };
>>
>> fan@1 {
>> reg = <0x01>;
>> fan-tach-ch = /bits/ 8 <0x02 0x03>;
>> cooling-levels = /bits/ 8 <127 255>;
>> + fan_filter_en;
>> };
>>
>> fan@2 {
>> reg = <0x02>;
>> fan-tach-ch = /bits/ 8 <0x04 0x05>;
>> cooling-levels = /bits/ 8 <127 255>;
>> + fan_filter_en;
>> };
>> };
>>
>> --
>> 2.31.1.498.g6c1eba8ee3d-goog
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
2021-05-27 1:51 ` Joel Stanley
@ 2021-05-27 3:02 ` Willy Tu
2021-05-27 4:48 ` Joel Stanley
0 siblings, 1 reply; 5+ messages in thread
From: Willy Tu @ 2021-05-27 3:02 UTC (permalink / raw)
To: Joel Stanley; +Cc: OpenBMC Maillist, William Kennington
[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]
ah, good catch.
I didn't realize that was the case. It looks like it is up to Nuvoton to
upstream it.
https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800
Or maybe I can just make the change for them? Not sure.
Willy Tu
On Wed, May 26, 2021 at 6:51 PM Joel Stanley <joel@jms.id.au> wrote:
> On Wed, 26 May 2021 at 15:48, Willy Tu <wltu@google.com> wrote:
> >
> > ping
> >
> > On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
> >>
> >> gsj platform sometimes also see low fan speed issue that can be partly
> >> prevented with this fan filter.
>
> This property is not supported by the kernel, so it will not do
> anything. Do you intend to submit driver support?
>
> >>
> >> Signed-off-by: Willy Tu <wltu@google.com>
> >> ---
> >> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> index 3ff116aaacb3..86facfc08c6e 100644
> >> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> @@ -408,18 +408,21 @@ fan@0 {
> >> reg = <0x00>;
> >> fan-tach-ch = /bits/ 8 <0x00 0x01>;
> >> cooling-levels = <127 255>;
> >> + fan_filter_en;
> >> };
> >>
> >> fan@1 {
> >> reg = <0x01>;
> >> fan-tach-ch = /bits/ 8 <0x02 0x03>;
> >> cooling-levels = /bits/ 8 <127 255>;
> >> + fan_filter_en;
> >> };
> >>
> >> fan@2 {
> >> reg = <0x02>;
> >> fan-tach-ch = /bits/ 8 <0x04 0x05>;
> >> cooling-levels = /bits/ 8 <127 255>;
> >> + fan_filter_en;
> >> };
> >> };
> >>
> >> --
> >> 2.31.1.498.g6c1eba8ee3d-goog
> >>
>
[-- Attachment #2: Type: text/html, Size: 3134 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter
2021-05-27 3:02 ` Willy Tu
@ 2021-05-27 4:48 ` Joel Stanley
0 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2021-05-27 4:48 UTC (permalink / raw)
To: Willy Tu; +Cc: OpenBMC Maillist, William Kennington
Hi WIlly,
I know that Google's mail clients make this harder than it should be,
but please do not top post when replying on the mailing list.
On Thu, 27 May 2021 at 03:02, Willy Tu <wltu@google.com> wrote:
>
> ah, good catch.
>
> I didn't realize that was the case. It looks like it is up to Nuvoton to upstream it.
>
> https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800
>
> Or maybe I can just make the change for them? Not sure.
I suggest sending a patch to mainline to support the features that
Nuvoton have in that tree.
Cheers,
Joel
>
> Willy Tu
>
> On Wed, May 26, 2021 at 6:51 PM Joel Stanley <joel@jms.id.au> wrote:
>>
>> On Wed, 26 May 2021 at 15:48, Willy Tu <wltu@google.com> wrote:
>> >
>> > ping
>> >
>> > On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
>> >>
>> >> gsj platform sometimes also see low fan speed issue that can be partly
>> >> prevented with this fan filter.
>>
>> This property is not supported by the kernel, so it will not do
>> anything. Do you intend to submit driver support?
>>
>> >>
>> >> Signed-off-by: Willy Tu <wltu@google.com>
>> >> ---
>> >> arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
>> >> 1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> index 3ff116aaacb3..86facfc08c6e 100644
>> >> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
>> >> @@ -408,18 +408,21 @@ fan@0 {
>> >> reg = <0x00>;
>> >> fan-tach-ch = /bits/ 8 <0x00 0x01>;
>> >> cooling-levels = <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >>
>> >> fan@1 {
>> >> reg = <0x01>;
>> >> fan-tach-ch = /bits/ 8 <0x02 0x03>;
>> >> cooling-levels = /bits/ 8 <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >>
>> >> fan@2 {
>> >> reg = <0x02>;
>> >> fan-tach-ch = /bits/ 8 <0x04 0x05>;
>> >> cooling-levels = /bits/ 8 <127 255>;
>> >> + fan_filter_en;
>> >> };
>> >> };
>> >>
>> >> --
>> >> 2.31.1.498.g6c1eba8ee3d-goog
>> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-27 4:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 0:38 [PATCH dev-5.10] arm: dts: nuvoton: gsj: Enable Nuvoton fan filter Willy Tu
2021-05-26 15:48 ` Willy Tu
2021-05-27 1:51 ` Joel Stanley
2021-05-27 3:02 ` Willy Tu
2021-05-27 4:48 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).