From: Joel Stanley <joel@jms.id.au>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
Andrew Jeffery <andrew@aj.id.au>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Oskar Senft <osk@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 1/5] ARM: dts: aspeed: Drop reg-io-width from LPC nodes
Date: Thu, 21 Oct 2021 06:28:56 +0000 [thread overview]
Message-ID: <CACPK8Xfj=wJBCX5ogyf02pLJsLrooVWBJ92GJ1E+jxQW5wiFEw@mail.gmail.com> (raw)
In-Reply-To: <CACPK8Xc+9yFJn_pO1sAVQJu_FWkA1U9XnbB+TLYgfdbHi1TyaQ@mail.gmail.com>
On Fri, 8 Oct 2021 at 04:35, Joel Stanley <joel@jms.id.au> wrote:
>
> On Mon, 27 Sept 2021 at 02:31, Chia-Wei Wang
> <chiawei_wang@aspeedtech.com> wrote:
> >
> > The 'reg-io-width' properties are not used by LPC drivers
> > nor documented as part of bindings. Therefore drop them.
>
> I assume they are there due to the lpc having a 'syscon' compatible.
> THey are documented in the syscon bindings:
>
> Documentation/devicetree/bindings/mfd/syscon.yaml
>
> Andrew, do you have any comments?
Andrew indicated to me that he agreed with my observation: the
properties should be present as they are used by the regmap/syscon.
>
> >
> > This is in preparation to move aspeed-lpc.txt to YAML schema.
> >
> > Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > ---
> > arch/arm/boot/dts/aspeed-g4.dtsi | 1 -
> > arch/arm/boot/dts/aspeed-g5.dtsi | 1 -
> > arch/arm/boot/dts/aspeed-g6.dtsi | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> > index c5aeb3cf3a09..45a25eb4baa4 100644
> > --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> > @@ -345,7 +345,6 @@
> > lpc: lpc@1e789000 {
> > compatible = "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon";
> > reg = <0x1e789000 0x1000>;
> > - reg-io-width = <4>;
> >
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> > index 73ca1ec6fc24..8e1d00d8445e 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -436,7 +436,6 @@
> > lpc: lpc@1e789000 {
> > compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon";
> > reg = <0x1e789000 0x1000>;
> > - reg-io-width = <4>;
> >
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index 1b47be1704f8..0d1aae6887cd 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -490,7 +490,6 @@
> > lpc: lpc@1e789000 {
> > compatible = "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon";
> > reg = <0x1e789000 0x1000>;
> > - reg-io-width = <4>;
> >
> > #address-cells = <1>;
> > #size-cells = <1>;
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-10-21 6:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 2:30 [PATCH v7 0/5] arm: aspeed: Add UART routing support Chia-Wei Wang
2021-09-27 2:30 ` [PATCH v7 1/5] ARM: dts: aspeed: Drop reg-io-width from LPC nodes Chia-Wei Wang
2021-10-08 4:35 ` Joel Stanley
2021-10-21 6:28 ` Joel Stanley [this message]
2021-10-21 6:37 ` ChiaWei Wang
2021-10-21 6:48 ` Joel Stanley
2021-10-21 6:54 ` Joel Stanley
2021-10-21 6:59 ` ChiaWei Wang
2021-09-27 2:30 ` [PATCH v7 2/5] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema Chia-Wei Wang
2021-09-29 22:02 ` Rob Herring
2021-09-30 9:48 ` Lee Jones
2021-09-27 2:30 ` [PATCH v7 3/5] dt-bindings: aspeed: Add UART routing controller Chia-Wei Wang
2021-09-29 22:11 ` Rob Herring
2021-09-30 1:55 ` ChiaWei Wang
2021-09-27 2:30 ` [PATCH v7 4/5] soc: aspeed: Add UART routing support Chia-Wei Wang
2021-10-08 4:47 ` Joel Stanley
2021-09-27 2:30 ` [PATCH v7 5/5] ARM: dts: aspeed: Add uart routing to device tree Chia-Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xfj=wJBCX5ogyf02pLJsLrooVWBJ92GJ1E+jxQW5wiFEw@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=osk@google.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).