* How to list all sensors through redfish?
@ 2020-10-10 13:06 Li, Yong B
2020-10-13 2:17 ` Lei Yu
0 siblings, 1 reply; 5+ messages in thread
From: Li, Yong B @ 2020-10-10 13:06 UTC (permalink / raw)
To: openbmc; +Cc: feistjj, 郁雷
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
Hi All,
Based on the current bmcweb implementation:
https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L61
The below URL only list these power/current/utilization sensors:
redfish/v1/Chassis/$chassis/Sensors
Just want to know why not list all running sensors? Is it required by redfish spec?
Is there any way to list all sensors through redfish interface? Like the “ipmitool sensor list” command?
Thanks,
Yong
[-- Attachment #2: Type: text/html, Size: 2737 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: How to list all sensors through redfish?
2020-10-10 13:06 How to list all sensors through redfish? Li, Yong B
@ 2020-10-13 2:17 ` Lei Yu
2020-10-13 16:30 ` Gunnar Mills
0 siblings, 1 reply; 5+ messages in thread
From: Lei Yu @ 2020-10-13 2:17 UTC (permalink / raw)
To: Li, Yong B, Ed Tanous; +Cc: openbmc, feistjj
On Sat, Oct 10, 2020 at 9:06 PM Li, Yong B <yong.b.li@intel.com> wrote:
>
> Hi All,
>
>
>
> Based on the current bmcweb implementation:
>
> https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L61
>
>
>
> The below URL only list these power/current/utilization sensors:
>
> redfish/v1/Chassis/$chassis/Sensors
>
>
>
> Just want to know why not list all running sensors? Is it required by redfish spec?
>
>
>
> Is there any way to list all sensors through redfish interface? Like the “ipmitool sensor list” command?
>
I just saw some discussion in the IRC by GunnarM quoted as:
> /sensors is sensors that aren't in Power/Thermal https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
> For 2020.4 this changes, all sensors will be under /sensors with only a link to the Power/Thermal/Fan/Powersupply schemas
But from the Redfish spec it does not say /sensors should exclude the
ones in Power/Thermal, instead /sensors is "the link to the collection
of sensors located in the equipment and sub-components".
So I am expecting that it should contain all the sensors in the system.
In OpenBMC, this could be done by returning all the objects that
implement the xyz.openbmc_project.Sensor.Value interface.
@Ed Tanous @GunnarM Could you kindly provide some comments?
Thanks!
--
BRs,
Lei YU
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: How to list all sensors through redfish?
2020-10-13 2:17 ` Lei Yu
@ 2020-10-13 16:30 ` Gunnar Mills
2020-10-14 2:08 ` Li, Yong B
2020-10-14 16:26 ` Vijay Khemka
0 siblings, 2 replies; 5+ messages in thread
From: Gunnar Mills @ 2020-10-13 16:30 UTC (permalink / raw)
To: Lei Yu, Li, Yong B, Ed Tanous; +Cc: openbmc, feistjj
On 10/12/2020 8:17 PM, Lei Yu wrote:
> On Sat, Oct 10, 2020 at 9:06 PM Li, Yong B <yong.b.li@intel.com> wrote:
>>
>> Hi All,
>>
>> Based on the current bmcweb implementation:
>>
>> https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L61
>>
>> The below URL only list these power/current/utilization sensors:
>>
>> redfish/v1/Chassis/$chassis/Sensors
>>
>> Just want to know why not list all running sensors? Is it required by redfish spec?
We asked this question in the Redfish forum thread below and Redfish
said "for sensors that are not covered elsewhere in the model - meaning
don't duplicate Power and Thermal".
>>
>>
>> Is there any way to list all sensors through redfish interface? Like the “ipmitool sensor list” command?
>>
Not in one command. You will have to call the Thermal, Power, and
Sensors schemas like the webui does:
https://github.com/openbmc/webui-vue/blob/e9a59c75670461a80156554a4dfa04bab5eaf42c/src/store/modules/Health/SensorsStore.js#L22
In 2020.4, this changes and all sensors will be in one location. :)
>
> I just saw some discussion in the IRC by GunnarM quoted as:
>
>> /sensors is sensors that aren't in Power/Thermal https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
>> For 2020.4 this changes, all sensors will be under /sensors with only a link to the Power/Thermal/Fan/Powersupply schemas
>
> But from the Redfish spec it does not say /sensors should exclude the
> ones in Power/Thermal, instead /sensors is "the link to the collection
> of sensors located in the equipment and sub-components"
Yeah the spec should have clarified. Probably isn't worth clarifying in
the spec now because this changes in 2020.4 and that would be the
release any updated spec is available.
> So I am expecting that it should contain all the sensors in the system.
> In OpenBMC, this could be done by returning all the objects that
> implement the xyz.openbmc_project.Sensor.Value interface.
>
We implemented this way because of that thread. Feel free to reply on
that thread.
Thanks,
Gunnar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: How to list all sensors through redfish?
2020-10-13 16:30 ` Gunnar Mills
@ 2020-10-14 2:08 ` Li, Yong B
2020-10-14 16:26 ` Vijay Khemka
1 sibling, 0 replies; 5+ messages in thread
From: Li, Yong B @ 2020-10-14 2:08 UTC (permalink / raw)
To: Gunnar Mills, Lei Yu, Li, Yong B, Ed Tanous; +Cc: openbmc, feistjj
On 10/14/2020 12:30 AM, Gunnar Mills wrote:
> On 10/12/2020 8:17 PM, Lei Yu wrote:
>> On Sat, Oct 10, 2020 at 9:06 PM Li, Yong B <yong.b.li@intel.com> wrote:
>>>
>>> Hi All,
>>>
>>> Based on the current bmcweb implementation:
>>>
>>> https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L61
>>>
>>>
>>> The below URL only list these power/current/utilization sensors:
>>>
>>> redfish/v1/Chassis/$chassis/Sensors
>>>
>>> Just want to know why not list all running sensors? Is it required
>>> by redfish spec?
>
> We asked this question in the Redfish forum thread below and Redfish
> said "for sensors that are not covered elsewhere in the model -
> meaning don't duplicate Power and Thermal".
Thanks a lot for your clarification!
>
>>>
>>>
>>> Is there any way to list all sensors through redfish interface?
>>> Like the “ipmitool sensor list” command?
>>>
>
> Not in one command. You will have to call the Thermal, Power, and
> Sensors schemas like the webui does:
> https://github.com/openbmc/webui-vue/blob/e9a59c75670461a80156554a4dfa04bab5eaf42c/src/store/modules/Health/SensorsStore.js#L22
>
> In 2020.4, this changes and all sensors will be in one location. :)
YES! the #/health/sensors webpage will display all these sensors, but I
found a minor issue and submitted a code review
>
>>
>> I just saw some discussion in the IRC by GunnarM quoted as:
>>
>>> /sensors is sensors that aren't in Power/Thermal
>>> https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
>>> For 2020.4 this changes, all sensors will be under /sensors with
>>> only a link to the Power/Thermal/Fan/Powersupply schemas
>>
>> But from the Redfish spec it does not say /sensors should exclude the
>> ones in Power/Thermal, instead /sensors is "the link to the collection
>> of sensors located in the equipment and sub-components"
> Yeah the spec should have clarified. Probably isn't worth clarifying
> in the spec now because this changes in 2020.4 and that would be the
> release any updated spec is available.
>
>> So I am expecting that it should contain all the sensors in the system.
>> In OpenBMC, this could be done by returning all the objects that
>> implement the xyz.openbmc_project.Sensor.Value interface.
>>
>
> We implemented this way because of that thread. Feel free to reply on
> that thread.
>
> Thanks,
> Gunnar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: How to list all sensors through redfish?
2020-10-13 16:30 ` Gunnar Mills
2020-10-14 2:08 ` Li, Yong B
@ 2020-10-14 16:26 ` Vijay Khemka
1 sibling, 0 replies; 5+ messages in thread
From: Vijay Khemka @ 2020-10-14 16:26 UTC (permalink / raw)
To: Gunnar Mills, Lei Yu, Li, Yong B, Ed Tanous; +Cc: openbmc, feistjj
On 10/13/20, 9:32 AM, "openbmc on behalf of Gunnar Mills" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of gmills@linux.vnet.ibm.com> wrote:
On 10/12/2020 8:17 PM, Lei Yu wrote:
> On Sat, Oct 10, 2020 at 9:06 PM Li, Yong B <yong.b.li@intel.com> wrote:
>>
>> Hi All,
>>
>> Based on the current bmcweb implementation:
>>
>> https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L61
>>
>> The below URL only list these power/current/utilization sensors:
>>
>> redfish/v1/Chassis/$chassis/Sensors
>>
>> Just want to know why not list all running sensors? Is it required by redfish spec?
We asked this question in the Redfish forum thread below and Redfish
said "for sensors that are not covered elsewhere in the model - meaning
don't duplicate Power and Thermal".
One clarification needed, "power" include power and voltage sensors and
"sensor" also include power along with current and utilization sensors. Isn't
this a duplicate of power here?
>>
>>
>> Is there any way to list all sensors through redfish interface? Like the “ipmitool sensor list” command?
>>
Not in one command. You will have to call the Thermal, Power, and
Sensors schemas like the webui does:
https://github.com/openbmc/webui-vue/blob/e9a59c75670461a80156554a4dfa04bab5eaf42c/src/store/modules/Health/SensorsStore.js#L22
In 2020.4, this changes and all sensors will be in one location. :)
>
> I just saw some discussion in the IRC by GunnarM quoted as:
>
>> /sensors is sensors that aren't in Power/Thermal https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
>> For 2020.4 this changes, all sensors will be under /sensors with only a link to the Power/Thermal/Fan/Powersupply schemas
>
> But from the Redfish spec it does not say /sensors should exclude the
> ones in Power/Thermal, instead /sensors is "the link to the collection
> of sensors located in the equipment and sub-components"
Yeah the spec should have clarified. Probably isn't worth clarifying in
the spec now because this changes in 2020.4 and that would be the
release any updated spec is available.
> So I am expecting that it should contain all the sensors in the system.
> In OpenBMC, this could be done by returning all the objects that
> implement the xyz.openbmc_project.Sensor.Value interface.
>
We implemented this way because of that thread. Feel free to reply on
that thread.
Thanks,
Gunnar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-14 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-10 13:06 How to list all sensors through redfish? Li, Yong B
2020-10-13 2:17 ` Lei Yu
2020-10-13 16:30 ` Gunnar Mills
2020-10-14 2:08 ` Li, Yong B
2020-10-14 16:26 ` Vijay Khemka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).