Redfish-Service-Validator fail to validate Oem

Redfish-Service-Validator fail to validate Oem

[Zhang, ShuoX]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

Hi all,
      Why does the Redfish-Service-Validator tool fail to validate Oem, the namespace OemManager has the node OpenBmc in OemManager_v1.xml.

        <Schema xmlns=http://docs.oasis-open.org/odata/ns/edm Namespace="OemManager">
            <ComplexType Name="Oem" BaseType="Resource.OemObject">
                <Annotation Term="OData.AdditionalProperties" Bool="true" />
                <Annotation Term="OData.Description" String="OemManager Oem properties." />
                <Annotation Term="OData.AutoExpand"/>
                <Property Name="OpenBmc" Type="OemManager.OpenBmc"/>
            </ComplexType>


Oem.OpenBmc
[JSON Object]
none
Yes
FAIL
ERROR - Type OpenBmc not found under namespace OemManager in schema of parent
ERROR - Links.ManagerInChassis: Linked resource reports version #Chassis.v1_16_0.Chassis not in Schema localFile:./SchemaFiles/metadata/Chassis_v1.xml
ERROR - Links.ManagerForChassis[0]: Linked resource reports version #Chassis.v1_16_0.Chassis not in Schema localFile:./SchemaFiles/metadata/Chassis_v1.xml
ERROR - Oem.OpenBmc: This type is invalid none

"Oem": {
        "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
        "@odata.type": "#OemManager.Oem",
        "OpenBmc": {
            "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
            "@odata.type": "#OemManager.OpenBmc",
            "Certificates": {
                "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
            },
            "Fan": {
                "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc/Fan",
                "@odata.type": "#OemManager.Fan",


[-- Attachment #2: Type: text/html, Size: 14397 bytes --]

Re: Redfish-Service-Validator fail to validate Oem

[Ed Tanous]

On Fri, Feb 25, 2022 at 2:03 AM Zhang, ShuoX <shuox.zhang@intel.com> wrote:
>
> Hi all,
>
>       Why does the Redfish-Service-Validator tool fail to validate Oem, the namespace OemManager has the node OpenBmc in OemManager_v1.xml.
>
>

The OEM schemas we have were not built to the odata standard, and
therefore do not pass the service validator in most cases.  There were
enough bugs that I even made a topic on github for that class:
https://github.com/openbmc/bmcweb/issues?q=is%3Aissue+is%3Aopen+label%3A%22OEM+schema%22

If you're interested in trying to get patches to fix some of them,
please take a look at the above list and feel free to start wherever
you like.


>
>         <Schema xmlns=http://docs.oasis-open.org/odata/ns/edm Namespace="OemManager">
>
>             <ComplexType Name="Oem" BaseType="Resource.OemObject">
>
>                 <Annotation Term="OData.AdditionalProperties" Bool="true" />
>
>                 <Annotation Term="OData.Description" String="OemManager Oem properties." />
>
>                 <Annotation Term="OData.AutoExpand"/>
>
>                 <Property Name="OpenBmc" Type="OemManager.OpenBmc"/>
>
>             </ComplexType>
>
>
>
>
>
> Oem.OpenBmc
>
> [JSON Object]
>
> none
>
> Yes
>
> FAIL
>
> ERROR - Type OpenBmc not found under namespace OemManager in schema of parent
> ERROR - Links.ManagerInChassis: Linked resource reports version #Chassis.v1_16_0.Chassis not in Schema localFile:./SchemaFiles/metadata/Chassis_v1.xml
> ERROR - Links.ManagerForChassis[0]: Linked resource reports version #Chassis.v1_16_0.Chassis not in Schema localFile:./SchemaFiles/metadata/Chassis_v1.xml
> ERROR - Oem.OpenBmc: This type is invalid none
>
>
>
> "Oem": {
>
>         "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
>
>         "@odata.type": "#OemManager.Oem",
>
>         "OpenBmc": {
>
>             "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
>
>             "@odata.type": "#OemManager.OpenBmc",
>
>             "Certificates": {
>
>                 "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
>
>             },
>
>             "Fan": {
>
>                 "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc/Fan",
>
>                 "@odata.type": "#OemManager.Fan",
>
>