Request to add "meta-google/recipes-google/console/glome_git.bb" to auto bump

Request to add "meta-google/recipes-google/console/glome_git.bb" to auto bump

[Brandon Kim]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Hello,

Following the instructions in
https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#dont-use-srcrevautorev-in-a-recipe
we'd like to request "glome_git.bb
<https://github.com/openbmc/openbmc/blob/master/meta-google/recipes-google/console/glome_git.bb>"
to be added to the autobump list if possible (or let us know if the
instruction is outdated - or if there is concern for adding a meta-google
recipe to the autobump list). It points to a public github repo under
google: https://github.com/google/glome

Thank you,
Brandon

[-- Attachment #2: Type: text/html, Size: 818 bytes --]

Re: Request to add "meta-google/recipes-google/console/glome_git.bb" to auto bump

[Brad Bishop]

Hi Brandon

On Tue, 2022-07-12 at 11:42 -0700, Brandon Kim wrote:
> Hello,
> 
> Following the instructions in
> https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#dont-use-srcrevautorev-in-a-recipe
> we'd like to request "glome_git.bb
> <
> https://github.com/openbmc/openbmc/blob/master/meta-google/recipes-goog
> le/console/glome_git.bb>"
> to be added to the autobump list if possible (or let us know if the
> instruction is outdated - or if there is concern for adding a meta-
> google
> recipe to the autobump list). It points to a public github repo under
> google: https://github.com/google/glome

You'd have to add support to the tool for looking in additional github
organizations.  It is in the openbmc-tools repository in the openbmc-
autobump folder - you can submit changes for review on Gerrit.

Thanks,
Brad

Re: Request to add "meta-google/recipes-google/console/glome_git.bb" to auto bump

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]

On Tue, Jul 12, 2022 at 11:42:58AM -0700, Brandon Kim wrote:
> Hello,
> 
> Following the instructions in
> https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#dont-use-srcrevautorev-in-a-recipe
> we'd like to request "glome_git.bb
> <https://github.com/openbmc/openbmc/blob/master/meta-google/recipes-google/console/glome_git.bb>"
> to be added to the autobump list if possible (or let us know if the
> instruction is outdated - or if there is concern for adding a meta-google
> recipe to the autobump list). It points to a public github repo under
> google: https://github.com/google/glome

This instruction is correct still.  You should never use AUTOREV in a
recipe.  It makes it so that builds are not reproducible and at a
minimum breaks the release process.  When we make a release we'd have
to make an additional commit to pin all the AUTOREVs, which we don't
currently do.  If you look through the entire tree, including all the
Yocto meta-layers, you shouldn't see any examples of using this in a
formal meta-layer(*).

I don't think we should add glome to the autobump list.  This list
currently only contains recipes under the openbmc org.  Honestly, glome
shouldn't even exist in meta-google[1].  There has been some discussion
about what does "well-maintained open source projects" mean, but lately
we've been interpreting this guideline to mean "nothing outside the
openbmc org".  The expectation is that if you really are pointing at a
"well-maintained open source project" you should have no trouble getting
it put into meta-openembedded instead.  This saves us the trouble of
having any debate about what is / is not "well-maintained".

My recommendation would be to move glome to a Yocto/OE meta-layer and
deal with them for updates because that is what we've been suggesting
for anything not in the openbmc org lately.

(*) I do see one in one of _our_ meta-layers and this needs to get
    fixed... one of the problems of opening up machine metas to almost
    any company who asks with little review oversight.

1. https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#meta-layer-recipes-should-only-point-to-well-maintained-open-source-projects

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Request to add "meta-google/recipes-google/console/glome_git.bb" to auto bump

[Brandon Kim]

Thanks for the insight, agreed on not using AUTOREV (which we don't
do, and thus why we had to manually bump a year's worth of change
here: https://gerrit.openbmc.org/c/openbmc/openbmc/+/55214) and I
guess it gets fuzzy on what the definition of a  "well-maintained open
source projects" is.

I'll see if I can figure out what the process of adding to Yocto / OE
meta-layer is.

Thanks,
Brandon

On Wed, Jul 13, 2022 at 4:56 AM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> On Tue, Jul 12, 2022 at 11:42:58AM -0700, Brandon Kim wrote:
> > Hello,
> >
> > Following the instructions in
> > https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#dont-use-srcrevautorev-in-a-recipe
> > we'd like to request "glome_git.bb
> > <https://github.com/openbmc/openbmc/blob/master/meta-google/recipes-google/console/glome_git.bb>"
> > to be added to the autobump list if possible (or let us know if the
> > instruction is outdated - or if there is concern for adding a meta-google
> > recipe to the autobump list). It points to a public github repo under
> > google: https://github.com/google/glome
>
> This instruction is correct still.  You should never use AUTOREV in a
> recipe.  It makes it so that builds are not reproducible and at a
> minimum breaks the release process.  When we make a release we'd have
> to make an additional commit to pin all the AUTOREVs, which we don't
> currently do.  If you look through the entire tree, including all the
> Yocto meta-layers, you shouldn't see any examples of using this in a
> formal meta-layer(*).
>
> I don't think we should add glome to the autobump list.  This list
> currently only contains recipes under the openbmc org.  Honestly, glome
> shouldn't even exist in meta-google[1].  There has been some discussion
> about what does "well-maintained open source projects" mean, but lately
> we've been interpreting this guideline to mean "nothing outside the
> openbmc org".  The expectation is that if you really are pointing at a
> "well-maintained open source project" you should have no trouble getting
> it put into meta-openembedded instead.  This saves us the trouble of
> having any debate about what is / is not "well-maintained".
>
> My recommendation would be to move glome to a Yocto/OE meta-layer and
> deal with them for updates because that is what we've been suggesting
> for anything not in the openbmc org lately.
>
> (*) I do see one in one of _our_ meta-layers and this needs to get
>     fixed... one of the problems of opening up machine metas to almost
>     any company who asks with little review oversight.
>
> 1. https://github.com/openbmc/docs/blob/master/meta-layer-guidelines.md#meta-layer-recipes-should-only-point-to-well-maintained-open-source-projects
>
> --
> Patrick Williams