Help patching rest_dbus.py

Help patching rest_dbus.py

[guhan balasubramanian]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Hi,

We are trying to make some custom changes to the phosphor web application.
Since the web application is present in meta-phosphor, we were trying to
patch the web application from our own meta layer.

From the tmp/work/ directory, I was able to create a git patch for the
rest_dbus.py file in phosphor-gevent and phosphor-rest.

But since the source is not included directly, I get a quilt error saying
that there is no file to patch.

The web (bottle) application I see, is included through the following
variable:
SYSTEMD_ENVIRONMENT_FILE_${PN} += "obmc/wsgi_app"

Can someone please help with what I am missing or the best way to go about
this?

-----
bash-4.2$ tree phosphor-rest/
phosphor-rest/
├── phosphor-rest
│   └── 0001-rest-dbus-test.patch
└── phosphor-rest.bbappend

1 directory, 2 files
bash-4.2$ cat phosphor-rest/phosphor-rest.bbappend
FILESEXTRAPATHS_prepend := "${THISDIR}/phosphor-rest:"
SRC_URI += " \
     file://0001-rest-dbus-test.patch \
"
bash-4.2$
-------


Thanks,
Guhan

[-- Attachment #2: Type: text/html, Size: 1783 bytes --]

Re: Help patching rest_dbus.py

[Brad Bishop]

> On Jul 17, 2018, at 2:10 PM, guhan balasubramanian <guhan.sac@gmail.com> wrote:
> 
> Hi,
> 
> We are trying to make some custom changes to the phosphor web application.

Can you describe what the custom changes are?  Maybe upstreaming your changes
is possible and you don’t need a bbappend at all.

> Since the web application is present in meta-phosphor, we were trying to patch the web application from our own meta layer. 
> 
> From the tmp/work/ directory, I was able to create a git patch for the rest_dbus.py file in phosphor-gevent and phosphor-rest. 
> 
> But since the source is not included directly, I get a quilt error saying that there is no file to patch. 
> 
> The web (bottle) application I see, is included through the following variable: 
> SYSTEMD_ENVIRONMENT_FILE_${PN} += "obmc/wsgi_app"
> 
> Can someone please help with what I am missing or the best way to go about this? 
> 
> -----
> bash-4.2$ tree phosphor-rest/
> phosphor-rest/
> ├── phosphor-rest
> │   └── 0001-rest-dbus-test.patch
> └── phosphor-rest.bbappend
> 
> 1 directory, 2 files
> bash-4.2$ cat phosphor-rest/phosphor-rest.bbappend 
> FILESEXTRAPATHS_prepend := "${THISDIR}/phosphor-rest:"
> SRC_URI += " \
>      file://0001-rest-dbus-test.patch \
> "
> bash-4.2$ 
> -------
> 
> 
> Thanks,
> Guhan

Re: Help patching rest_dbus.py

[guhan balasubramanian]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

Hi Brad,

Thanks for getting back.

We were trying to prototype the use of the bottle web application to
POST/PUT a text/diff file to BMC, apart from the image. This is similar to
the octet-stream http request used for the image upload.

Regarding upstreaming, not sure what would be the interest for this to the
others.

Thanks,
Guhan

On Wed, Jul 18, 2018 at 6:22 AM Brad Bishop <bradleyb@fuzziesquirrel.com>
wrote:

>
> > On Jul 17, 2018, at 2:10 PM, guhan balasubramanian <guhan.sac@gmail.com>
> wrote:
> >
> > Hi,
> >
> > We are trying to make some custom changes to the phosphor web
> application.
>
> Can you describe what the custom changes are?  Maybe upstreaming your
> changes
> is possible and you don’t need a bbappend at all.
>
> > Since the web application is present in meta-phosphor, we were trying to
> patch the web application from our own meta layer.
> >
> > From the tmp/work/ directory, I was able to create a git patch for the
> rest_dbus.py file in phosphor-gevent and phosphor-rest.
> >
> > But since the source is not included directly, I get a quilt error
> saying that there is no file to patch.
> >
> > The web (bottle) application I see, is included through the following
> variable:
> > SYSTEMD_ENVIRONMENT_FILE_${PN} += "obmc/wsgi_app"
> >
> > Can someone please help with what I am missing or the best way to go
> about this?
> >
> > -----
> > bash-4.2$ tree phosphor-rest/
> > phosphor-rest/
> > ├── phosphor-rest
> > │   └── 0001-rest-dbus-test.patch
> > └── phosphor-rest.bbappend
> >
> > 1 directory, 2 files
> > bash-4.2$ cat phosphor-rest/phosphor-rest.bbappend
> > FILESEXTRAPATHS_prepend := "${THISDIR}/phosphor-rest:"
> > SRC_URI += " \
> >      file://0001-rest-dbus-test.patch \
> > "
> > bash-4.2$
> > -------
> >
> >
> > Thanks,
> > Guhan
>

[-- Attachment #2: Type: text/html, Size: 2511 bytes --]