From: Tomer Maimon <tmaimon77@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>, benjaminfair@google.com
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
arnd@arnd.de, Avi Fishman <avifishman70@gmail.com>,
Nancy Yuen <yuenn@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Patrick Venture <venture@google.com>,
Joel Stanley <joel@jms.id.au>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux HWMON List <linux-hwmon@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v1 2/2] misc: npcm7xx: add NPCM7xx LPC BPC driver
Date: Mon, 16 Jul 2018 15:31:50 +0300 [thread overview]
Message-ID: <CAP6Zq1hUr_3X-B1wPZpk5o88hibusJ2w04VUeR8Tw+OqftQuZg@mail.gmail.com> (raw)
In-Reply-To: <20180716113357.GA30937@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
[+Benjamin Fair]
Hi Greg,
This hardware is working in the same manner that Aspeed lpc snooping driver
(/drivers/misc/aspeed-lpc-snoop.c)
On 16 July 2018 at 14:33, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Jul 04, 2018 at 12:14:27PM +0300, Tomer Maimon wrote:
> > Add Nuvoton BMC NPCM7xx BIOS post code (BPC) driver.
> >
> > The NPCM7xx BPC monitoring two I/O address written by
> > the host on the Low Pin Count (LPC) bus, the capure
> > data stored in 128-word FIFO.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
>
> It would be great to get someone else who knows that this hardware is
> supposed to be doing to ack or sign-off on this patch, as I don't know
> if this really is providing the correct api for it or not.
>
Joel could you sign-off this patch please.
Right now it's just reading data from the hardware, what good is that?
> Who uses this? What userspace tools connect up to it?
>
BMC is logging a configurable I/O port (for example 0x80 port which is BIOS
post code) and remote management can get.
about tools, the OpenBMC is using it.
https://github.com/openbmc/phosphor-host-postd
> thanks,
>
> greg k-h
>
thanks,
Tomer
[-- Attachment #2: Type: text/html, Size: 2202 bytes --]
prev parent reply other threads:[~2018-07-16 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 9:14 [PATCH v1 0/2] misc: Add NPCM7xx LPC BPC driver support Tomer Maimon
2018-07-04 9:14 ` [PATCH v1 1/2] dt-binding: bmc: Add NPCM7xx LPC BPC documentation Tomer Maimon
2018-07-11 20:21 ` Rob Herring
2018-07-16 2:50 ` Andrew Jeffery
2018-07-04 9:14 ` [PATCH v1 2/2] misc: npcm7xx: add NPCM7xx LPC BPC driver Tomer Maimon
2018-07-16 11:33 ` Greg KH
2018-07-16 12:31 ` Tomer Maimon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP6Zq1hUr_3X-B1wPZpk5o88hibusJ2w04VUeR8Tw+OqftQuZg@mail.gmail.com \
--to=tmaimon77@gmail.com \
--cc=arnd@arnd.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).