From: Tomer Maimon <tmaimon77@gmail.com>
To: Anton Kachalov <gmouse@google.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Benjamin Fair <benjaminfair@google.com>,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tali Perry <tali.perry1@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2] ARM: dts: nuvoton: Fix flash layout
Date: Thu, 25 Mar 2021 12:35:50 +0200 [thread overview]
Message-ID: <CAP6Zq1iPKK-GB5TvJzJEHg1CZ_PQz1kDrjA96P6iUSxu8AwWPA@mail.gmail.com> (raw)
In-Reply-To: <CADVsX8-Vy=t9Y1VYqY9kLY-4EjsaUN2fNABw6JzM8noXB+SBvA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3969 bytes --]
Hi Anton,
We think that what Benjamin suggested is the best way. Adding unique dtsi
for the openbmc layout.
Usually users of Nuvoton EVB are not running openbmc and this is why we
have a different layout for their use.
Attentively you can upstream a new dts file for supporting the openbmc
layout in NPCM7xx EVB, for example google-npcm750-evb.
Thanks,
Tomer
On Wed, 24 Mar 2021 at 09:07, Anton Kachalov <gmouse@google.com> wrote:
> Gently ping
>
> On Mon, 8 Mar 2021 at 18:11, <gmouse@google.com> wrote:
>
>> From: "Anton D. Kachalov" <gmouse@google.com>
>>
>> This change follows OpenBMC partitions' naming layout.
>>
>> Signed-off-by: Anton D. Kachalov <gmouse@google.com>
>> ---
>> arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 38 +++++++----------------
>> 1 file changed, 11 insertions(+), 27 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> index 9f13d08f5804..55c5a89592d7 100644
>> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> @@ -78,8 +78,8 @@ partitions@80000000 {
>> compatible = "fixed-partitions";
>> #address-cells = <1>;
>> #size-cells = <1>;
>> - bbuboot1@0 {
>> - label = "bb-uboot-1";
>> + u-boot@0 {
>> + label = "u-boot";
>> reg = <0x0000000 0x80000>;
>> read-only;
>> };
>> @@ -88,38 +88,22 @@ bbuboot2@80000 {
>> reg = <0x0080000 0x80000>;
>> read-only;
>> };
>> - envparam@100000 {
>> - label = "env-param";
>> + u-boot-env@100000 {
>> + label = "u-boot-env";
>> reg = <0x0100000 0x40000>;
>> read-only;
>> };
>> - spare@140000 {
>> - label = "spare";
>> - reg = <0x0140000 0xC0000>;
>> - };
>> kernel@200000 {
>> label = "kernel";
>> - reg = <0x0200000 0x400000>;
>> - };
>> - rootfs@600000 {
>> - label = "rootfs";
>> - reg = <0x0600000 0x700000>;
>> - };
>> - spare1@D00000 {
>> - label = "spare1";
>> - reg = <0x0D00000 0x200000>;
>> - };
>> - spare2@0F00000 {
>> - label = "spare2";
>> - reg = <0x0F00000 0x200000>;
>> + reg = <0x0200000 0x580000>;
>> };
>> - spare3@1100000 {
>> - label = "spare3";
>> - reg = <0x1100000 0x200000>;
>> + rofs@780000 {
>> + label = "rofs";
>> + reg = <0x0780000 0x1680000>;
>> };
>> - spare4@1300000 {
>> - label = "spare4";
>> - reg = <0x1300000 0x0>;
>> + rwfs@1e00000 {
>> + label = "rwfs";
>> + reg = <0x1e00000 0x200000>;
>> };
>> };
>> };
>> --
>> 2.30.1.766.gb4fecdf3b7-goog
>>
>>
[-- Attachment #2: Type: text/html, Size: 7686 bytes --]
prev parent reply other threads:[~2021-03-25 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 17:10 [PATCH v2] ARM: dts: nuvoton: Fix flash layout gmouse
2021-03-24 7:07 ` Anton Kachalov
2021-03-25 10:35 ` Tomer Maimon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP6Zq1iPKK-GB5TvJzJEHg1CZ_PQz1kDrjA96P6iUSxu8AwWPA@mail.gmail.com \
--to=tmaimon77@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gmouse@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).