openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: nuvoton: Fix flash layout
@ 2021-03-08 17:10 gmouse
  2021-03-24  7:07 ` Anton Kachalov
  0 siblings, 1 reply; 3+ messages in thread
From: gmouse @ 2021-03-08 17:10 UTC (permalink / raw)
  To: Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture,
	Nancy Yuen, Benjamin Fair, Rob Herring
  Cc: devicetree, openbmc, Anton D. Kachalov, linux-kernel

From: "Anton D. Kachalov" <gmouse@google.com>

This change follows OpenBMC partitions' naming layout.

Signed-off-by: Anton D. Kachalov <gmouse@google.com>
---
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 38 +++++++----------------
 1 file changed, 11 insertions(+), 27 deletions(-)

diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
index 9f13d08f5804..55c5a89592d7 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
@@ -78,8 +78,8 @@ partitions@80000000 {
 			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			bbuboot1@0 {
-				label = "bb-uboot-1";
+			u-boot@0 {
+				label = "u-boot";
 				reg = <0x0000000 0x80000>;
 				read-only;
 				};
@@ -88,38 +88,22 @@ bbuboot2@80000 {
 				reg = <0x0080000 0x80000>;
 				read-only;
 				};
-			envparam@100000 {
-				label = "env-param";
+			u-boot-env@100000 {
+				label = "u-boot-env";
 				reg = <0x0100000 0x40000>;
 				read-only;
 				};
-			spare@140000 {
-				label = "spare";
-				reg = <0x0140000 0xC0000>;
-				};
 			kernel@200000 {
 				label = "kernel";
-				reg = <0x0200000 0x400000>;
-				};
-			rootfs@600000 {
-				label = "rootfs";
-				reg = <0x0600000 0x700000>;
-				};
-			spare1@D00000 {
-				label = "spare1";
-				reg = <0x0D00000 0x200000>;
-				};
-			spare2@0F00000 {
-				label = "spare2";
-				reg = <0x0F00000 0x200000>;
+				reg = <0x0200000 0x580000>;
 				};
-			spare3@1100000 {
-				label = "spare3";
-				reg = <0x1100000 0x200000>;
+			rofs@780000 {
+				label = "rofs";
+				reg = <0x0780000 0x1680000>;
 				};
-			spare4@1300000 {
-				label = "spare4";
-				reg = <0x1300000 0x0>;
+			rwfs@1e00000 {
+				label = "rwfs";
+				reg = <0x1e00000 0x200000>;
 			};
 		};
 	};
-- 
2.30.1.766.gb4fecdf3b7-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: nuvoton: Fix flash layout
  2021-03-08 17:10 [PATCH v2] ARM: dts: nuvoton: Fix flash layout gmouse
@ 2021-03-24  7:07 ` Anton Kachalov
  2021-03-25 10:35   ` Tomer Maimon
  0 siblings, 1 reply; 3+ messages in thread
From: Anton Kachalov @ 2021-03-24  7:07 UTC (permalink / raw)
  To: Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture,
	Nancy Yuen, Benjamin Fair, Rob Herring
  Cc: devicetree, OpenBMC Maillist, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 3440 bytes --]

Gently ping

On Mon, 8 Mar 2021 at 18:11, <gmouse@google.com> wrote:

> From: "Anton D. Kachalov" <gmouse@google.com>
>
> This change follows OpenBMC partitions' naming layout.
>
> Signed-off-by: Anton D. Kachalov <gmouse@google.com>
> ---
>  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 38 +++++++----------------
>  1 file changed, 11 insertions(+), 27 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> index 9f13d08f5804..55c5a89592d7 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> @@ -78,8 +78,8 @@ partitions@80000000 {
>                         compatible = "fixed-partitions";
>                         #address-cells = <1>;
>                         #size-cells = <1>;
> -                       bbuboot1@0 {
> -                               label = "bb-uboot-1";
> +                       u-boot@0 {
> +                               label = "u-boot";
>                                 reg = <0x0000000 0x80000>;
>                                 read-only;
>                                 };
> @@ -88,38 +88,22 @@ bbuboot2@80000 {
>                                 reg = <0x0080000 0x80000>;
>                                 read-only;
>                                 };
> -                       envparam@100000 {
> -                               label = "env-param";
> +                       u-boot-env@100000 {
> +                               label = "u-boot-env";
>                                 reg = <0x0100000 0x40000>;
>                                 read-only;
>                                 };
> -                       spare@140000 {
> -                               label = "spare";
> -                               reg = <0x0140000 0xC0000>;
> -                               };
>                         kernel@200000 {
>                                 label = "kernel";
> -                               reg = <0x0200000 0x400000>;
> -                               };
> -                       rootfs@600000 {
> -                               label = "rootfs";
> -                               reg = <0x0600000 0x700000>;
> -                               };
> -                       spare1@D00000 {
> -                               label = "spare1";
> -                               reg = <0x0D00000 0x200000>;
> -                               };
> -                       spare2@0F00000 {
> -                               label = "spare2";
> -                               reg = <0x0F00000 0x200000>;
> +                               reg = <0x0200000 0x580000>;
>                                 };
> -                       spare3@1100000 {
> -                               label = "spare3";
> -                               reg = <0x1100000 0x200000>;
> +                       rofs@780000 {
> +                               label = "rofs";
> +                               reg = <0x0780000 0x1680000>;
>                                 };
> -                       spare4@1300000 {
> -                               label = "spare4";
> -                               reg = <0x1300000 0x0>;
> +                       rwfs@1e00000 {
> +                               label = "rwfs";
> +                               reg = <0x1e00000 0x200000>;
>                         };
>                 };
>         };
> --
> 2.30.1.766.gb4fecdf3b7-goog
>
>

[-- Attachment #2: Type: text/html, Size: 5135 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: nuvoton: Fix flash layout
  2021-03-24  7:07 ` Anton Kachalov
@ 2021-03-25 10:35   ` Tomer Maimon
  0 siblings, 0 replies; 3+ messages in thread
From: Tomer Maimon @ 2021-03-25 10:35 UTC (permalink / raw)
  To: Anton Kachalov
  Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
	OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
	Rob Herring

[-- Attachment #1: Type: text/plain, Size: 3969 bytes --]

Hi Anton,



We think that what Benjamin suggested is the best way. Adding unique dtsi
for the openbmc layout.

Usually users of Nuvoton EVB are not running openbmc and this is why we
have a different layout for their use.



Attentively you can upstream a new dts file for supporting the openbmc
layout in NPCM7xx EVB, for example google-npcm750-evb.



Thanks,



Tomer

On Wed, 24 Mar 2021 at 09:07, Anton Kachalov <gmouse@google.com> wrote:

> Gently ping
>
> On Mon, 8 Mar 2021 at 18:11, <gmouse@google.com> wrote:
>
>> From: "Anton D. Kachalov" <gmouse@google.com>
>>
>> This change follows OpenBMC partitions' naming layout.
>>
>> Signed-off-by: Anton D. Kachalov <gmouse@google.com>
>> ---
>>  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 38 +++++++----------------
>>  1 file changed, 11 insertions(+), 27 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> index 9f13d08f5804..55c5a89592d7 100644
>> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> @@ -78,8 +78,8 @@ partitions@80000000 {
>>                         compatible = "fixed-partitions";
>>                         #address-cells = <1>;
>>                         #size-cells = <1>;
>> -                       bbuboot1@0 {
>> -                               label = "bb-uboot-1";
>> +                       u-boot@0 {
>> +                               label = "u-boot";
>>                                 reg = <0x0000000 0x80000>;
>>                                 read-only;
>>                                 };
>> @@ -88,38 +88,22 @@ bbuboot2@80000 {
>>                                 reg = <0x0080000 0x80000>;
>>                                 read-only;
>>                                 };
>> -                       envparam@100000 {
>> -                               label = "env-param";
>> +                       u-boot-env@100000 {
>> +                               label = "u-boot-env";
>>                                 reg = <0x0100000 0x40000>;
>>                                 read-only;
>>                                 };
>> -                       spare@140000 {
>> -                               label = "spare";
>> -                               reg = <0x0140000 0xC0000>;
>> -                               };
>>                         kernel@200000 {
>>                                 label = "kernel";
>> -                               reg = <0x0200000 0x400000>;
>> -                               };
>> -                       rootfs@600000 {
>> -                               label = "rootfs";
>> -                               reg = <0x0600000 0x700000>;
>> -                               };
>> -                       spare1@D00000 {
>> -                               label = "spare1";
>> -                               reg = <0x0D00000 0x200000>;
>> -                               };
>> -                       spare2@0F00000 {
>> -                               label = "spare2";
>> -                               reg = <0x0F00000 0x200000>;
>> +                               reg = <0x0200000 0x580000>;
>>                                 };
>> -                       spare3@1100000 {
>> -                               label = "spare3";
>> -                               reg = <0x1100000 0x200000>;
>> +                       rofs@780000 {
>> +                               label = "rofs";
>> +                               reg = <0x0780000 0x1680000>;
>>                                 };
>> -                       spare4@1300000 {
>> -                               label = "spare4";
>> -                               reg = <0x1300000 0x0>;
>> +                       rwfs@1e00000 {
>> +                               label = "rwfs";
>> +                               reg = <0x1e00000 0x200000>;
>>                         };
>>                 };
>>         };
>> --
>> 2.30.1.766.gb4fecdf3b7-goog
>>
>>

[-- Attachment #2: Type: text/html, Size: 7686 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-25 10:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 17:10 [PATCH v2] ARM: dts: nuvoton: Fix flash layout gmouse
2021-03-24  7:07 ` Anton Kachalov
2021-03-25 10:35   ` Tomer Maimon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).