Feature Enhancement - Virtual Media over HTML5

Feature Enhancement - Virtual Media over HTML5

[Dhines Kumar Eswaran]

[-- Attachment #1.1: Type: text/plain, Size: 2358 bytes --]

Hi All,

We are planning to support multiple Virtual media redirection support simultaneously.
The below is the proposed design.

Existing Virtual media implementation:

WebUI is having single browse slot. It is used to redirect any kind of media, which can be either CD or HDD media instance.
It is mapped with "/vm/0/0" API endpoint, and media endpoint is hardcoded to 0(Zero).

Virtual media is using "/dev/nbd0" device, and Dump offload is using "/dev/nbd1" device. It is parsing from the jsnbd configuration file.

Enhancement: Multiple simultaneous media redirections feature in single WebUI session.

WebUI will have two different browse slots to select the file, (i.e., ) Virtual media device - HDD and Virtual media device - CD. Both slots will support media redirection concurrently.

Virtual media device - HDD slot is mapped through "/vm/0/0" API endpoint and media endpoint is 0(zero) which is used for initiating the proxy handler, which is present in bmcweb package.
HDD slot will use "/dev/nbd0" device for HDD media instance redirection.

Virtual media device - CD slot is mapped through "/vm/0/1" API endpoint and media endpoint is 1(one) which is used for initiating the proxy handler, which is present in bmcweb package.
CD slot will use "/dev/nbd1" device for CD media instance redirection.

Dump offload will use "/dev/nbd2" device. It is also parsing the nbd device from jsnbd configuration file.

Configuration file looks like,
[cid:image001.jpg@01D80639.FCBD3330]

This is an extension with what the community has implemented and I hope, it does not have any regression or conflict with others who are using virtual media and nbd devices.
Please help to review the proposed implementation, so that, I can go ahead with implementing the enhancement.

Thanks,
Dinesh E



-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #1.2: Type: text/html, Size: 6679 bytes --]

[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 17717 bytes --]

Re: Feature Enhancement - Virtual Media over HTML5

[i.kononenko]

On 10.01.2022 13:25, Dhines Kumar Eswaran wrote:
> Hi All,
> 
> We are planning to support multiple Virtual media redirection support simultaneously.
> The below is the proposed design.
> 

Do you already saw the current work upon redesigning the jsnbd? What backend you are want to use?
The current progress of the nbd-proxy(jsnbd) might conflict with your design if it is based on the current nbd-proxy.
Please, refer to the appropriate gerrit change (1). 

> Existing Virtual media implementation:
> 
> WebUI is having single browse slot. It is used to redirect any kind of media, which can be either CD or HDD media instance.
> It is mapped with "/vm/0/0" API endpoint, and media endpoint is hardcoded to 0(Zero).
> 
> Virtual media is using "/dev/nbd0" device, and Dump offload is using "/dev/nbd1" device. It is parsing from the jsnbd configuration file.
> 
> Enhancement: Multiple simultaneous media redirections feature in single WebUI session.
> 
> WebUI will have two different browse slots to select the file, (i.e., ) Virtual media device - HDD and Virtual media device - CD. Both slots will support media redirection concurrently.
> 

We already have worked in the past to make able configure virtual-media device type by client request. E.g. in the usb-ctrl, we have a flag to specify whether USB, USB-RO, HDD, CD(DVD) VM-type.
Is it really required to have separate VM-endpoints for the CD and HDD types?

> Virtual media device - HDD slot is mapped through "/vm/0/0" API endpoint and media endpoint is 0(zero) which is used for initiating the proxy handler, which is present in bmcweb package.
> HDD slot will use "/dev/nbd0" device for HDD media instance redirection.
> 
> Virtual media device - CD slot is mapped through "/vm/0/1" API endpoint and media endpoint is 1(one) which is used for initiating the proxy handler, which is present in bmcweb package.
> CD slot will use "/dev/nbd1" device for CD media instance redirection.
> 
> Dump offload will use "/dev/nbd2" device. It is also parsing the nbd device from jsnbd configuration file.
> 
> Configuration file looks like,
> [cid:image001.jpg@01D80639.FCBD3330]
> 
> This is an extension with what the community has implemented and I hope, it does not have any regression or conflict with others who are using virtual media and nbd devices.
> Please help to review the proposed implementation, so that, I can go ahead with implementing the enhancement.
> 
> Thanks,
> Dinesh E
> 
> 
> 
> -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> 


Links:
[1] - https://gerrit.openbmc-project.xyz/c/openbmc/jsnbd/+/49944

-- 
Best regards,

Igor Kononenko

RE: [EXTERNAL] Re: Feature Enhancement - Virtual Media over HTML5

[Dhines Kumar Eswaran]

Hi All,

We wanted to know the status of this new design of jsnbd, please let us know if the community is going with this new design or the existing implementation of virtual media.

We are planning to add support for multiple instances of vmedia redirection concurrently from a single client , based on the response for above we would wait for the merge for new design or proceed with our design in the existing implementation.

Thanks.
Dinesh E

-----Original Message-----
From: i.kononenko <i.kononenko@yadro.com>
Sent: 10 January 2022 16:32
To: Dhines Kumar Eswaran <dhineskumare@ami.com>; openbmc@lists.ozlabs.org; ed@tanous.net; jk@ozlabs.org; geissonator@yahoo.com; raviteja28031990@gmail.com; gmills@us.ibm.com
Cc: Gayatri L <gayathril@ami.com>; Pravinash Jeyapaul <pravinashj@ami.com>; Sanjay Ahuja <SanjayA@ami.com>
Subject: [EXTERNAL] Re: Feature Enhancement - Virtual Media over HTML5


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

On 10.01.2022 13:25, Dhines Kumar Eswaran wrote:
> Hi All,
>
> We are planning to support multiple Virtual media redirection support simultaneously.
> The below is the proposed design.
>

Do you already saw the current work upon redesigning the jsnbd? What backend you are want to use?
The current progress of the nbd-proxy(jsnbd) might conflict with your design if it is based on the current nbd-proxy.
Please, refer to the appropriate gerrit change (1).

> Existing Virtual media implementation:
>
> WebUI is having single browse slot. It is used to redirect any kind of media, which can be either CD or HDD media instance.
> It is mapped with "/vm/0/0" API endpoint, and media endpoint is hardcoded to 0(Zero).
>
> Virtual media is using "/dev/nbd0" device, and Dump offload is using "/dev/nbd1" device. It is parsing from the jsnbd configuration file.
>
> Enhancement: Multiple simultaneous media redirections feature in single WebUI session.
>
> WebUI will have two different browse slots to select the file, (i.e., ) Virtual media device - HDD and Virtual media device - CD. Both slots will support media redirection concurrently.
>

We already have worked in the past to make able configure virtual-media device type by client request. E.g. in the usb-ctrl, we have a flag to specify whether USB, USB-RO, HDD, CD(DVD) VM-type.
Is it really required to have separate VM-endpoints for the CD and HDD types?

> Virtual media device - HDD slot is mapped through "/vm/0/0" API endpoint and media endpoint is 0(zero) which is used for initiating the proxy handler, which is present in bmcweb package.
> HDD slot will use "/dev/nbd0" device for HDD media instance redirection.
>
> Virtual media device - CD slot is mapped through "/vm/0/1" API endpoint and media endpoint is 1(one) which is used for initiating the proxy handler, which is present in bmcweb package.
> CD slot will use "/dev/nbd1" device for CD media instance redirection.
>
> Dump offload will use "/dev/nbd2" device. It is also parsing the nbd device from jsnbd configuration file.
>
> Configuration file looks like,
> [cid:image001.jpg@01D80639.FCBD3330]
>
> This is an extension with what the community has implemented and I hope, it does not have any regression or conflict with others who are using virtual media and nbd devices.
> Please help to review the proposed implementation, so that, I can go ahead with implementing the enhancement.
>
> Thanks,
> Dinesh E
>
>
>
> -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>


Links:
[1] - https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.openbmc-project.xyz%2Fc%2Fopenbmc%2Fjsnbd%2F%2B%2F49944&amp;data=04%7C01%7Cdhineskumare%40ami.com%7C94792fcf27594faf5ab908d9d428921a%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C637774093002801627%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=zZ0xayUmcqKc1fTeD6FhCq%2FJ1l9h%2Bps3sE6rDRKIC5M%3D&amp;reserved=0

--
Best regards,

Igor Kononenko
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.