RE: OPENBMC ASRock Rack

RE: OPENBMC ASRock Rack

[Milton Miller II]

[-- Attachment #1.1: Type: text/plain, Size: 851 bytes --]


Jeff9 Chan(陳松儉_ASRockRack)" wrote:

> Hi Milton,
	My user account in Github/Gerrit is Jeff9Chan, but registered CLA account is 'Jeff Chan < Jeff9_Chan@asrockrack.com>'
	Should I re-register CLA info?


Milton> you should not need to reregister.


There are three items here:

Your name, which some projects like the Linux kernel require to be your legal name. This would be how you are addressed in person.   

Your email address, where we can send email and you will receive it

Your GitHub account name, which we also use in the OpenBMC gerrit gerrit.openbmc-project.xyz


Your git client needs your name and email but not your GitHub account name.   That's only needed to setup GitHub and to login to gerrit.   

For instance I sign with Milton Miller but don't need my GitHub account  mdmillerii

Milton

[-- Attachment #1.2: Type: text/html, Size: 984 bytes --]

RE: OPENBMC ASRock Rack

[Jeff9 Chan(陳松儉_ASRockRack)]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Re-send

Hi Bradley,
        I got below error when I try to push meta-asrockrack layer to gerrit.
        Is that means my email is not listed in the list?

To ssh://openbmc.gerrit/openbmc/openbmc
! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
error: failed to push some refs to 'ssh://openbmc.gerrit/openbmc/openbmc'

        My procedure is:

1.      Git clone openbmc

2.      Add meta-asrockrack layer

3.      git remote add gerrit ssh://openbmc.gerrit/openbmc/openbmc

4.      git commit

5.      git push gerrit

My git log:
commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
Author: Jeff9Chan <jeff9_chan@asrockrack.com>
Date:   Tue Jun 8 09:15:44 2021 +0800

    add meta-asrockrack layer
    Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

    Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab


best regards

Jeff Chan
ASRock Inc.
Tel: +886-2-55599600 ext.38670

[-- Attachment #2: Type: text/html, Size: 15315 bytes --]

Re: OPENBMC ASRock Rack

[Ed Tanous]

On Mon, Jun 7, 2021 at 7:01 PM Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan@asrockrack.com> wrote:
>
> Re-send
>
>
>
> Hi Bradley,
>
>         I got below error when I try to push meta-asrockrack layer to gerrit.

Jeff,

On your last thread that you asked this on, you got several replies
about what you were doing wrong.  Please use that thread to
communicate with this list and reply;  Don't start a second thread
like you've done here.

>
>         Is that means my email is not listed in the list?
>
>
>
> To ssh://openbmc.gerrit/openbmc/openbmc
>
> ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
>
> error: failed to push some refs to 'ssh://openbmc.gerrit/openbmc/openbmc'
>
>
>
>         My procedure is:
>
> 1.      Git clone openbmc
>
> 2.      Add meta-asrockrack layer
>
> 3.      git remote add gerrit ssh://openbmc.gerrit/openbmc/openbmc
>
> 4.      git commit
>
> 5.      git push gerrit
>
>
>
> My git log:
>
> commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>
> Author: Jeff9Chan <jeff9_chan@asrockrack.com>
>
> Date:   Tue Jun 8 09:15:44 2021 +0800
>
>
>
>     add meta-asrockrack layer
>
>     Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
>
>
>
>     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
>
>
>
>
>
> best regards
>
>
>
> Jeff Chan
>
> ASRock Inc.
>
> Tel: +886-2-55599600 ext.38670

Re: OPENBMC ASRock Rack

[Joel Stanley]

On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan@asrockrack.com> wrote:
>
> Re-send

Please use plain text email when posting to the list. This is a good
rule to follow for all open source mailing lists.

>         I got below error when I try to push meta-asrockrack layer to gerrit.
>
>         Is that means my email is not listed in the list?
>
>
>
> To ssh://openbmc.gerrit/openbmc/openbmc
>
> ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)

Here is the error:

  (commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)

> commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>
> Author: Jeff9Chan <jeff9_chan@asrockrack.com>
>
> Date:   Tue Jun 8 09:15:44 2021 +0800
>
>
>
>     add meta-asrockrack layer
>
>     Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
>
>
>
>     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab

 I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of
the on the line immediately above or below the change id. Try git
commit --amend and moving it so the message looks like this:

Add meta-asrockrack layer

Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

Cheers,

Joel

RE: OPENBMC ASRock Rack

[Jeff9 Chan(陳松儉_ASRockRack)]

Thanks Joel, it works now.

best regards

Jeff Chan
ASRock Inc. 
Tel: +886-2-55599600 ext.38670


-----Original Message-----
From: Joel Stanley [mailto:joel@jms.id.au] 
Sent: Tuesday, June 8, 2021 2:00 PM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
Subject: Re: OPENBMC ASRock Rack

On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan@asrockrack.com> wrote:
>
> Re-send

Please use plain text email when posting to the list. This is a good
rule to follow for all open source mailing lists.

>         I got below error when I try to push meta-asrockrack layer to gerrit.
>
>         Is that means my email is not listed in the list?
>
>
>
> To ssh://openbmc.gerrit/openbmc/openbmc
>
> ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)

Here is the error:

  (commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)

> commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>
> Author: Jeff9Chan <jeff9_chan@asrockrack.com>
>
> Date:   Tue Jun 8 09:15:44 2021 +0800
>
>
>
>     add meta-asrockrack layer
>
>     Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
>
>
>
>     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab

 I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of
the on the line immediately above or below the change id. Try git
commit --amend and moving it so the message looks like this:

Add meta-asrockrack layer

Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

Cheers,

Joel

RE: OPENBMC ASRock Rack

[Jeff9 Chan(陳松儉_ASRockRack)]

Hi,
	It has been a while after uploading asrockrack layer, looks like no one is reviewing it, what's the next step for me?

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/43850


best regards

Jeff Chan
ASRock Inc. 
Tel: +886-2-55599600 ext.38670


-----Original Message-----
From: Jeff9 Chan(陳松儉_ASRockRack) 
Sent: Tuesday, June 8, 2021 2:48 PM
To: 'Joel Stanley'
Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
Subject: RE: OPENBMC ASRock Rack

Thanks Joel, it works now.

best regards

Jeff Chan
ASRock Inc. 
Tel: +886-2-55599600 ext.38670


-----Original Message-----
From: Joel Stanley [mailto:joel@jms.id.au] 
Sent: Tuesday, June 8, 2021 2:00 PM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
Subject: Re: OPENBMC ASRock Rack

On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan@asrockrack.com> wrote:
>
> Re-send

Please use plain text email when posting to the list. This is a good
rule to follow for all open source mailing lists.

>         I got below error when I try to push meta-asrockrack layer to gerrit.
>
>         Is that means my email is not listed in the list?
>
>
>
> To ssh://openbmc.gerrit/openbmc/openbmc
>
> ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)

Here is the error:

  (commit 1d9951c: not Signed-off-by author/committer/uploader in
message footer)

> commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>
> Author: Jeff9Chan <jeff9_chan@asrockrack.com>
>
> Date:   Tue Jun 8 09:15:44 2021 +0800
>
>
>
>     add meta-asrockrack layer
>
>     Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
>
>
>
>     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab

 I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
of your commit message. Normal style is to place it at the bottom of
the on the line immediately above or below the change id. Try git
commit --amend and moving it so the message looks like this:

Add meta-asrockrack layer

Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

Cheers,

Joel

Re: OPENBMC ASRock Rack

[Ed Tanous]

On Wed, Jul 7, 2021 at 6:50 PM Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan@asrockrack.com> wrote:
>
> Hi,
>         It has been a while after uploading asrockrack layer, looks like no one is reviewing it, what's the next step for me?

I responded to your gerrit review with next steps, primarily educating
yourself on what is allowed in a meta layer, how big patches should
be, and where patches need to be submitted (which are documented in
the docs folder).  Apologies for letting it sit for so long, I was
hoping that you would read the relevant docs and start
updating/submitting your patches, but it looks like you were just
waiting.

-Ed

>
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/43850
>
>
> best regards
>
> Jeff Chan
> ASRock Inc.
> Tel: +886-2-55599600 ext.38670
>
>
> -----Original Message-----
> From: Jeff9 Chan(陳松儉_ASRockRack)
> Sent: Tuesday, June 8, 2021 2:48 PM
> To: 'Joel Stanley'
> Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
> Subject: RE: OPENBMC ASRock Rack
>
> Thanks Joel, it works now.
>
> best regards
>
> Jeff Chan
> ASRock Inc.
> Tel: +886-2-55599600 ext.38670
>
>
> -----Original Message-----
> From: Joel Stanley [mailto:joel@jms.id.au]
> Sent: Tuesday, June 8, 2021 2:00 PM
> To: Jeff9 Chan(陳松儉_ASRockRack)
> Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
> Subject: Re: OPENBMC ASRock Rack
>
> On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)
> <Jeff9_Chan@asrockrack.com> wrote:
> >
> > Re-send
>
> Please use plain text email when posting to the list. This is a good
> rule to follow for all open source mailing lists.
>
> >         I got below error when I try to push meta-asrockrack layer to gerrit.
> >
> >         Is that means my email is not listed in the list?
> >
> >
> >
> > To ssh://openbmc.gerrit/openbmc/openbmc
> >
> > ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
>
> Here is the error:
>
>   (commit 1d9951c: not Signed-off-by author/committer/uploader in
> message footer)
>
> > commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
> >
> > Author: Jeff9Chan <jeff9_chan@asrockrack.com>
> >
> > Date:   Tue Jun 8 09:15:44 2021 +0800
> >
> >
> >
> >     add meta-asrockrack layer
> >
> >     Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
> >
> >
> >
> >     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
>
>  I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
> of your commit message. Normal style is to place it at the bottom of
> the on the line immediately above or below the change id. Try git
> commit --amend and moving it so the message looks like this:
>
> Add meta-asrockrack layer
>
> Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
> Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>
>
> Cheers,
>
> Joel

RE: OPENBMC ASRock Rack

[Milton Miller II]

On June 6, 2021, Jeff Chan wrote:
>  Hi Bradley,
>          I got below error when I try to push meta-asrockrack layer
>to gerrit.
>          Is that means my email is not listed in the list?
>   
>  To ssh://openbmc.gerrit/openbmc/openbmc
>  ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c:
>not Signed-off-by author/committer/uploader in message footer)
>  error: failed to push some refs to
>'ssh://openbmc.gerrit/openbmc/openbmc'
>   
>          My procedure is:
>    1.       Git clone openbmc
>    2.       Add meta-asrockrack layer
>    3.       git remote add gerrit
>ssh://openbmc.gerrit/openbmc/openbmc
>    4.       git commit
>    5.       git push gerrit
>   
>  My git log:
>  commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>  Author: Jeff9Chan <jeff9_chan@asrockrack.com>

The Author name is Jeff9Chan here

>  Date:   Tue Jun 8 09:15:44 2021 +0800
>   
>      add meta-asrockrack layer
>      Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

The Signed-off-by is Jeff Chan here.

The email has different case, not sure if that matters.  But the 
name format likley does.

You can control the format of the author and committer via 
git config --global user.name  "Jeff Chan"
git config --global user.email Jeff9_Chan@asrockrack.com

You can amend the author with git commit --amend --reset-author

Hope this helps,
milton

RE: OPENBMC ASRock Rack

[Jeff9 Chan(陳松儉_ASRockRack)]

Hi Milton,
	My user account in Github/Gerrit is Jeff9Chan, but registered CLA account is 'Jeff Chan < Jeff9_Chan@asrockrack.com>'
	Should I re-register CLA info?

best regards

Jeff Chan
ASRock Inc. 
Tel: +886-2-55599600 ext.38670


-----Original Message-----
From: Milton Miller II [mailto:miltonm@us.ibm.com] 
Sent: Tuesday, June 8, 2021 10:45 AM
To: Jeff9 Chan(陳松儉_ASRockRack)
Cc: Bradley W Bishop; openbmc@lists.ozlabs.org; manager@lfprojects.org
Subject: RE: OPENBMC ASRock Rack

On June 6, 2021, Jeff Chan wrote:
>  Hi Bradley,
>          I got below error when I try to push meta-asrockrack layer
>to gerrit.
>          Is that means my email is not listed in the list?
>   
>  To ssh://openbmc.gerrit/openbmc/openbmc
>  ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c:
>not Signed-off-by author/committer/uploader in message footer)
>  error: failed to push some refs to
>'ssh://openbmc.gerrit/openbmc/openbmc'
>   
>          My procedure is:
>    1.       Git clone openbmc
>    2.       Add meta-asrockrack layer
>    3.       git remote add gerrit
>ssh://openbmc.gerrit/openbmc/openbmc
>    4.       git commit
>    5.       git push gerrit
>   
>  My git log:
>  commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
>  Author: Jeff9Chan <jeff9_chan@asrockrack.com>

The Author name is Jeff9Chan here

>  Date:   Tue Jun 8 09:15:44 2021 +0800
>   
>      add meta-asrockrack layer
>      Signed-off-by: Jeff Chan <Jeff9_Chan@asrockrack.com>

The Signed-off-by is Jeff Chan here.

The email has different case, not sure if that matters.  But the 
name format likley does.

You can control the format of the author and committer via 
git config --global user.name  "Jeff Chan"
git config --global user.email Jeff9_Chan@asrockrack.com

You can amend the author with git commit --amend --reset-author

Hope this helps,
milton