openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
@ 2021-06-23  6:07 Troy Lee
  2021-07-26 17:53 ` Sandhya Koteshwara
  0 siblings, 1 reply; 5+ messages in thread
From: Troy Lee @ 2021-06-23  6:07 UTC (permalink / raw)
  To: leetroy, openbmc, joel

Reporting a BOOT_DEVICE_RAM can leverage common/spl/spl_ram.c
to bring up u-boot.bin by memory offset 0x00010000.

Fixes: 13dd0b0f7273 ("ast2600: spl: Support common boot loader features")
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
---
 arch/arm/mach-aspeed/ast2600/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-aspeed/ast2600/spl.c b/arch/arm/mach-aspeed/ast2600/spl.c
index 778b326755..c759a7575d 100644
--- a/arch/arm/mach-aspeed/ast2600/spl.c
+++ b/arch/arm/mach-aspeed/ast2600/spl.c
@@ -66,7 +66,7 @@ u32 spl_boot_device(void)
 	case AST_BOOTMODE_EMMC:
 		return BOOT_DEVICE_MMC1;
 	case AST_BOOTMODE_SPI:
-		return BOOT_DEVICE_SPI;
+		return BOOT_DEVICE_RAM;
 	case AST_BOOTMODE_UART:
 		return BOOT_DEVICE_UART;
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
  2021-06-23  6:07 [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device Troy Lee
@ 2021-07-26 17:53 ` Sandhya Koteshwara
  2021-07-27  2:22   ` Troy Lee
  0 siblings, 1 reply; 5+ messages in thread
From: Sandhya Koteshwara @ 2021-07-26 17:53 UTC (permalink / raw)
  To: troy_lee; +Cc: leetroy, openbmc

[-- Attachment #1: Type: text/html, Size: 2625 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
  2021-07-26 17:53 ` Sandhya Koteshwara
@ 2021-07-27  2:22   ` Troy Lee
  2021-07-28 21:03     ` Sandhya Koteshwara
  0 siblings, 1 reply; 5+ messages in thread
From: Troy Lee @ 2021-07-27  2:22 UTC (permalink / raw)
  To: Sandhya Koteshwara; +Cc: OpenBMC Maillist, Troy Lee

Hi Sandhya,

The AST2600 hardware hash and crypto engine (HACE) can only exame data
in DRAM, please make sure you copy the kernel fit-image into dram
first.

Thanks,
Troy Lee
--
Yu-Ting Lee (Troy Lee) <LeeTroy@gmail.com>

On Tue, Jul 27, 2021 at 1:53 AM Sandhya Koteshwara
<Sandhya.Koteshwara@ibm.com> wrote:
>
> Hi Troy, Joel,
>
> I am looking to use these patches to secure boot OpenBMC from flash on the AST2600 evaluation board. Is there a relevant UBOOT_MACHINE configuration file I can use?
>
> I am currently porting configuration for secure boot from the ast2600_openbmc_spl_emmc_defconfig to the ast2600_openbmc_spl_defconfig. I was only able to get the u-boot-spl to verify u-boot but kernel verification fails.
>
> Thanks,
> Sandhya
>
> ----- Original message -----
> From: Troy Lee <troy_lee@aspeedtech.com>
> Sent by: "openbmc" <openbmc-bounces+sandhya.koteshwara=ibm.com@lists.ozlabs.org>
> To: <leetroy@gmail.com>, <openbmc@lists.ozlabs.org>, <joel@jms.id.au>
> Cc:
> Subject: [EXTERNAL] [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
> Date: Wed, Jun 23, 2021 2:08 AM
>
> Reporting a BOOT_DEVICE_RAM can leverage common/spl/spl_ram.c
> to bring up u-boot.bin by memory offset 0x00010000.
>
> Fixes: 13dd0b0f7273 ("ast2600: spl: Support common boot loader features")
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
>  arch/arm/mach-aspeed/ast2600/spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-aspeed/ast2600/spl.c b/arch/arm/mach-aspeed/ast2600/spl.c
> index 778b326755..c759a7575d 100644
> --- a/arch/arm/mach-aspeed/ast2600/spl.c
> +++ b/arch/arm/mach-aspeed/ast2600/spl.c
> @@ -66,7 +66,7 @@ u32 spl_boot_device(void)
>   case AST_BOOTMODE_EMMC:
>   return BOOT_DEVICE_MMC1;
>   case AST_BOOTMODE_SPI:
> - return BOOT_DEVICE_SPI;
> + return BOOT_DEVICE_RAM;
>   case AST_BOOTMODE_UART:
>   return BOOT_DEVICE_UART;
>   }
> --
> 2.17.1
>
>
>
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
  2021-07-27  2:22   ` Troy Lee
@ 2021-07-28 21:03     ` Sandhya Koteshwara
  0 siblings, 0 replies; 5+ messages in thread
From: Sandhya Koteshwara @ 2021-07-28 21:03 UTC (permalink / raw)
  To: leetroy; +Cc: openbmc, troy_lee

[-- Attachment #1: Type: text/html, Size: 3783 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device
@ 2021-06-23  3:57 Troy Lee
  0 siblings, 0 replies; 5+ messages in thread
From: Troy Lee @ 2021-06-23  3:57 UTC (permalink / raw)
  To: leetroy, openbmc, joel

Reporting a BOOT_DEVICE_RAM can leverage common/spl/spl_ram.c
to bring up u-boot.bin by memory offset 0x00010000.

Fixes: 13dd0b0f7273 ("ast2600: spl: Support common boot loader features")
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
---
 arch/arm/mach-aspeed/ast2600/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-aspeed/ast2600/spl.c b/arch/arm/mach-aspeed/ast2600/spl.c
index 778b326755..c759a7575d 100644
--- a/arch/arm/mach-aspeed/ast2600/spl.c
+++ b/arch/arm/mach-aspeed/ast2600/spl.c
@@ -66,7 +66,7 @@ u32 spl_boot_device(void)
 	case AST_BOOTMODE_EMMC:
 		return BOOT_DEVICE_MMC1;
 	case AST_BOOTMODE_SPI:
-		return BOOT_DEVICE_SPI;
+		return BOOT_DEVICE_RAM;
 	case AST_BOOTMODE_UART:
 		return BOOT_DEVICE_UART;
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-28 21:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23  6:07 [PATCH u-boot v2019.04-aspeed-openbmc v1 1/2] ast2600: spl: Fixes boot from RAM device Troy Lee
2021-07-26 17:53 ` Sandhya Koteshwara
2021-07-27  2:22   ` Troy Lee
2021-07-28 21:03     ` Sandhya Koteshwara
  -- strict thread matches above, loose matches on Subject: below --
2021-06-23  3:57 Troy Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).