From: Ryan Chen <ryan_chen@aspeedtech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register mode driver
Date: Thu, 23 Feb 2023 00:58:14 +0000 [thread overview]
Message-ID: <SEZPR06MB526909B8D4313CA5F33074C5F2AB9@SEZPR06MB5269.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <77480142-a2c0-f6da-af0e-d3f01f72ac53@linaro.org>
Hello Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, February 22, 2023 4:28 PM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew
> Jeffery <andrew@aj.id.au>; Philipp Zabel <p.zabel@pengutronix.de>;
> openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register
> mode driver
>
> On 22/02/2023 04:36, Ryan Chen wrote:
>
> >>> +
> >>> + return 0;
> >>> +
> >>> +free_irq:
> >>> + devm_free_irq(&pdev->dev, i2c_bus->irq, i2c_bus);
> >>
> >> Why?
> >>
> >>> +unmap:
> >>> + devm_iounmap(&pdev->dev, i2c_bus->reg_base);
> >>
> >> Why?
> >>
> >>> +free_mem:
> >>> + devm_kfree(&pdev->dev, i2c_bus);
> >>
> >> Why?
> >>
> >
> > Sorry, those are probe following, if any error, will goto this label.
> > To release mem/unmap/free_irq. Is this unnecessary?
>
> Releasing managed resources is usualyl unnecessary. Therefore I am asking
> why do you think it is necessary here?
>
> > I saw many driver submit is remove all probe fail goto label, is just return
> ERR.
> > Do you mean I direct go for this way?
>
> Why would you do it differently?
Thanks, I will remove those labels, and modify to dev_err_probe in previous probe return.
> >
> >>> +
> >>> + return ret;
> >>> +}
> >>> +
> >>> +static int ast2600_i2c_remove(struct platform_device *pdev) {
> >>> + struct ast2600_i2c_bus *i2c_bus = platform_get_drvdata(pdev);
> >>> +
> >>> + /* Disable everything. */
> >>> + writel(0, i2c_bus->reg_base + AST2600_I2CC_FUN_CTRL);
> >>> + writel(0, i2c_bus->reg_base + AST2600_I2CM_IER);
> >>> +
> >>> + devm_free_irq(&pdev->dev, i2c_bus->irq, i2c_bus);
> >>> +
> >>> + i2c_del_adapter(&i2c_bus->adap);
> >>
> >> Wrong order of cleanup. It should be reversed to the probe, unless
> >> you have some reason, but then please explain.
> >
> > Sorry, this in remove function, it should do i2c_del_adapter(&i2c_bus->adap)
> in the end.
> > Why this should revered to probe?
>
> Because it's logical, you do the same with error paths of probe, it it usually the
> only way to make sure some of the resources are not used by some other piece
> (e.g. interrupt handler is called while i2c adapter is unregistered).
Sorry, I can't catch your point.
Do you mean remove devm_free_irq(&pdev->dev, i2c_bus->irq, i2c_bus);
Keep i2c_del_adapter(&i2c_bus->adap) here, because interrupt is called while i2c adapter is unregistered ?
Best regards,
Ryan Chen
next prev parent reply other threads:[~2023-02-23 0:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 6:17 [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-02-20 6:17 ` [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Ryan Chen
2023-02-20 8:28 ` Jeremy Kerr
2023-02-20 9:50 ` Ryan Chen
2023-02-20 11:24 ` Jeremy Kerr
2023-02-21 3:32 ` Ryan Chen
2023-02-22 1:14 ` Dhananjay Phadke
2023-02-22 1:30 ` Jeremy Kerr
[not found] ` <676c7777-635c-cc1f-b919-d33e84a45442@linaro.org>
2023-02-21 2:43 ` Ryan Chen
[not found] ` <80d873d4-d813-6c25-8f47-f5ff9af718ec@linaro.org>
2023-02-21 10:42 ` Ryan Chen
[not found] ` <c0ac0ab3-87fc-e74a-b4e2-3cf1b3a8a5e2@linaro.org>
2023-02-22 2:59 ` Ryan Chen
[not found] ` <94238c42-1250-4d51-86e5-0a960dea0ffc@linaro.org>
2023-02-22 10:31 ` Ryan Chen
[not found] ` <b7ca24ea-a265-81cb-3da6-19f938b35878@linaro.org>
2023-02-22 10:47 ` Ryan Chen
[not found] ` <5c255eb3-ec9e-d66f-4a2b-ccc32edf5672@linaro.org>
2023-02-23 10:25 ` Ryan Chen
2023-02-20 6:17 ` [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register mode driver Ryan Chen
[not found] ` <63986fb1-f8d4-f348-bae9-72e08369213b@linaro.org>
2023-02-22 3:36 ` Ryan Chen
[not found] ` <77480142-a2c0-f6da-af0e-d3f01f72ac53@linaro.org>
2023-02-23 0:58 ` Ryan Chen [this message]
[not found] ` <54ef0dee-30dc-3ba9-d2f7-8270204b5505@linaro.org>
2023-02-20 9:56 ` [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
[not found] ` <abec828b-9b34-fc5a-cd36-8be6f20dfd25@linaro.org>
2023-02-21 1:12 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SEZPR06MB526909B8D4313CA5F33074C5F2AB9@SEZPR06MB5269.apcprd06.prod.outlook.com \
--to=ryan_chen@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).