From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2
Date: Wed, 22 Feb 2023 09:30:14 +0800 [thread overview]
Message-ID: <d5d0bbdbfdce06a6e2ad34f2fa8f27d4eaf36207.camel@codeconstruct.com.au> (raw)
In-Reply-To: <TYZPR06MB527469EBE6A18B897D2C1F6CF2A59@TYZPR06MB5274.apcprd06.prod.outlook.com>
Hi Ryan,
> > On the other hand, if it's just because of OS behaviour, then this
> > doesn't belong
> > in the DT.
> >
> > Maybe to help us understand: why would you ever *not* want DMA
> > mode?
> > Isn't that always preferable?
> In AST SOC i2c design is 16 i2c bus share one dma engine.
Does this mean that only one i2c controller in the system can be
configured to use DMA? Or is it able to be shared between multiple
controllers?
> It can be switch setting by dts setting. Otherwise driver by default
> probe is DMA mode.
You've explained what the modes do, and how they're switched, and what
the default is. However this doesn't explain *why* someone would want
to choose a particular mode when creating a controller node.
Still with the question above: assuming there are no restrictions on
DMA usage, why wouldn't a driver implementation just enable it always?
Cheers,
Jeremy
next prev parent reply other threads:[~2023-02-22 1:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 6:17 [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-02-20 6:17 ` [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Ryan Chen
2023-02-20 8:28 ` Jeremy Kerr
2023-02-20 9:50 ` Ryan Chen
2023-02-20 11:24 ` Jeremy Kerr
2023-02-21 3:32 ` Ryan Chen
2023-02-22 1:14 ` Dhananjay Phadke
2023-02-22 1:30 ` Jeremy Kerr [this message]
[not found] ` <676c7777-635c-cc1f-b919-d33e84a45442@linaro.org>
2023-02-21 2:43 ` Ryan Chen
[not found] ` <80d873d4-d813-6c25-8f47-f5ff9af718ec@linaro.org>
2023-02-21 10:42 ` Ryan Chen
[not found] ` <c0ac0ab3-87fc-e74a-b4e2-3cf1b3a8a5e2@linaro.org>
2023-02-22 2:59 ` Ryan Chen
[not found] ` <94238c42-1250-4d51-86e5-0a960dea0ffc@linaro.org>
2023-02-22 10:31 ` Ryan Chen
[not found] ` <b7ca24ea-a265-81cb-3da6-19f938b35878@linaro.org>
2023-02-22 10:47 ` Ryan Chen
[not found] ` <5c255eb3-ec9e-d66f-4a2b-ccc32edf5672@linaro.org>
2023-02-23 10:25 ` Ryan Chen
2023-02-20 6:17 ` [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register mode driver Ryan Chen
[not found] ` <63986fb1-f8d4-f348-bae9-72e08369213b@linaro.org>
2023-02-22 3:36 ` Ryan Chen
[not found] ` <77480142-a2c0-f6da-af0e-d3f01f72ac53@linaro.org>
2023-02-23 0:58 ` Ryan Chen
[not found] ` <54ef0dee-30dc-3ba9-d2f7-8270204b5505@linaro.org>
2023-02-20 9:56 ` [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
[not found] ` <abec828b-9b34-fc5a-cd36-8be6f20dfd25@linaro.org>
2023-02-21 1:12 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d0bbdbfdce06a6e2ad34f2fa8f27d4eaf36207.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).