* [Phosphor-power] psu-ng: Add method to get PSU conf from D-Bus.
@ 2021-06-23 9:11 Chanh Nguyen OS
2021-06-24 17:50 ` Brandon Wyman
0 siblings, 1 reply; 2+ messages in thread
From: Chanh Nguyen OS @ 2021-06-23 9:11 UTC (permalink / raw)
To: bjwyman, openbmc; +Cc: spinler, Thang Nguyen, shawnmm, Phong Vo
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
Hi B. J. Wyman,
I'm using the psu-ng to monitor the PSU. I used the pmbus (https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/pmbus.rst) driver to support hardware monitoring for the PSU, don't use the ibm-cffps driver (https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/ibm-cffps.rst)
I don't clear why we fix to use the IBMCFFPSInterface (https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/38138/10/phosphor-power-supply/psu_manager.cpp#16) ?
Thanks,
Chanh Nguyen
[-- Attachment #2: Type: text/html, Size: 3600 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Phosphor-power] psu-ng: Add method to get PSU conf from D-Bus.
2021-06-23 9:11 [Phosphor-power] psu-ng: Add method to get PSU conf from D-Bus Chanh Nguyen OS
@ 2021-06-24 17:50 ` Brandon Wyman
0 siblings, 0 replies; 2+ messages in thread
From: Brandon Wyman @ 2021-06-24 17:50 UTC (permalink / raw)
To: Chanh Nguyen OS, openbmc; +Cc: spinler, Thang Nguyen, shawnmm, Phong Vo
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On 2021-06-23 04:11, Chanh Nguyen OS wrote:
> Hi B. J. Wyman,
>
> I'm using the psu-ng to monitor the PSU. I used the
> */pmbus/*(https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/pmbus.rst
> <https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/pmbus.rst>)
> driver to support hardware monitoring for the PSU, don't use the
> */ibm-cffps/*driver
> (https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/ibm-cffps.rst
> <https://github.com/openbmc/linux/blob/dev-5.10/Documentation/hwmon/ibm-cffps.rst>)
>
> I don't clear why we fix to use the *IBMCFFPSInterface
> (https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/38138/10/phosphor-power-supply/psu_manager.cpp#16
> <https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/38138/10/phosphor-power-supply/psu_manager.cpp#16>)* ?
Yeah, that was sort of a short-sighted updated. That probably should
have been something configurable:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/43018/8/phosphor-power-supply/power_supply.cpp#30
That is used to get the power supply information off of D-Bus, hopefully
populated by the entity-manager service.
https://github.com/openbmc/entity-manager/blob/master/schemas/IBM.json
https://github.com/openbmc/entity-manager/blob/master/configurations/Nisqually.json
This should *NOT* be IBM specific, but I had some kind of blinders on
when I wrote this.
>
> Thanks,
> Chanh Nguyen
>
[-- Attachment #2: Type: text/html, Size: 5668 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-24 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 9:11 [Phosphor-power] psu-ng: Add method to get PSU conf from D-Bus Chanh Nguyen OS
2021-06-24 17:50 ` Brandon Wyman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).