request to add Gilbert Chen to CLA repository ACL

request to add Gilbert Chen to CLA repository ACL

[Gilbert Chen]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Hi,

Can you help add me to appropriate CLA repository ACL since I want to submit code changes to gerrit but the gerrit shows "OpenBMC CI - User not approved, see admin, no CI".

I have been added in ARM CCLA. https://drive.google.com/file/d/1i0SkfLvR9_loRTZ0zZmC6L_sDOZyQjZB/view

Thanks,
Gilbert

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 2840 bytes --]

Re: request to add Gilbert Chen to CLA repository ACL

[Brad Bishop]

On Thu, 2022-02-10 at 12:52 +0000, Gilbert Chen wrote:
> Hi,
> 
> Can you help add me to appropriate CLA repository ACL since I want to
> submit code changes to gerrit but the gerrit shows "OpenBMC CI - User
> not approved, see admin, no CI".
> 
> I have been added in ARM CCLA.
> https://drive.google.com/file/d/1i0SkfLvR9_loRTZ0zZmC6L_sDOZyQjZB/view
> 
> Thanks,
> Gilbert

Hi Gilbert

I created arm/ci-authorized and arm/ci-authorized-owners groups on
Gerrit.  I put Samer in arm/ci-authorized-owners so he should be able to
add additional people to arm/ci-authorized in the future.

Before CI will use these groups though, you'll have to submit a change
similar to this one:

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/46093

RE: request to add Gilbert Chen to CLA repository ACL

[Gilbert Chen]

Hi Brad,

Thanks for your help. I have submitted a change to add arm in /jenkins/userid-validation
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/51125

Gilbert

-----Original Message-----
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
Sent: Thursday, February 10, 2022 7:50 PM
To: Gilbert Chen <Gilbert.Chen@arm.com>; openbmc@lists.ozlabs.org
Subject: Re: request to add Gilbert Chen to CLA repository ACL

On Thu, 2022-02-10 at 12:52 +0000, Gilbert Chen wrote:
> Hi,
>
> Can you help add me to appropriate CLA repository ACL since I want to
> submit code changes to gerrit but the gerrit shows "OpenBMC CI - User
> not approved, see admin, no CI".
>
> I have been added in ARM CCLA.
> https://drive.google.com/file/d/1i0SkfLvR9_loRTZ0zZmC6L_sDOZyQjZB/view
>
> Thanks,
> Gilbert

Hi Gilbert

I created arm/ci-authorized and arm/ci-authorized-owners groups on Gerrit.  I put Samer in arm/ci-authorized-owners so he should be able to add additional people to arm/ci-authorized in the future.

Before CI will use these groups though, you'll have to submit a change similar to this one:

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/46093
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

RE: request to add Gilbert Chen to CLA repository ACL

[Gilbert Chen]

Hi Brad,

The change of openbmc-build-scripts has been merged. My gerrit account is also in arm/ci-authorized group.
But the gerrit patch I submited still cannot let OpenBMC CI work for me. When I push new commit.
The change log of gerrit still shows "User not approved, see admin CI"
https://gerrit.openbmc-project.xyz/c/openbmc/pldm/+/51184

Sorry for trouble you again. Do you know if anything I missed?

Thanks,
Gilbert

-----Original Message-----
From: Gilbert Chen
Sent: Thursday, February 10, 2022 9:15 PM
To: 'Brad Bishop' <bradleyb@fuzziesquirrel.com>; openbmc@lists.ozlabs.org
Subject: RE: request to add Gilbert Chen to CLA repository ACL

Hi Brad,

Thanks for your help. I have submitted a change to add arm in /jenkins/userid-validation
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/51125

Gilbert

-----Original Message-----
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
Sent: Thursday, February 10, 2022 7:50 PM
To: Gilbert Chen <Gilbert.Chen@arm.com>; openbmc@lists.ozlabs.org
Subject: Re: request to add Gilbert Chen to CLA repository ACL

On Thu, 2022-02-10 at 12:52 +0000, Gilbert Chen wrote:
> Hi,
>
> Can you help add me to appropriate CLA repository ACL since I want to
> submit code changes to gerrit but the gerrit shows "OpenBMC CI - User
> not approved, see admin, no CI".
>
> I have been added in ARM CCLA.
> https://drive.google.com/file/d/1i0SkfLvR9_loRTZ0zZmC6L_sDOZyQjZB/view
>
> Thanks,
> Gilbert

Hi Gilbert

I created arm/ci-authorized and arm/ci-authorized-owners groups on Gerrit.  I put Samer in arm/ci-authorized-owners so he should be able to add additional people to arm/ci-authorized in the future.

Before CI will use these groups though, you'll have to submit a change similar to this one:

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/46093
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: request to add Gilbert Chen to CLA repository ACL

[Brad Bishop]

On Wed, Feb 16, 2022 at 01:48:55PM +0000, Gilbert Chen wrote:
>Hi Brad,
>
>The change of openbmc-build-scripts has been merged. My gerrit account is also in arm/ci-authorized group.
>But the gerrit patch I submited still cannot let OpenBMC CI work for me. When I push new commit.
>The change log of gerrit still shows "User not approved, see admin CI"
>https://gerrit.openbmc-project.xyz/c/openbmc/pldm/+/51184
>
>Sorry for trouble you again. Do you know if anything I missed?

It is no trouble.  I forgot that Gerrit creates private groups by 
default, which would cause this.  I've corrected that and it should work 
now.  Please let me know if it doesn't.

-brad

Re: request to add Gilbert Chen to CLA repository ACL

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On Wed, Feb 16, 2022 at 12:56:20PM -0500, Brad Bishop wrote:
> On Wed, Feb 16, 2022 at 01:48:55PM +0000, Gilbert Chen wrote:
> >Hi Brad,
> >
> >The change of openbmc-build-scripts has been merged. My gerrit account is also in arm/ci-authorized group.
> >But the gerrit patch I submited still cannot let OpenBMC CI work for me. When I push new commit.
> >The change log of gerrit still shows "User not approved, see admin CI"
> >https://gerrit.openbmc-project.xyz/c/openbmc/pldm/+/51184
> >
> >Sorry for trouble you again. Do you know if anything I missed?
> 
> It is no trouble.  I forgot that Gerrit creates private groups by 
> default, which would cause this.  I've corrected that and it should work 
> now.  Please let me know if it doesn't.
> 
> -brad

I retriggered Gilbert's commit in Jenkins and it appears to be working now.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]