Fix u-boot 2016.07 env fail on 64MB layout

Fix u-boot 2016.07 env fail on 64MB layout

[Thang Nguyen]

Hi,
My platform uses Aspeed2500 BMC with 64MB SPI-NOR. Since the change in 
BMC SPI-NOR layout at 
https://github.com/openbmc/linux/commit/985c3f59cc645c397726ad4ca0872cfaf7ef2579, 
the patch 
meta-phosphor/aspeed-layer/recipes-bsp/u-boot/files/0001-configs-ast-Add-redundnant-env.patch 
becomes incorrect for 64MB layout (but still correct for 32MB SPI-NOR 
layout).
Do you have any idea on correcting it for 64MB layout?

Thanks,
Thang Q. Nguyen

Re: [External] Fix u-boot 2016.07 env fail on 64MB layout

[Lei Yu]

Please refer to
https://lore.kernel.org/openbmc/CAGm54UGMSVkT=3WLVLrJwcW8OGcQJZOGYnhVvOrF1qVC7xtdvA@mail.gmail.com/
In short, it's suggested to use the u-boot-aspeed-sdk recipe instead
of u-boot-aspeed for the 64MiB layout.

On Fri, Oct 29, 2021 at 7:16 PM Thang Nguyen
<thang@amperemail.onmicrosoft.com> wrote:
>
> Hi,
> My platform uses Aspeed2500 BMC with 64MB SPI-NOR. Since the change in
> BMC SPI-NOR layout at
> https://github.com/openbmc/linux/commit/985c3f59cc645c397726ad4ca0872cfaf7ef2579,
> the patch
> meta-phosphor/aspeed-layer/recipes-bsp/u-boot/files/0001-configs-ast-Add-redundnant-env.patch
> becomes incorrect for 64MB layout (but still correct for 32MB SPI-NOR
> layout).
> Do you have any idea on correcting it for 64MB layout?
>
> Thanks,
> Thang Q. Nguyen



-- 
BRs,
Lei YU

Re: [External] Fix u-boot 2016.07 env fail on 64MB layout

[Thang Nguyen]

On 29/10/2021 19:39, Lei Yu wrote:
> Please refer to
> https://lore.kernel.org/openbmc/CAGm54UGMSVkT=3WLVLrJwcW8OGcQJZOGYnhVvOrF1qVC7xtdvA@mail.gmail.com/
> In short, it's suggested to use the u-boot-aspeed-sdk recipe instead
> of u-boot-aspeed for the 64MiB layout.
Thanks for your feedback. I tried u-boot-sdk before. But I just want to 
know if we have any solution to support in u-boot 2016.07 instead.
Supporting u-boot-sdr will need to add device tree for our platform. If 
no solution for u-boot 2016.07, I will change to u-boot-sdr.
> 
> On Fri, Oct 29, 2021 at 7:16 PM Thang Nguyen
> <thang@amperemail.onmicrosoft.com> wrote:
>>
>> Hi,
>> My platform uses Aspeed2500 BMC with 64MB SPI-NOR. Since the change in
>> BMC SPI-NOR layout at
>> https://github.com/openbmc/linux/commit/985c3f59cc645c397726ad4ca0872cfaf7ef2579,
>> the patch
>> meta-phosphor/aspeed-layer/recipes-bsp/u-boot/files/0001-configs-ast-Add-redundnant-env.patch
>> becomes incorrect for 64MB layout (but still correct for 32MB SPI-NOR
>> layout).
>> Do you have any idea on correcting it for 64MB layout?
>>
>> Thanks,
>> Thang Q. Nguyen
> 
> 
> 

Re: Fix u-boot 2016.07 env fail on 64MB layout

[Joel Stanley]

On Fri, 29 Oct 2021 at 11:16, Thang Nguyen
<thang@amperemail.onmicrosoft.com> wrote:
>
> Hi,
> My platform uses Aspeed2500 BMC with 64MB SPI-NOR. Since the change in
> BMC SPI-NOR layout at
> https://github.com/openbmc/linux/commit/985c3f59cc645c397726ad4ca0872cfaf7ef2579,
> the patch
> meta-phosphor/aspeed-layer/recipes-bsp/u-boot/files/0001-configs-ast-Add-redundnant-env.patch
> becomes incorrect for 64MB layout (but still correct for 32MB SPI-NOR
> layout).
> Do you have any idea on correcting it for 64MB layout?

I suggest deleting the patch. It should not live in meta-phosphor. If
this feature is required, it should be controlled with a configuration
in u-boot defconfig.

I also suggest using the newer u-boot version (2019.04) for your platform.

Cheers,

Joel

>
> Thanks,
> Thang Q. Nguyen