* libpsl: Add config knobs for runtime/builtin conversion choices
@ 2021-10-13 19:13 Valek, Andrej
2021-10-14 17:36 ` Steve Sakoman
0 siblings, 1 reply; 7+ messages in thread
From: Valek, Andrej @ 2021-10-13 19:13 UTC (permalink / raw)
To: steve; +Cc: openembedded-core, raj.khem
Hello Steve,
Would it be possible to include this commit
https://lists.openembedded.org/g/openembedded-core/message/150627 into
dunfell branch?
Thanks,
Andrej
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-13 19:13 libpsl: Add config knobs for runtime/builtin conversion choices Valek, Andrej
@ 2021-10-14 17:36 ` Steve Sakoman
2021-10-15 6:15 ` Valek, Andrej
0 siblings, 1 reply; 7+ messages in thread
From: Steve Sakoman @ 2021-10-14 17:36 UTC (permalink / raw)
To: Valek, Andrej; +Cc: openembedded-core, raj.khem
On Wed, Oct 13, 2021 at 9:14 AM Valek, Andrej <andrej.valek@siemens.com> wrote:
> Would it be possible to include this commit
> https://lists.openembedded.org/g/openembedded-core/message/150627 into
> dunfell branch?
At first glance this seems to change the default behavior. Perhaps a
version of the patch that adds the knobs but keeps the same behavior?
I may be mistaken since I'm not really familiar with this package, so
would love input from those who are!
Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-14 17:36 ` Steve Sakoman
@ 2021-10-15 6:15 ` Valek, Andrej
2021-10-15 9:58 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Valek, Andrej @ 2021-10-15 6:15 UTC (permalink / raw)
To: steve; +Cc: openembedded-core, raj.khem
The reason, why I want to apply it here, to switch replace libidn2 with
icu. According to libpsl documentation, you can chose who will generate
the PSL database (libidn, libidn2, icu). So I don't want to install a
new component if there is a valid replacement which is already
installed.
Regards,
Andrej
On Thu, 2021-10-14 at 07:36 -1000, Steve Sakoman wrote:
> On Wed, Oct 13, 2021 at 9:14 AM Valek, Andrej
> <andrej.valek@siemens.com> wrote:
>
> > Would it be possible to include this commit
> > https://lists.openembedded.org/g/openembedded-core/message/150627 i
> > nto
> > dunfell branch?
>
> At first glance this seems to change the default behavior. Perhaps a
> version of the patch that adds the knobs but keeps the same behavior?
>
> I may be mistaken since I'm not really familiar with this package, so
> would love input from those who are!
>
> Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-15 6:15 ` Valek, Andrej
@ 2021-10-15 9:58 ` Richard Purdie
2021-10-15 10:39 ` Valek, Andrej
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2021-10-15 9:58 UTC (permalink / raw)
To: Andrej Valek, steve; +Cc: openembedded-core, raj.khem
On Fri, 2021-10-15 at 06:15 +0000, Andrej Valek wrote:
> The reason, why I want to apply it here, to switch replace libidn2 with
> icu. According to libpsl documentation, you can chose who will generate
> the PSL database (libidn, libidn2, icu). So I don't want to install a
> new component if there is a valid replacement which is already
> installed.
I think what Steve is suggesting is a tweaked version which doesn't change the
current situation, just adds the PACKAGECONFIG options but doesn't change the
current default.
You could then change the configuration in your distro.
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-15 9:58 ` [OE-core] " Richard Purdie
@ 2021-10-15 10:39 ` Valek, Andrej
2021-10-15 15:45 ` Steve Sakoman
0 siblings, 1 reply; 7+ messages in thread
From: Valek, Andrej @ 2021-10-15 10:39 UTC (permalink / raw)
To: richard.purdie, steve; +Cc: openembedded-core, raj.khem
Ok, but I've just copied the existing commit from master. So I have to
send a different configuration for dunfell?
Andrej
On Fri, 2021-10-15 at 10:58 +0100, Richard Purdie wrote:
> On Fri, 2021-10-15 at 06:15 +0000, Andrej Valek wrote:
> > The reason, why I want to apply it here, to switch replace libidn2
> > with
> > icu. According to libpsl documentation, you can chose who will
> > generate
> > the PSL database (libidn, libidn2, icu). So I don't want to install
> > a
> > new component if there is a valid replacement which is already
> > installed.
>
> I think what Steve is suggesting is a tweaked version which doesn't
> change the
> current situation, just adds the PACKAGECONFIG options but doesn't
> change the
> current default.
>
> You could then change the configuration in your distro.
>
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-15 10:39 ` Valek, Andrej
@ 2021-10-15 15:45 ` Steve Sakoman
2021-10-16 18:40 ` [OE-core][dunfell][PATCH] " Andrej Valek
0 siblings, 1 reply; 7+ messages in thread
From: Steve Sakoman @ 2021-10-15 15:45 UTC (permalink / raw)
To: Andrej Valek; +Cc: richard.purdie, openembedded-core, raj.khem
On Fri, Oct 15, 2021 at 12:39 AM Andrej Valek <andrej.valek@siemens.com> wrote:
>
> Ok, but I've just copied the existing commit from master. So I have to
> send a different configuration for dunfell?
Correct, for a stable release we don't want to change default
behavior. So we can't take the commit directly from master since it
does change behavior.
Steve
>
> Andrej
>
> On Fri, 2021-10-15 at 10:58 +0100, Richard Purdie wrote:
> > On Fri, 2021-10-15 at 06:15 +0000, Andrej Valek wrote:
> > > The reason, why I want to apply it here, to switch replace libidn2
> > > with
> > > icu. According to libpsl documentation, you can chose who will
> > > generate
> > > the PSL database (libidn, libidn2, icu). So I don't want to install
> > > a
> > > new component if there is a valid replacement which is already
> > > installed.
> >
> > I think what Steve is suggesting is a tweaked version which doesn't
> > change the
> > current situation, just adds the PACKAGECONFIG options but doesn't
> > change the
> > current default.
> >
> > You could then change the configuration in your distro.
> >
> > Cheers,
> >
> > Richard
> >
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156989): https://lists.openembedded.org/g/openembedded-core/message/156989
> Mute This Topic: https://lists.openembedded.org/mt/86296104/3617601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [sakoman@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [OE-core][dunfell][PATCH] libpsl: Add config knobs for runtime/builtin conversion choices
2021-10-15 15:45 ` Steve Sakoman
@ 2021-10-16 18:40 ` Andrej Valek
0 siblings, 0 replies; 7+ messages in thread
From: Andrej Valek @ 2021-10-16 18:40 UTC (permalink / raw)
To: openembedded-core; +Cc: sakoman, richard.purdie, raj.khem, Andrej Valek
Based on d22d87b9c4ac85ffb3506e2acaf2a8a627f55e8e, but kept idn2
as default.
Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
---
meta/recipes-support/libpsl/libpsl_0.21.0.bb | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-support/libpsl/libpsl_0.21.0.bb b/meta/recipes-support/libpsl/libpsl_0.21.0.bb
index b2dda191ce..66e64f785c 100644
--- a/meta/recipes-support/libpsl/libpsl_0.21.0.bb
+++ b/meta/recipes-support/libpsl/libpsl_0.21.0.bb
@@ -19,11 +19,10 @@ SRC_URI[sha256sum] = "41bd1c75a375b85c337b59783f5deb93dbb443fb0a52d257f403df7bd6
UPSTREAM_CHECK_URI = "https://github.com/rockdaboot/libpsl/releases"
-DEPENDS = "libidn2"
-
inherit autotools gettext gtk-doc manpages pkgconfig lib_package
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ?= "idn2"
PACKAGECONFIG[manpages] = "--enable-man,--disable-man,libxslt-native"
-
+PACKAGECONFIG[icu] = "--enable-runtime=libicu --enable-builtin=libicu,,icu"
+PACKAGECONFIG[idn2] = "--enable-runtime=libidn2 --enable-builtin=libidn2,,libidn2 libunistring"
BBCLASSEXTEND = "native nativesdk"
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-16 18:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 19:13 libpsl: Add config knobs for runtime/builtin conversion choices Valek, Andrej
2021-10-14 17:36 ` Steve Sakoman
2021-10-15 6:15 ` Valek, Andrej
2021-10-15 9:58 ` [OE-core] " Richard Purdie
2021-10-15 10:39 ` Valek, Andrej
2021-10-15 15:45 ` Steve Sakoman
2021-10-16 18:40 ` [OE-core][dunfell][PATCH] " Andrej Valek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).