* [OE-core] [PATCH] u-boot: Fix syntax error in ${UBOOT_ENV}.scr compilation
@ 2021-10-19 13:47 Peter Hoyes
0 siblings, 0 replies; only message in thread
From: Peter Hoyes @ 2021-10-19 13:47 UTC (permalink / raw)
To: openembedded-core; +Cc: Peter Hoyes
From: Peter Hoyes <Peter.Hoyes@arm.com>
A previous commit (a3d3c2d4ac421a0dde2a20825eab4434f16b2452) introduced
support for compiling a U-Boot boot script, but the logic contained a
syntax error which was only visible in the build log. Fix the error by
using separate []s for each expression in the if statement.
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
---
meta/recipes-bsp/u-boot/u-boot.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
index ec4a3d201d1..2d5e46f4ef1 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -108,7 +108,7 @@ do_compile () {
fi
fi
- if [ -n "${UBOOT_ENV}" && "${UBOOT_ENV_SUFFIX}" = "scr" ]
+ if [ -n "${UBOOT_ENV}" ] && [ "${UBOOT_ENV_SUFFIX}" = "scr" ]
then
${UBOOT_MKIMAGE} -C none -A ${UBOOT_ARCH} -T script -d ${WORKDIR}/${UBOOT_ENV_SRC} ${WORKDIR}/${UBOOT_ENV_BINARY}
fi
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-19 13:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 13:47 [OE-core] [PATCH] u-boot: Fix syntax error in ${UBOOT_ENV}.scr compilation Peter Hoyes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).