* [oe-core][PATCH 1/4] ell: upgrade 0.56 -> 0.57 @ 2023-05-27 13:32 Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency Markus Volk ` (2 more replies) 0 siblings, 3 replies; 18+ messages in thread From: Markus Volk @ 2023-05-27 13:32 UTC (permalink / raw) To: openembedded-core; +Cc: Markus Volk ver 0.57: Fix issue with handling Generic Netlink cancel requests. ell 0.57 is required for iwd 2.5 Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-core/ell/{ell_0.56.bb => ell_0.57.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-core/ell/{ell_0.56.bb => ell_0.57.bb} (89%) diff --git a/meta/recipes-core/ell/ell_0.56.bb b/meta/recipes-core/ell/ell_0.57.bb similarity index 89% rename from meta/recipes-core/ell/ell_0.56.bb rename to meta/recipes-core/ell/ell_0.57.bb index 0ace622835..09a0831fbe 100644 --- a/meta/recipes-core/ell/ell_0.56.bb +++ b/meta/recipes-core/ell/ell_0.57.bb @@ -15,7 +15,7 @@ DEPENDS = "dbus" inherit autotools pkgconfig SRC_URI = "https://mirrors.edge.kernel.org/pub/linux/libs/${BPN}/${BPN}-${PV}.tar.xz" -SRC_URI[sha256sum] = "58eb8b2b64087f7479d5db6a830a0656c536d93e5f11d4c9a4443ce8760a1b63" +SRC_URI[sha256sum] = "7603928ee584b758ca27c67e4dc513049a09b038d7d28459a9440f8443c91018" do_configure:prepend () { mkdir -p ${S}/build-aux -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-27 13:32 [oe-core][PATCH 1/4] ell: upgrade 0.56 -> 0.57 Markus Volk @ 2023-05-27 13:32 ` Markus Volk 2023-05-28 13:39 ` Alexander Kanavin [not found] ` <17635252DFD4EDDE.6918@lists.openembedded.org> 2023-05-27 13:32 ` [oe-core][PATCH 3/4] ruby: " Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 4/4] shadow: " Markus Volk 2 siblings, 2 replies; 18+ messages in thread From: Markus Volk @ 2023-05-27 13:32 UTC (permalink / raw) To: openembedded-core; +Cc: Markus Volk crypt.h is otherwise taken from the host machine Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-devtools/python/python3_3.11.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/python/python3_3.11.2.bb b/meta/recipes-devtools/python/python3_3.11.2.bb index 421a305e22..1ca4ad35be 100644 --- a/meta/recipes-devtools/python/python3_3.11.2.bb +++ b/meta/recipes-devtools/python/python3_3.11.2.bb @@ -72,7 +72,7 @@ ALTERNATIVE_LINK_NAME[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config ALTERNATIVE_TARGET[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}" -DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses" +DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses libxcrypt-native" DEPENDS:append:class-target = " python3-native" DEPENDS:append:class-nativesdk = " python3-native" -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-27 13:32 ` [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency Markus Volk @ 2023-05-28 13:39 ` Alexander Kanavin 2023-05-28 13:56 ` Markus Volk [not found] ` <17635252DFD4EDDE.6918@lists.openembedded.org> 1 sibling, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-05-28 13:39 UTC (permalink / raw) To: Markus Volk; +Cc: openembedded-core Can you please show how it looks like? We do have a test for host contamination via headers, so I'd like to see what happens exactly and where the test isn't catching it. Same for patches 3/4, 4/4. Alex On Sat, 27 May 2023 at 15:33, Markus Volk <f_l_k@t-online.de> wrote: > > crypt.h is otherwise taken from the host machine > > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > meta/recipes-devtools/python/python3_3.11.2.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/python/python3_3.11.2.bb b/meta/recipes-devtools/python/python3_3.11.2.bb > index 421a305e22..1ca4ad35be 100644 > --- a/meta/recipes-devtools/python/python3_3.11.2.bb > +++ b/meta/recipes-devtools/python/python3_3.11.2.bb > @@ -72,7 +72,7 @@ ALTERNATIVE_LINK_NAME[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config > ALTERNATIVE_TARGET[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}" > > > -DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses" > +DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses libxcrypt-native" > DEPENDS:append:class-target = " python3-native" > DEPENDS:append:class-nativesdk = " python3-native" > > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#181806): https://lists.openembedded.org/g/openembedded-core/message/181806 > Mute This Topic: https://lists.openembedded.org/mt/99167320/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 13:39 ` Alexander Kanavin @ 2023-05-28 13:56 ` Markus Volk 0 siblings, 0 replies; 18+ messages in thread From: Markus Volk @ 2023-05-28 13:56 UTC (permalink / raw) To: Alexander Kanavin; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 2823 bytes --] I noticed this because I was trying to see if my image could reproduce itself. To do this I installed some build tools, perl and python modules and tried if a core-image-minimal can be built in this environment. This failed for some packages because crypt() was missing. I did not have any dev packages installed, so my guess was that it was because my image was missing crypt.h. To reproduce this on my host machine (Ubuntu 22.04), I ran sudo mv /usr/include/crypt.h /usr/include/crypt.h.old sudo rm -r tmp sstate-cache Now I also had errors on my host system Am So, 28. Mai 2023 um 15:39:47 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > Can you please show how it looks like? We do have a test for host > contamination via headers, so I'd like to see what happens exactly and > where the test isn't catching it. > > Same for patches 3/4, 4/4. > > Alex > > On Sat, 27 May 2023 at 15:33, Markus Volk <f_l_k@t-online.de > <mailto:f_l_k@t-online.de>> wrote: >> >> crypt.h is otherwise taken from the host machine >> >> Signed-off-by: Markus Volk <f_l_k@t-online.de >> <mailto:f_l_k@t-online.de>> >> --- >> meta/recipes-devtools/python/python3_3.11.2.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-devtools/python/python3_3.11.2.bb >> b/meta/recipes-devtools/python/python3_3.11.2.bb >> index 421a305e22..1ca4ad35be 100644 >> --- a/meta/recipes-devtools/python/python3_3.11.2.bb >> +++ b/meta/recipes-devtools/python/python3_3.11.2.bb >> @@ -72,7 +72,7 @@ ALTERNATIVE_LINK_NAME[python3-config] = >> "${bindir}/python${PYTHON_MAJMIN}-config >> ALTERNATIVE_TARGET[python3-config] = >> "${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}" >> >> >> -DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl >> sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid >> libtirpc libnsl2 autoconf-archive-native ncurses" >> +DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl >> sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid >> libtirpc libnsl2 autoconf-archive-native ncurses libxcrypt-native" >> DEPENDS:append:class-target = " python3-native" >> DEPENDS:append:class-nativesdk = " python3-native" >> >> -- >> 2.34.1 >> >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#181824): > <https://lists.openembedded.org/g/openembedded-core/message/181824> > Mute This Topic: <https://lists.openembedded.org/mt/99167320/3618223> > Group Owner: openembedded-core+owner@lists.openembedded.org > <mailto:openembedded-core+owner@lists.openembedded.org> > Unsubscribe: > <https://lists.openembedded.org/g/openembedded-core/unsub> > [f_l_k@t-online.de <mailto:f_l_k@t-online.de>] > -=-=-=-=-=-=-=-=-=-=-=- > [-- Attachment #2: Type: text/html, Size: 3304 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <17635252DFD4EDDE.6918@lists.openembedded.org>]
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency [not found] ` <17635252DFD4EDDE.6918@lists.openembedded.org> @ 2023-05-28 13:41 ` Alexander Kanavin 2023-05-28 14:03 ` Markus Volk 0 siblings, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-05-28 13:41 UTC (permalink / raw) To: alex.kanavin; +Cc: Markus Volk, openembedded-core Also, how is the native header used in the target build? Isn't that incorrect in itself? Alex On Sun, 28 May 2023 at 15:40, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > Can you please show how it looks like? We do have a test for host > contamination via headers, so I'd like to see what happens exactly and > where the test isn't catching it. > > Same for patches 3/4, 4/4. > > Alex > > On Sat, 27 May 2023 at 15:33, Markus Volk <f_l_k@t-online.de> wrote: > > > > crypt.h is otherwise taken from the host machine > > > > Signed-off-by: Markus Volk <f_l_k@t-online.de> > > --- > > meta/recipes-devtools/python/python3_3.11.2.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/python/python3_3.11.2.bb b/meta/recipes-devtools/python/python3_3.11.2.bb > > index 421a305e22..1ca4ad35be 100644 > > --- a/meta/recipes-devtools/python/python3_3.11.2.bb > > +++ b/meta/recipes-devtools/python/python3_3.11.2.bb > > @@ -72,7 +72,7 @@ ALTERNATIVE_LINK_NAME[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config > > ALTERNATIVE_TARGET[python3-config] = "${bindir}/python${PYTHON_MAJMIN}-config-${MULTILIB_SUFFIX}" > > > > > > -DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses" > > +DEPENDS = "bzip2-replacement-native expat libffi bzip2 openssl sqlite3 zlib virtual/libintl xz virtual/crypt util-linux-libuuid libtirpc libnsl2 autoconf-archive-native ncurses libxcrypt-native" > > DEPENDS:append:class-target = " python3-native" > > DEPENDS:append:class-nativesdk = " python3-native" > > > > -- > > 2.34.1 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#181824): https://lists.openembedded.org/g/openembedded-core/message/181824 > Mute This Topic: https://lists.openembedded.org/mt/99167320/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 13:41 ` Alexander Kanavin @ 2023-05-28 14:03 ` Markus Volk 2023-05-28 14:23 ` Alexander Kanavin 0 siblings, 1 reply; 18+ messages in thread From: Markus Volk @ 2023-05-28 14:03 UTC (permalink / raw) To: Alexander Kanavin; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 256 bytes --] Am So, 28. Mai 2023 um 15:41:10 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > Also, how is the native header used in the target build? Isn't that > incorrect in itself? I guess its only needed to build the native variants of that packages [-- Attachment #2: Type: text/html, Size: 421 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 14:03 ` Markus Volk @ 2023-05-28 14:23 ` Alexander Kanavin 2023-05-28 14:53 ` Markus Volk 0 siblings, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-05-28 14:23 UTC (permalink / raw) To: Markus Volk; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 525 bytes --] But can you show the actual error please? If it’s a native only issue then a different fix is needed, so that native dependency isn’t added to a target build. Alex On Sun 28. May 2023 at 16.03, Markus Volk <f_l_k@t-online.de> wrote: > Am So, 28. Mai 2023 um 15:41:10 +0200 schrieb Alexander Kanavin < > alex.kanavin@gmail.com>: > > Also, how is the native header used in the target build? Isn't that > incorrect in itself? > > > I guess its only needed to build the native variants of that packages > [-- Attachment #2: Type: text/html, Size: 1105 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 14:23 ` Alexander Kanavin @ 2023-05-28 14:53 ` Markus Volk 2023-05-28 15:01 ` Alexander Kanavin 0 siblings, 1 reply; 18+ messages in thread From: Markus Volk @ 2023-05-28 14:53 UTC (permalink / raw) To: Alexander Kanavin; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 4478 bytes --] Am So, 28. Mai 2023 um 16:23:36 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > But can you show the actual error please? python3-native for example fails like this: ERROR: python3-native-3.11.2-r0 do_install: ExecutionError('/home/flk/poky/build/tmp/work/x86_64-linux/python3-native/3.11.2-r0/temp/run.do_install.4082972', 1, None, None) ERROR: Logfile of failure stored in: /home/flk/poky/build/tmp/work/x86_64-linux/python3-native/3.11.2-r0/temp/log.do_install.4082972 Log data follows: | DEBUG: Executing python function autotools_aclocals | DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc', 'bit-64', 'x86_64-linux', 'common'] | DEBUG: Python function autotools_aclocals finished | DEBUG: Executing shell function do_install | The necessary bits to build these optional modules were not found: | _crypt | | WARNING: exit code 1 from a shell command. ERROR: Task (virtual:native:/home/flk/poky/meta/recipes-devtools/python/python3_3.11.2.bb:do_install) failed with exit code '1' NOTE: Tasks Summary: Attempted 1089 tasks of which 1078 didn't need to be rerun and 1 failed. Summary: 1 task failed: virtual:native:/home/flk/poky/meta/recipes-devtools/python/python3_3.11.2.bb:do_install Summary: There was 1 ERROR message, returning a non-zero exit code. ruby-native fails like this: compiling ../ruby-3.2.2/vm_trace.c | In file included from ../ruby-3.2.2/include/ruby/ruby.h:42, | from ../ruby-3.2.2/debug_counter.h:362, | from ../ruby-3.2.2/string.c:24: | ../ruby-3.2.2/string.c: In function ‘rb_str_crypt’: | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | ../ruby-3.2.2/include/ruby/internal/memory.h:299:7: note: in definition of macro ‘RB_ALLOCV’ | 299 | ((n) < RUBY_ALLOCV_LIMIT ? \ | | ^ | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | compiling ../ruby-3.2.2/missing/setproctitle.c | compiling ../ruby-3.2.2/missing/strlcpy.c | compiling ../ruby-3.2.2/missing/strlcat.c | In file included from /usr/include/stdlib.h:574, | from ../ruby-3.2.2/include/ruby/defines.h:27, | from ../ruby-3.2.2/include/ruby/ruby.h:25, | from ../ruby-3.2.2/debug_counter.h:362, | from ../ruby-3.2.2/string.c:24: | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | ../ruby-3.2.2/include/ruby/internal/memory.h:398:20: note: in expansion of macro ‘RB_ALLOCV’ | 398 | #define ALLOCV RB_ALLOCV /**< @old{RB_ALLOCV} */ | | ^~~~~~~~~ | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | In file included from ../ruby-3.2.2/include/ruby/ruby.h:42, | from ../ruby-3.2.2/debug_counter.h:362, | from ../ruby-3.2.2/string.c:24: | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | ../ruby-3.2.2/include/ruby/internal/memory.h:301:33: note: in definition of macro ‘RB_ALLOCV’ | 301 | rb_alloc_tmp_buffer(&(v), (n))) | | ^ | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); | | ^~~~~~ | ../ruby-3.2.2/string.c:10173:11: warning: implicit declaration of function ‘crypt_r’; did you mean ‘crypt’? [-Wimplicit-function-declaration] | 10173 | res = crypt_r(s, saltp, data); | | ^~~~~~~ | | crypt | ../ruby-3.2.2/string.c:10173:9: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] | 10173 | res = crypt_r(s, saltp, data); | | ^ [-- Attachment #2: Type: text/html, Size: 6487 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 14:53 ` Markus Volk @ 2023-05-28 15:01 ` Alexander Kanavin 2023-05-28 15:08 ` Markus Volk 0 siblings, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-05-28 15:01 UTC (permalink / raw) To: Markus Volk; +Cc: openembedded-core Thanks, then all three recipes should add libxcrypt to DEPENDS (not libxcrypt-native). For native variants it will be adjusted automatically. Alex On Sun, 28 May 2023 at 16:53, Markus Volk <f_l_k@t-online.de> wrote: > > Am So, 28. Mai 2023 um 16:23:36 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > > But can you show the actual error please? > > > python3-native for example fails like this: > ERROR: python3-native-3.11.2-r0 do_install: ExecutionError('/home/flk/poky/build/tmp/work/x86_64-linux/python3-native/3.11.2-r0/temp/run.do_install.4082972', 1, None, None) > ERROR: Logfile of failure stored in: /home/flk/poky/build/tmp/work/x86_64-linux/python3-native/3.11.2-r0/temp/log.do_install.4082972 > Log data follows: > | DEBUG: Executing python function autotools_aclocals > | DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc', 'bit-64', 'x86_64-linux', 'common'] > | DEBUG: Python function autotools_aclocals finished > | DEBUG: Executing shell function do_install > | The necessary bits to build these optional modules were not found: > | _crypt > | > | WARNING: exit code 1 from a shell command. > ERROR: Task (virtual:native:/home/flk/poky/meta/recipes-devtools/python/python3_3.11.2.bb:do_install) failed with exit code '1' > NOTE: Tasks Summary: Attempted 1089 tasks of which 1078 didn't need to be rerun and 1 failed. > > Summary: 1 task failed: > virtual:native:/home/flk/poky/meta/recipes-devtools/python/python3_3.11.2.bb:do_install > Summary: There was 1 ERROR message, returning a non-zero exit code. > > > ruby-native fails like this: > > compiling ../ruby-3.2.2/vm_trace.c > | In file included from ../ruby-3.2.2/include/ruby/ruby.h:42, > | from ../ruby-3.2.2/debug_counter.h:362, > | from ../ruby-3.2.2/string.c:24: > | ../ruby-3.2.2/string.c: In function ‘rb_str_crypt’: > | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | ../ruby-3.2.2/include/ruby/internal/memory.h:299:7: note: in definition of macro ‘RB_ALLOCV’ > | 299 | ((n) < RUBY_ALLOCV_LIMIT ? \ > | | ^ > | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | compiling ../ruby-3.2.2/missing/setproctitle.c > | compiling ../ruby-3.2.2/missing/strlcpy.c > | compiling ../ruby-3.2.2/missing/strlcat.c > | In file included from /usr/include/stdlib.h:574, > | from ../ruby-3.2.2/include/ruby/defines.h:27, > | from ../ruby-3.2.2/include/ruby/ruby.h:25, > | from ../ruby-3.2.2/debug_counter.h:362, > | from ../ruby-3.2.2/string.c:24: > | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | ../ruby-3.2.2/include/ruby/internal/memory.h:398:20: note: in expansion of macro ‘RB_ALLOCV’ > | 398 | #define ALLOCV RB_ALLOCV /**< @old{RB_ALLOCV} */ > | | ^~~~~~~~~ > | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | In file included from ../ruby-3.2.2/include/ruby/ruby.h:42, > | from ../ruby-3.2.2/debug_counter.h:362, > | from ../ruby-3.2.2/string.c:24: > | ../ruby-3.2.2/string.c:10169:35: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | ../ruby-3.2.2/include/ruby/internal/memory.h:301:33: note: in definition of macro ‘RB_ALLOCV’ > | 301 | rb_alloc_tmp_buffer(&(v), (n))) > | | ^ > | ../ruby-3.2.2/string.c:10169:12: note: in expansion of macro ‘ALLOCV’ > | 10169 | data = ALLOCV(databuf, sizeof(struct crypt_data)); > | | ^~~~~~ > | ../ruby-3.2.2/string.c:10173:11: warning: implicit declaration of function ‘crypt_r’; did you mean ‘crypt’? [-Wimplicit-function-declaration] > | 10173 | res = crypt_r(s, saltp, data); > | | ^~~~~~~ > | | crypt > | ../ruby-3.2.2/string.c:10173:9: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] > | 10173 | res = crypt_r(s, saltp, data); > | | ^ > > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 15:01 ` Alexander Kanavin @ 2023-05-28 15:08 ` Markus Volk 2023-05-28 15:16 ` Alexander Kanavin 0 siblings, 1 reply; 18+ messages in thread From: Markus Volk @ 2023-05-28 15:08 UTC (permalink / raw) To: Alexander Kanavin; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 227 bytes --] Am So, 28. Mai 2023 um 17:01:44 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > Thanks, then all three recipes should add libxcrypt to DEPENDS But wouldn't that lead to multiple virtual/crypt providers on musl ? [-- Attachment #2: Type: text/html, Size: 394 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 15:08 ` Markus Volk @ 2023-05-28 15:16 ` Alexander Kanavin 2023-05-29 7:08 ` Richard Purdie 0 siblings, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-05-28 15:16 UTC (permalink / raw) To: Markus Volk; +Cc: openembedded-core Adding libxcrypt-native to DEPENDS definitely isn't correct, so you could check why virtual/crypt dependency isn't working properly for adding the needed headers into native variant's sysroot. If all fails, adjust DEPENDS:append:class-native. Alex On Sun, 28 May 2023 at 17:08, Markus Volk <f_l_k@t-online.de> wrote: > > Am So, 28. Mai 2023 um 17:01:44 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > > Thanks, then all three recipes should add libxcrypt to DEPENDS > > > But wouldn't that lead to multiple virtual/crypt providers on musl ? ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-28 15:16 ` Alexander Kanavin @ 2023-05-29 7:08 ` Richard Purdie [not found] ` <ZG5FVR.L4YKBKAES08S3@googlemail.com> 0 siblings, 1 reply; 18+ messages in thread From: Richard Purdie @ 2023-05-29 7:08 UTC (permalink / raw) To: Alexander Kanavin, Markus Volk; +Cc: openembedded-core On Sun, 2023-05-28 at 17:16 +0200, Alexander Kanavin wrote: > Adding libxcrypt-native to DEPENDS definitely isn't correct, so you > could check why virtual/crypt dependency isn't working properly for > adding the needed headers into native variant's sysroot. If all fails, > adjust DEPENDS:append:class-native. Alex is right and I should have spotted this, the -native dependency definitely isn't right. We'll either need to fix things or revert them and wait for the right fix... Cheers, Richard ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <ZG5FVR.L4YKBKAES08S3@googlemail.com>]
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency [not found] ` <ZG5FVR.L4YKBKAES08S3@googlemail.com> @ 2023-05-29 12:34 ` Richard Purdie 2023-06-03 17:51 ` Markus Volk 0 siblings, 1 reply; 18+ messages in thread From: Richard Purdie @ 2023-05-29 12:34 UTC (permalink / raw) To: Markus Volk; +Cc: Alexander Kanavin, Markus Volk, openembedded-core On Mon, 2023-05-29 at 14:02 +0200, Markus Volk wrote: > Am Mo, 29. Mai 2023 um 08:08:09 +0100 schrieb Richard Purdie > <richard.purdie@linuxfoundation.org>: > > Alex is right and I should have spotted this, the -native > > dependency > > definitely isn't right. We'll either need to fix things or revert > > them > > and wait for the right fix... > > > Absolutely. I had a quick look at native.bbclass yesterday, but > haven't found a nice way to deal with this yet. This week I'm on > night shift and therefore have rather little time to deal with the > problem. I can send v2 patches which just add > > DEPENDS:append:class-native = " libxcrypt-native" > > But revert would also be fine for me, as this is more of a niche > problem I'm going to revert those changes and then we can work out the correct fix without any time pressures (and then I won't need to keep this on my 'need to do something about' mental checklist!). Cheers, Richard ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-05-29 12:34 ` Richard Purdie @ 2023-06-03 17:51 ` Markus Volk 2023-06-03 18:20 ` Alexander Kanavin 0 siblings, 1 reply; 18+ messages in thread From: Markus Volk @ 2023-06-03 17:51 UTC (permalink / raw) To: Richard Purdie; +Cc: Alexander Kanavin, Khem Raj, openembedded-core [-- Attachment #1: Type: text/plain, Size: 980 bytes --] Am Mo, 29. Mai 2023 um 13:34:40 +0100 schrieb Richard Purdie <richard.purdie@linuxfoundation.org>: > I'm going to revert those changes and then we can work out the correct > fix without any time pressures (and then I won't need to keep this on > my 'need to do something about' mental checklist!). I had some time to look at this problem. virtual/crypt-native is not installed into recipe-sysroot-native because of this entry in bitbake.conf: ASSUME_PROVIDED = "virtual/crypt-native" Removing the entry solved the issue for me. I could successfully build core-image-minimal for musl and glibc without crypt.h from host machine. But I don't know the reason why this is ASSUME_PROVIDED, so I'm unsure if this should even be touched. In a second step I created a musl-native recipe to be able to install musl crypt.h into recipe-sysroot-native, but I'm not sure if this is necessary either. <https://github.com/MarkusVolk/openembedded-core/commits/virtual/crypt-native> [-- Attachment #2: Type: text/html, Size: 1343 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-06-03 17:51 ` Markus Volk @ 2023-06-03 18:20 ` Alexander Kanavin 2023-06-04 19:53 ` Markus Volk 0 siblings, 1 reply; 18+ messages in thread From: Alexander Kanavin @ 2023-06-03 18:20 UTC (permalink / raw) To: Markus Volk; +Cc: Richard Purdie, Khem Raj, openembedded-core On Sat, 3 Jun 2023 at 19:52, Markus Volk <f_l_k@t-online.de> wrote: > I had some time to look at this problem. virtual/crypt-native is not installed into recipe-sysroot-native because of this entry in bitbake.conf: > ASSUME_PROVIDED = "virtual/crypt-native" > > Removing the entry solved the issue for me. I could successfully build core-image-minimal for musl and glibc without crypt.h from host machine. > > But I don't know the reason why this is ASSUME_PROVIDED, so I'm unsure if this should even be touched. > > In a second step I created a musl-native recipe to be able to install musl crypt.h into recipe-sysroot-native, but I'm not sure if this is necessary either. > > https://github.com/MarkusVolk/openembedded-core/commits/virtual/crypt-native I took a look; I believe this is by design, and for native recipes crypt.h does indeed need to be provided by the host distro, and not any of the recipes. This is where it was added: https://git.yoctoproject.org/poky/commit/?id=29f65bda6d2c Alex ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency 2023-06-03 18:20 ` Alexander Kanavin @ 2023-06-04 19:53 ` Markus Volk 0 siblings, 0 replies; 18+ messages in thread From: Markus Volk @ 2023-06-04 19:53 UTC (permalink / raw) To: Alexander Kanavin Cc: Markus Volk, Richard Purdie, Khem Raj, openembedded-core [-- Attachment #1: Type: text/plain, Size: 1217 bytes --] Thanks for the link Am Sa, 3. Jun 2023 um 20:20:48 +0200 schrieb Alexander Kanavin <alex.kanavin@gmail.com>: > On Sat, 3 Jun 2023 at 19:52, Markus Volk <f_l_k@t-online.de > <mailto:f_l_k@t-online.de>> wrote: >> I had some time to look at this problem. virtual/crypt-native is >> not installed into recipe-sysroot-native because of this entry in >> bitbake.conf: >> ASSUME_PROVIDED = "virtual/crypt-native" >> >> Removing the entry solved the issue for me. I could successfully >> build core-image-minimal for musl and glibc without crypt.h from >> host machine. >> >> But I don't know the reason why this is ASSUME_PROVIDED, so I'm >> unsure if this should even be touched. >> >> In a second step I created a musl-native recipe to be able to >> install musl crypt.h into recipe-sysroot-native, but I'm not sure if >> this is necessary either. >> >> >> <https://github.com/MarkusVolk/openembedded-core/commits/virtual/crypt-native> > > I took a look; I believe this is by design, and for native recipes > crypt.h does indeed need to be provided by the host distro, and not > any of the recipes. This is where it was added: > <https://git.yoctoproject.org/poky/commit/?id=29f65bda6d2c> > > Alex [-- Attachment #2: Type: text/html, Size: 1536 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* [oe-core][PATCH 3/4] ruby: add libxcrypt-native dependency 2023-05-27 13:32 [oe-core][PATCH 1/4] ell: upgrade 0.56 -> 0.57 Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency Markus Volk @ 2023-05-27 13:32 ` Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 4/4] shadow: " Markus Volk 2 siblings, 0 replies; 18+ messages in thread From: Markus Volk @ 2023-05-27 13:32 UTC (permalink / raw) To: openembedded-core; +Cc: Markus Volk crypt.h is otherwise taken from the host machine Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-devtools/ruby/ruby_3.2.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/ruby/ruby_3.2.2.bb b/meta/recipes-devtools/ruby/ruby_3.2.2.bb index 481fe7c23d..d1900bfa4b 100644 --- a/meta/recipes-devtools/ruby/ruby_3.2.2.bb +++ b/meta/recipes-devtools/ruby/ruby_3.2.2.bb @@ -13,7 +13,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5b8c87559868796979806100db3f3805 \ file://LEGAL;md5=bcd74b47bbaf2051c5e49811a5faa97a \ " -DEPENDS = "zlib openssl libyaml gdbm readline libffi" +DEPENDS = "zlib openssl libyaml gdbm readline libffi libxcrypt-native" DEPENDS:append:class-target = " ruby-native" DEPENDS:append:class-nativesdk = " ruby-native" -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [oe-core][PATCH 4/4] shadow: add libxcrypt-native dependency 2023-05-27 13:32 [oe-core][PATCH 1/4] ell: upgrade 0.56 -> 0.57 Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 3/4] ruby: " Markus Volk @ 2023-05-27 13:32 ` Markus Volk 2 siblings, 0 replies; 18+ messages in thread From: Markus Volk @ 2023-05-27 13:32 UTC (permalink / raw) To: openembedded-core; +Cc: Markus Volk crypt.h is otherwise taken from the host machine Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-extended/shadow/shadow.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/shadow/shadow.inc b/meta/recipes-extended/shadow/shadow.inc index cf05a3af93..7206bfdf02 100644 --- a/meta/recipes-extended/shadow/shadow.inc +++ b/meta/recipes-extended/shadow/shadow.inc @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c9a450b7be84eac23e6353efecb60b5b \ file://src/passwd.c;beginline=2;endline=30;md5=758c26751513b6795395275969dd3be1 \ " -DEPENDS = "virtual/crypt" +DEPENDS = "virtual/crypt libxcrypt-native" GITHUB_BASE_URI = "https://github.com/shadow-maint/shadow/releases" SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/${BP}.tar.gz \ -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-06-04 19:53 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-27 13:32 [oe-core][PATCH 1/4] ell: upgrade 0.56 -> 0.57 Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 2/4] python3: add libxcrypt-native dependency Markus Volk 2023-05-28 13:39 ` Alexander Kanavin 2023-05-28 13:56 ` Markus Volk [not found] ` <17635252DFD4EDDE.6918@lists.openembedded.org> 2023-05-28 13:41 ` Alexander Kanavin 2023-05-28 14:03 ` Markus Volk 2023-05-28 14:23 ` Alexander Kanavin 2023-05-28 14:53 ` Markus Volk 2023-05-28 15:01 ` Alexander Kanavin 2023-05-28 15:08 ` Markus Volk 2023-05-28 15:16 ` Alexander Kanavin 2023-05-29 7:08 ` Richard Purdie [not found] ` <ZG5FVR.L4YKBKAES08S3@googlemail.com> 2023-05-29 12:34 ` Richard Purdie 2023-06-03 17:51 ` Markus Volk 2023-06-03 18:20 ` Alexander Kanavin 2023-06-04 19:53 ` Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 3/4] ruby: " Markus Volk 2023-05-27 13:32 ` [oe-core][PATCH 4/4] shadow: " Markus Volk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).