Regression about go 1.18 + OE specific local patch

Regression about go 1.18 + OE specific local patch

[Chen, Qi]

[-- Attachment #1: Type: text/plain, Size: 2898 bytes --]

Hi All,

I met a regression after go was upgraded to 1.18+.
The problem can be reproduced by running `bitbake nativesdk-skopeo', with meta-virtualization added in bblayers.conf.
The error message is as below.

"""
<snip>
| HASH[build golang.org/x/text/unicode/norm]: "import \"golang.org/x/text/unicode/norm\"\n"
| HASH /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-skopeo/v
1.6.1+gitAUTOINC+3e2defd6d3-r0/git/src/import/vendor/github.com/pkg/errors/errors.go: 1b60ba5bcb417f0060d1c1fbc
edaa1a702020499094ce8134f8b45a58c0ebbff
| panic: runtime error: index out of range [0] with length 0
|
| goroutine 5129 [running]:
| cmd/go/internal/work.(*Builder).buildActionID(0xc0002490e0, 0xc000370b40)
|       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:281 +0x23cf
| cmd/go/internal/work.(*Builder).build(0xc0002490e0, {0xc000220000?, 0x0?}, 0xc000370b40)
|       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:476 +0x199
| cmd/go/internal/work.(*Builder).Do.func2({0xadd9f8, 0xc000220000}, 0xc000370b40)
|       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:139 +0x5ec
| cmd/go/internal/work.(*Builder).Do.func3()
|       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:201 +0xb9
| created by cmd/go/internal/work.(*Builder).Do
|       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:187 +0x3da
| Makefile:140: recipe for target 'bin/skopeo' failed
<snip>
"""

I did some investigation and found it was related to a local patch, 0001-cmd-go-make-content-based-hash-generation-less-pedan.patch.
The build succeeded after I dropped this patch.

I'm sending out this email to seek for some help, as I don't fully understand what this patch does.

e.g.
"""
+               if strings.HasPrefix(flag, "-m") {
+                       newflags = append(newflags, flag)
+               }
"""
This flag filtering is not explained in the commit message.

One more question: this patch applies to all go recipes, including go cross compilers and target go. But from its commit message, target go does not seem to need it.

Any suggestion?

Regards,
Qi



[-- Attachment #2: Type: text/html, Size: 6911 bytes --]

Re: [OE-core] Regression about go 1.18 + OE specific local patch

[Alexander Kanavin]

It is probably needed for reproducibility, can you run the repro test
with this patch dropped?

Alex

On Tue, 10 May 2022 at 11:09, Chen Qi <Qi.Chen@windriver.com> wrote:
>
> Hi All,
>
>
>
> I met a regression after go was upgraded to 1.18+.
>
> The problem can be reproduced by running `bitbake nativesdk-skopeo’, with meta-virtualization added in bblayers.conf.
>
> The error message is as below.
>
>
>
> “””
>
> <snip>
>
> | HASH[build golang.org/x/text/unicode/norm]: "import \"golang.org/x/text/unicode/norm\"\n"
>
> | HASH /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-skopeo/v
>
> 1.6.1+gitAUTOINC+3e2defd6d3-r0/git/src/import/vendor/github.com/pkg/errors/errors.go: 1b60ba5bcb417f0060d1c1fbc
>
> edaa1a702020499094ce8134f8b45a58c0ebbff
>
> | panic: runtime error: index out of range [0] with length 0
>
> |
>
> | goroutine 5129 [running]:
>
> | cmd/go/internal/work.(*Builder).buildActionID(0xc0002490e0, 0xc000370b40)
>
> |       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:281 +0x23cf
>
> | cmd/go/internal/work.(*Builder).build(0xc0002490e0, {0xc000220000?, 0x0?}, 0xc000370b40)
>
> |       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:476 +0x199
>
> | cmd/go/internal/work.(*Builder).Do.func2({0xadd9f8, 0xc000220000}, 0xc000370b40)
>
> |       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:139 +0x5ec
>
> | cmd/go/internal/work.(*Builder).Do.func3()
>
> |       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:201 +0xb9
>
> | created by cmd/go/internal/work.(*Builder).Do
>
> |       /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:187 +0x3da
>
> | Makefile:140: recipe for target 'bin/skopeo' failed
>
> <snip>
>
> “””
>
>
>
> I did some investigation and found it was related to a local patch, 0001-cmd-go-make-content-based-hash-generation-less-pedan.patch.
>
> The build succeeded after I dropped this patch.
>
>
>
> I’m sending out this email to seek for some help, as I don’t fully understand what this patch does.
>
>
>
> e.g.
>
> “””
>
> +               if strings.HasPrefix(flag, "-m") {
>
> +                       newflags = append(newflags, flag)
>
> +               }
>
> “””
>
> This flag filtering is not explained in the commit message.
>
>
>
> One more question: this patch applies to all go recipes, including go cross compilers and target go. But from its commit message, target go does not seem to need it.
>
>
>
> Any suggestion?
>
>
>
> Regards,
>
> Qi
>
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#165412): https://lists.openembedded.org/g/openembedded-core/message/165412
> Mute This Topic: https://lists.openembedded.org/mt/91008732/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] Regression about go 1.18 + OE specific local patch

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 4175 bytes --]

Hi Qi,

With patch in place I have seen some build issues mainly in
meta-virtualization
with ti am62xx-evm, am64xx-evm and riscv64 machines.
Propose to remove the patch as it seams to fix the issue and I don't see
any side effect after
testing it in some weeks.

https://lists.openembedded.org/g/openembedded-core/message/171233

Chen Qi <Qi.Chen@windriver.com> escreveu no dia terça, 10/05/2022 à(s)
10:09:

> Hi All,
>
>
>
> I met a regression after go was upgraded to 1.18+.
>
> The problem can be reproduced by running `bitbake nativesdk-skopeo’, with
> meta-virtualization added in bblayers.conf.
>
> The error message is as below.
>
>
>
> “””
>
> <snip>
>
> | HASH[build golang.org/x/text/unicode/norm]: "import \"
> golang.org/x/text/unicode/norm\ <http://golang.org/x/text/unicode/norm%5C>
> "\n"
>
> | HASH
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-skopeo/v
>
> 1.6.1+gitAUTOINC+3e2defd6d3-r0/git/src/import/vendor/
> github.com/pkg/errors/errors.go: 1b60ba5bcb417f0060d1c1fbc
>
> edaa1a702020499094ce8134f8b45a58c0ebbff
>
> | panic: runtime error: index out of range [0] with length 0
>
> |
>
> | goroutine 5129 [running]:
>
> | cmd/go/internal/work.(*Builder).buildActionID(0xc0002490e0, 0xc000370b40)
>
> |
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:281
> +0x23cf
>
> | cmd/go/internal/work.(*Builder).build(0xc0002490e0, {0xc000220000?,
> 0x0?}, 0xc000370b40)
>
> |
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.
>
> 18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:476
> +0x199
>
> | cmd/go/internal/work.(*Builder).Do.func2({0xadd9f8, 0xc000220000},
> 0xc000370b40)
>
> |
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:139
> +0x5ec
>
> | cmd/go/internal/work.(*Builder).Do.func3()
>
> |
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:201
> +0xb9
>
> | created by cmd/go/internal/work.(*Builder).Do
>
> |
> /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/work/x86_64-linux/go-crosssdk-x86_64-pokysdk-linux/1.18.1-r0/recipe-sysroot-native/usr/lib/x86_64-pokysdk-linux/go/src/cmd/go/internal/work/exec.go:187
> +0x3da
>
> | Makefile:140: recipe for target 'bin/skopeo' failed
>
> <snip>
>
> “””
>
>
>
> I did some investigation and found it was related to a local patch,
> 0001-cmd-go-make-content-based-hash-generation-less-pedan.patch.
>
> The build succeeded after I dropped this patch.
>
>
>
> I’m sending out this email to seek for some help, as I don’t fully
> understand what this patch does.
>
>
>
> e.g.
>
> “””
>
> +               if strings.HasPrefix(flag, "-m") {
>
> +                       newflags = append(newflags, flag)
>
> +               }
>
> “””
>
> This flag filtering is not explained in the commit message.
>
>
>
> One more question: this patch applies to all go recipes, including go
> cross compilers and target go. But from its commit message, target go does
> not seem to need it.
>
>
>
> Any suggestion?
>
>
>
> Regards,
>
> Qi
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#165412):
> https://lists.openembedded.org/g/openembedded-core/message/165412
> Mute This Topic: https://lists.openembedded.org/mt/91008732/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 7577 bytes --]