From: Bruno Moreira-Guedes <codeagain@codeagain.dev>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
Bruno's Patch Watchbox <patch-reply@codeagain.dev>
Subject: [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig
Date: Mon, 18 Apr 2022 20:31:09 -0300 [thread overview]
Message-ID: <00de5644d7c2f8c8878eccf86b761e0602732080.1650321310.git.codeagain@codeagain.dev> (raw)
In-Reply-To: <cover.1650321310.git.codeagain@codeagain.dev>
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
VME_BUS, which is unnoticeable for menuconfig users who aren't be able
to select it through this interface without setting the CONFIG_VME_BUS
option because it's nested on VME_BUS menu entry.
A patch to move appropriately this driver to the "Staging" submenu
([PATCH 1/3], originally sent as a single patch submitted at
https://lore.kernel.org/linux-staging/3fbc5325e94b9ae0666a1f5a56a4e5372bfcea1d.camel@codeagain.dev/T/#t),
however, unveiled this missing `depends on` line, since it moved the
`source` line for VME_USER's KConfig to somewhere else, allowing it to
be compiled without the support for VME_BUS. While it compiles fine and
seems to initialize the driver fine (tested both as module and as built-
in), it seems to make no sense having VME_USER without VME_BUS.
This patches addresses it by adding the VME_BUS to the `depends on` line
at "drivers/staging/vme/devices/Kconfig".
Signed-off-by: Bruno Moreira-Guedes <codeagain@codeagain.dev>
---
drivers/staging/vme/devices/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig
index 5651bb16b28b..e8b4461bf27f 100644
--- a/drivers/staging/vme/devices/Kconfig
+++ b/drivers/staging/vme/devices/Kconfig
@@ -3,7 +3,7 @@ comment "VME Device Drivers"
config VME_USER
tristate "VME user space access driver"
- depends on STAGING
+ depends on STAGING && VME_BUS
help
If you say Y here you want to be able to access a limited number of
VME windows in a manner at least semi-compatible with the interface
--
2.35.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-04-18 23:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:29 [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Bruno Moreira-Guedes
2022-04-18 23:30 ` [PATCH v3 1/3] staging: vme: Move vme_user to staging KConfig Bruno Moreira-Guedes
2022-04-18 23:31 ` Bruno Moreira-Guedes [this message]
2022-04-18 23:39 ` [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig Bruno Moreira-Guedes
2022-04-20 16:43 ` Greg Kroah-Hartman
2022-04-20 21:12 ` Bruno Moreira-Guedes
2022-04-21 6:07 ` Greg Kroah-Hartman
2022-04-18 23:31 ` [PATCH v3 3/3] staging: vme: Move 'vme/devices' to 'vme_user/' Bruno Moreira-Guedes
2022-04-18 23:35 ` [PATCH v3 2/3] staging: vme: Add VME_BUS dependency to Kconfig Bruno Moreira-Guedes
2022-04-20 16:43 ` [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Greg Kroah-Hartman
2022-04-21 19:16 ` Martyn Welch
2022-04-22 6:39 ` Greg Kroah-Hartman
2022-04-27 12:18 ` Bruno Moreira-Guedes
2022-04-27 12:31 ` Greg Kroah-Hartman
2022-04-27 12:41 ` Bruno Moreira-Guedes
2022-04-27 13:10 ` Greg Kroah-Hartman
2022-04-27 16:16 ` Alison Schofield
2022-04-20 22:35 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00de5644d7c2f8c8878eccf86b761e0602732080.1650321310.git.codeagain@codeagain.dev \
--to=codeagain@codeagain.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=patch-reply@codeagain.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).