From: Bruno Moreira-Guedes <codeagain@codeagain.dev>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
Bruno's Patch Watchbox <patch-reply@codeagain.dev>
Subject: [PATCH v3 3/3] staging: vme: Move 'vme/devices' to 'vme_user/'
Date: Mon, 18 Apr 2022 20:31:47 -0300 [thread overview]
Message-ID: <2cd7de9a426c443a5ea618682d605ecfd751d798.1650321310.git.codeagain@codeagain.dev> (raw)
In-Reply-To: <cover.1650321310.git.codeagain@codeagain.dev>
[-- Attachment #1: Type: text/plain, Size: 4514 bytes --]
In <db3b9e990e75573402cda22faf933760f076c033> ("Staging: VME: move VME
drivers out of staging") the vme code, board and bridge drivers were
moved out of the staging tree, remaining only the VME user device
driver.
Since this driver is the only one remaining in staging, such multi-level
structure confuses more than helps. The current structure is as follows:
- drivers/staging/vme/
Makefile
devices/
Kconfig
Makefile
vme_user.c
vme_user.h
The top-level Makefile has the only function of calling another Makefile
into the devices/ subdirectory. This latter only compiles the vme_user
driver, since there is no other in the staging tree.
This patch removes the unnecessary Makefile from the 'vme/' dir, move
the contents of 'vme/devices' into the 'vme/' dir, and renames it to
'vme_user/' (the driver name), allowing a straightforward understanding
of this driver's contents. Furthermore, it updates the MAINTAINERS file
to properly reflect the new paths.
Signed-off-by: Bruno Moreira-Guedes <codeagain@codeagain.dev>
---
MAINTAINERS | 2 +-
drivers/staging/Kconfig | 3 +--
drivers/staging/Makefile | 2 +-
drivers/staging/vme/Makefile | 2 --
drivers/staging/{vme/devices => vme_user}/Kconfig | 0
drivers/staging/{vme/devices => vme_user}/Makefile | 0
drivers/staging/{vme/devices => vme_user}/vme_user.c | 0
drivers/staging/{vme/devices => vme_user}/vme_user.h | 0
8 files changed, 3 insertions(+), 6 deletions(-)
delete mode 100644 drivers/staging/vme/Makefile
rename drivers/staging/{vme/devices => vme_user}/Kconfig (100%)
rename drivers/staging/{vme/devices => vme_user}/Makefile (100%)
rename drivers/staging/{vme/devices => vme_user}/vme_user.c (100%)
rename drivers/staging/{vme/devices => vme_user}/vme_user.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3ed62dcd144e..efc38961f792 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21010,7 +21010,7 @@ L: linux-kernel@vger.kernel.org
S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
F: Documentation/driver-api/vme.rst
-F: drivers/staging/vme/
+F: drivers/staging/vme_user/
F: drivers/vme/
F: include/linux/vme*
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index e4dcf411030d..e117811ec832 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -86,7 +86,6 @@ source "drivers/staging/fieldbus/Kconfig"
source "drivers/staging/qlge/Kconfig"
-
-source "drivers/staging/vme/devices/Kconfig"
+source "drivers/staging/vme_user/Kconfig"
endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 65e317922e3f..db7287de0faf 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -14,7 +14,7 @@ obj-$(CONFIG_OCTEON_ETHERNET) += octeon/
obj-$(CONFIG_OCTEON_USB) += octeon-usb/
obj-$(CONFIG_VT6655) += vt6655/
obj-$(CONFIG_VT6656) += vt6656/
-obj-$(CONFIG_VME_BUS) += vme/
+obj-$(CONFIG_VME_BUS) += vme_user/
obj-$(CONFIG_IIO) += iio/
obj-$(CONFIG_FB_SM750) += sm750fb/
obj-$(CONFIG_USB_EMXX) += emxx_udc/
diff --git a/drivers/staging/vme/Makefile b/drivers/staging/vme/Makefile
deleted file mode 100644
index cf2f686ccffe..000000000000
--- a/drivers/staging/vme/Makefile
+++ /dev/null
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-y += devices/
diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme_user/Kconfig
similarity index 100%
rename from drivers/staging/vme/devices/Kconfig
rename to drivers/staging/vme_user/Kconfig
diff --git a/drivers/staging/vme/devices/Makefile b/drivers/staging/vme_user/Makefile
similarity index 100%
rename from drivers/staging/vme/devices/Makefile
rename to drivers/staging/vme_user/Makefile
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme_user/vme_user.c
similarity index 100%
rename from drivers/staging/vme/devices/vme_user.c
rename to drivers/staging/vme_user/vme_user.c
diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme_user/vme_user.h
similarity index 100%
rename from drivers/staging/vme/devices/vme_user.h
rename to drivers/staging/vme_user/vme_user.h
--
2.35.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-04-18 23:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:29 [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Bruno Moreira-Guedes
2022-04-18 23:30 ` [PATCH v3 1/3] staging: vme: Move vme_user to staging KConfig Bruno Moreira-Guedes
2022-04-18 23:31 ` [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig Bruno Moreira-Guedes
2022-04-18 23:39 ` Bruno Moreira-Guedes
2022-04-20 16:43 ` Greg Kroah-Hartman
2022-04-20 21:12 ` Bruno Moreira-Guedes
2022-04-21 6:07 ` Greg Kroah-Hartman
2022-04-18 23:31 ` Bruno Moreira-Guedes [this message]
2022-04-18 23:35 ` [PATCH v3 " Bruno Moreira-Guedes
2022-04-20 16:43 ` [PATCH v3 0/3] staging: vme: Cleanup driver tree old structures Greg Kroah-Hartman
2022-04-21 19:16 ` Martyn Welch
2022-04-22 6:39 ` Greg Kroah-Hartman
2022-04-27 12:18 ` Bruno Moreira-Guedes
2022-04-27 12:31 ` Greg Kroah-Hartman
2022-04-27 12:41 ` Bruno Moreira-Guedes
2022-04-27 13:10 ` Greg Kroah-Hartman
2022-04-27 16:16 ` Alison Schofield
2022-04-20 22:35 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd7de9a426c443a5ea618682d605ecfd751d798.1650321310.git.codeagain@codeagain.dev \
--to=codeagain@codeagain.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=patch-reply@codeagain.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).