* [PATCH v6] staging: vt6655: Remove unused function
@ 2024-03-16 17:38 Dorine Tipo
2024-03-16 18:29 ` Fabio M. De Francesco
0 siblings, 1 reply; 2+ messages in thread
From: Dorine Tipo @ 2024-03-16 17:38 UTC (permalink / raw)
To: gregkh, forest, linux-staging, outreachy
Cc: Dorine Tipo, julia.lawall, dan.carpenter, philipp.g.hortmann
Remove unused function RFbAL7230SelectChannelPostProcess declared in
rf.h but has no associated implementation.
Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
accidentally forgot to delete the declaration in the header file.
Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changes since V1:
V2: - Removed the unintended blank line after removing the dead code
- Removed "in rf.h" from the subject
V3: - Added in the Description Comment about unintended blank line
V4: - Adjusted complete description according to hint from feedback
- Rebased patch
V5: - Added a missing closing parenthesis in the fixes tag
V6: - Sent the wrong patch for v5. This version includes the fix in v5
drivers/staging/vt6655/rf.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 6f842ac00526..8eef100c7ef2 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
long *pldBm);
-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
-/* }} RobertYu */
-
#endif /* __RF_H__ */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v6] staging: vt6655: Remove unused function
2024-03-16 17:38 [PATCH v6] staging: vt6655: Remove unused function Dorine Tipo
@ 2024-03-16 18:29 ` Fabio M. De Francesco
0 siblings, 0 replies; 2+ messages in thread
From: Fabio M. De Francesco @ 2024-03-16 18:29 UTC (permalink / raw)
To: Dorine Tipo
Cc: gregkh, forest, linux-staging, outreachy, Dorine Tipo,
julia.lawall, dan.carpenter, philipp.g.hortmann
On Saturday, 16 March 2024 18:38:35 CET Dorine Tipo wrote:
> Remove unused function RFbAL7230SelectChannelPostProcess declared in
> rf.h but has no associated implementation.
>
> Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
> accidentally forgot to delete the declaration in the header file.
>
> Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
Make your "Subject" line more unique. Think that we may end up with having
dozen of commits like yours, all of them referring to different removals and
all without the necessary information to tell what they differ in (except
the driver/subsystem).
I'd rewrite it either as "Remove unused declaration of
RFbAL7230SelectChannelPostProcess()" if you want to make it clear that you
are only removing the declaration (not also the definition) or, more briefly,
as "Remove unused RFbAL7230SelectChannelPostProcess()".
There is no need for "function", since it is made clear by the parentheses
after the symbol.
Thanks,
Fabio
> Changes since V1:
>
> V2: - Removed the unintended blank line after removing the dead code
> - Removed "in rf.h" from the subject
>
> V3: - Added in the Description Comment about unintended blank line
>
> V4: - Adjusted complete description according to hint from feedback
> - Rebased patch
> V5: - Added a missing closing parenthesis in the fixes tag
>
> V6: - Sent the wrong patch for v5. This version includes the fix in v5
>
> drivers/staging/vt6655/rf.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..8eef100c7ef2 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned
> char byPwr, void RFvRSSITodBm(struct vnt_private *priv, unsigned char
> byCurrRSSI, long *pldBm);
>
> -/* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16
> byOldChannel, u16 byNewChannel); -/* }} RobertYu */
> -
> #endif /* __RF_H__ */
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-16 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-16 17:38 [PATCH v6] staging: vt6655: Remove unused function Dorine Tipo
2024-03-16 18:29 ` Fabio M. De Francesco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).