Outreachy

Outreachy

[Menna Mahmoud]

Hi Mentors,


I am Menna, Outreachy applicant and I work on my clean-up patches.

Is it Okay to work on this error reported by checkpatch script?


drivers/staging/iio/frequency/ad9832.c
--------------------------------------
ERROR: Use 4 digit octal (0777) not decimal permissions
#256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
+static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
ERROR: Use 4 digit octal (0777) not decimal permissions
#257: FILE: drivers/staging/iio/frequency/ad9832.c:257:
+static IIO_DEV_ATTR_FREQSYMBOL(0, 0200, NULL, ad9832_write, 
AD9832_FREQ_SYM);
ERROR: Use 4 digit octal (0777) not decimal permissions
#260: FILE: drivers/staging/iio/frequency/ad9832.c:260:
+static IIO_DEV_ATTR_PHASE(0, 0, 0200, NULL, ad9832_write, AD9832_PHASE0H);
ERROR: Use 4 digit octal (0777) not decimal permissions
#261: FILE: drivers/staging/iio/frequency/ad9832.c:261:
+static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9832_write, AD9832_PHASE1H);
ERROR: Use 4 digit octal (0777) not decimal permissions
#262: FILE: drivers/staging/iio/frequency/ad9832.c:262:
+static IIO_DEV_ATTR_PHASE(0, 2, 0200, NULL, ad9832_write, AD9832_PHASE2H);
ERROR: Use 4 digit octal (0777) not decimal permissions
#263: FILE: drivers/staging/iio/frequency/ad9832.c:263:
+static IIO_DEV_ATTR_PHASE(0, 3, 0200, NULL, ad9832_write, AD9832_PHASE3H);
ERROR: Use 4 digit octal (0777) not decimal permissions
#264: FILE: drivers/staging/iio/frequency/ad9832.c:264:
+static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL,
+                ad9832_write, AD9832_PHASE_SYM);
ERROR: Use 4 digit octal (0777) not decimal permissions
#268: FILE: drivers/staging/iio/frequency/ad9832.c:268:
+static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL,
+                ad9832_write, AD9832_PINCTRL_EN);
ERROR: Use 4 digit octal (0777) not decimal permissions
#270: FILE: drivers/staging/iio/frequency/ad9832.c:270:
+static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL,
+                ad9832_write, AD9832_OUTPUT_EN);
total: 9 errors, 0 warnings, 0 checks, 462 lines checked



Thanks in advance,

Menna

Re: Outreachy

[Dan Carpenter]

On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
> Hi Mentors,
> 
> 
> I am Menna, Outreachy applicant and I work on my clean-up patches.
> 
> Is it Okay to work on this error reported by checkpatch script?
> 
> 
> drivers/staging/iio/frequency/ad9832.c
> --------------------------------------
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);

What???  Is it complaining about the 0200?  That is octal.  Why is
checkpatch complaining about this?  Am I wrong?  Maybe I am misreading.

I could investigate, but I am leaving that task to you.  It may be that
checkpatch has a problem and you can fix that instead.

regards,
dan carpenter

Re: Outreachy

[Randy Dunlap]

On 3/15/23 07:03, Dan Carpenter wrote:
> On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
>> Hi Mentors,
>>
>>
>> I am Menna, Outreachy applicant and I work on my clean-up patches.
>>
>> Is it Okay to work on this error reported by checkpatch script?
>>
>>
>> drivers/staging/iio/frequency/ad9832.c
>> --------------------------------------
>> ERROR: Use 4 digit octal (0777) not decimal permissions
>> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
>> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
> 
> What???  Is it complaining about the 0200?  That is octal.  Why is
> checkpatch complaining about this?  Am I wrong?  Maybe I am misreading.
> 
> I could investigate, but I am leaving that task to you.  It may be that
> checkpatch has a problem and you can fix that instead.
> 

Yes, checkpatch seems to be confused here.

-- 
~Randy

Re: Outreachy

[Lars-Peter Clausen]

On 3/15/23 12:24, Randy Dunlap wrote:
>
> On 3/15/23 07:03, Dan Carpenter wrote:
>> On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
>>> Hi Mentors,
>>>
>>>
>>> I am Menna, Outreachy applicant and I work on my clean-up patches.
>>>
>>> Is it Okay to work on this error reported by checkpatch script?
>>>
>>>
>>> drivers/staging/iio/frequency/ad9832.c
>>> --------------------------------------
>>> ERROR: Use 4 digit octal (0777) not decimal permissions
>>> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
>>> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
>> What???  Is it complaining about the 0200?  That is octal.  Why is
>> checkpatch complaining about this?  Am I wrong?  Maybe I am misreading.
>>
>> I could investigate, but I am leaving that task to you.  It may be that
>> checkpatch has a problem and you can fix that instead.
>>
> Yes, checkpatch seems to be confused here.
It seems to make an assumption that everything starting with 
IIO_DEV_ATTR_ has the mode field at the same position. Which is not the 
case.

https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl#L798

Still a good target to get this fixed as part of a outreachy task.

Re: Outreachy

[Menna Mahmoud]

On ١٥‏/٣‏/٢٠٢٣ ٢٢:٠٩, Lars-Peter Clausen wrote:
> On 3/15/23 12:24, Randy Dunlap wrote:
>>
>> On 3/15/23 07:03, Dan Carpenter wrote:
>>> On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
>>>> Hi Mentors,
>>>>
>>>>
>>>> I am Menna, Outreachy applicant and I work on my clean-up patches.
>>>>
>>>> Is it Okay to work on this error reported by checkpatch script?
>>>>
>>>>
>>>> drivers/staging/iio/frequency/ad9832.c
>>>> --------------------------------------
>>>> ERROR: Use 4 digit octal (0777) not decimal permissions
>>>> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
>>>> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, 
>>>> AD9832_FREQ1HM);
>>> What???  Is it complaining about the 0200?  That is octal. Why is
>>> checkpatch complaining about this?  Am I wrong?  Maybe I am misreading.
>>>
>>> I could investigate, but I am leaving that task to you.  It may be that
>>> checkpatch has a problem and you can fix that instead.
>>>
>> Yes, checkpatch seems to be confused here.
> It seems to make an assumption that everything starting with 
> IIO_DEV_ATTR_ has the mode field at the same position. Which is not 
> the case.
>
> https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl#L798
>
> Still a good target to get this fixed as part of a outreachy task.


I see, Thanks Randy and Lars-Peter for your help I will try check this.

Re: Outreachy

[Alison Schofield]

On Tue, Mar 07, 2023 at 02:25:29PM +0200, Menna Mahmoud wrote:
> Hi there am Menna an Outreachy applicant,right now am working on my first patch. happy to be part of this community.
> 
> Thanks,
> 
> Menna
> 
>
Hi Menna,

Welcome to the Linux Kernel Community!

Alison

Outreachy

[Menna Mahmoud]

Hi there am Menna an Outreachy applicant,right now am working on my first patch. happy to be part of this community.

Thanks,

Menna

Re: outreachy

[Georgiana Chelu]

[-- Attachment #1.1: Type: text/plain, Size: 540 bytes --]

Hello,

My choice is IIO driver.

Georgiana
 
On Friday, 30 September 2016 23:40:12 UTC+3, Julia Lawall wrote:
>
> Hello, 
>
> We are around the halfway mark of the application period. 
>
> So that I can get an overview of the current interests of the applicants, 
> could you send me a list of your current first and second project choices? 
> It's OK to change your mind later, but I would like to know what everyone 
> is thinking about now. 
>
> Please do this even if you don't yet have many accepted patches. 
>
> thanks, 
> julia 
>

[-- Attachment #1.2: Type: text/html, Size: 747 bytes --]

Re: outreachy

[Namrata A Shettar]

[-- Attachment #1.1: Type: text/plain, Size: 205 bytes --]


Hi,
    My first two choices  are :
 
    1) nftables ( Mentor : Pablo Neira Ayuso )

    2) Coccinelle ( Mentor : Julia Lawall )

    I haven't completely ruled out the other projects!

Thanks!

namrata

[-- Attachment #1.2: Type: text/html, Size: 283 bytes --]

Re: outreachy

[Bhumika Goyal]

[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]

Hey Julia,
My top two choices are:
1. Coccinelle
2. radix tree __alloc_fd

Thanks,
Bhumika

On Saturday, October 1, 2016 at 2:10:12 AM UTC+5:30, Julia Lawall wrote:
>
> Hello, 
>
> We are around the halfway mark of the application period. 
>
> So that I can get an overview of the current interests of the applicants, 
> could you send me a list of your current first and second project choices? 
> It's OK to change your mind later, but I would like to know what everyone 
> is thinking about now. 
>
> Please do this even if you don't yet have many accepted patches. 
>
> thanks, 
> julia 
>

[-- Attachment #1.2: Type: text/html, Size: 792 bytes --]

Re: outreachy

[keila novo]

[-- Attachment #1.1: Type: text/plain, Size: 624 bytes --]



El viernes, 30 de septiembre de 2016, 22:40:12 (UTC+2), Julia Lawall 
escribió:
>
> Hello, 
>
> We are around the halfway mark of the application period. 
>
> So that I can get an overview of the current interests of the applicants, 
> could you send me a list of your current first and second project choices? 
> It's OK to change your mind later, but I would like to know what everyone 
> is thinking about now. 
>
> Please do this even if you don't yet have many accepted patches. 
>
> thanks, 
> julia 
>


 Hi Julia,

My first two choices are:
1. Coccinelle
2.IIO driver.

Thanks,
Keila

[-- Attachment #1.2: Type: text/html, Size: 905 bytes --]

Re: outreachy

[Rehas Sachdeva]

[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]

Hi Julia,

My first two choices are:

1. radix tree __alloc_fd.
2. Coccinelle.

Thanks
Rehas

On Saturday, October 1, 2016 at 2:10:12 AM UTC+5:30, Julia Lawall wrote:
>
> Hello, 
>
> We are around the halfway mark of the application period. 
>
> So that I can get an overview of the current interests of the applicants, 
> could you send me a list of your current first and second project choices? 
> It's OK to change your mind later, but I would like to know what everyone 
> is thinking about now. 
>
> Please do this even if you don't yet have many accepted patches. 
>
> thanks, 
> julia 
>

[-- Attachment #1.2: Type: text/html, Size: 879 bytes --]

outreachy

[Julia Lawall]

Hello,

We are around the halfway mark of the application period.

So that I can get an overview of the current interests of the applicants,
could you send me a list of your current first and second project choices?
It's OK to change your mind later, but I would like to know what everyone
is thinking about now.

Please do this even if you don't yet have many accepted patches.

thanks,
julia