From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
bigeasy@linutronix.de, joel@joelfernandes.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [RFC PATCH v2 2/5] tracing: Save the last hist command's associated event name
Date: Wed, 13 Feb 2019 12:17:53 -0600 [thread overview]
Message-ID: <8a38aaa21424c23f225c8d2b1e77f0c0a07f7ffd.1550074795.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1550074795.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1550074795.git.tom.zanussi@linux.intel.com>
From: Tom Zanussi <tom.zanussi@linux.intel.com>
In preparation for making use of the new trace error log, save the
subsystem and event name associated with the last hist command - it
will be passed as the location param in the event_log_err() calls.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
kernel/trace/trace_events_hist.c | 33 +++++++++++++++++++++++++++------
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 4064e355878c..3e8addebc7be 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -536,15 +536,34 @@ static struct track_data *track_data_alloc(unsigned int key_len,
return data;
}
-static char last_hist_cmd[MAX_FILTER_STR_VAL];
+static char last_cmd[MAX_FILTER_STR_VAL];
+static char last_cmd_loc[MAX_FILTER_STR_VAL];
+
static char hist_err_str[MAX_FILTER_STR_VAL];
-static void last_cmd_set(char *str)
+static void last_cmd_set(struct trace_event_file *file, char *str)
{
+ const char *system = NULL, *name = NULL;
+ struct trace_event_call *call;
+
if (!str)
return;
- strncpy(last_hist_cmd, str, MAX_FILTER_STR_VAL - 1);
+ strncpy(last_cmd, str, MAX_FILTER_STR_VAL - 1);
+
+ if (file) {
+ call = file->event_call;
+
+ system = call->class->system;
+ if (system) {
+ name = trace_event_name(call);
+ if (!name)
+ system = NULL;
+ }
+ }
+
+ if (system)
+ snprintf(last_cmd_loc, MAX_FILTER_STR_VAL, "hist:%s:%s", system, name);
}
static void hist_err(char *str, char *var)
@@ -584,6 +603,8 @@ static void hist_err_event(char *str, char *system, char *event, char *var)
static void hist_err_clear(void)
{
hist_err_str[0] = '\0';
+ last_cmd[0] = '\0';
+ last_cmd_loc[0] = '\0';
}
static bool have_hist_err(void)
@@ -5440,8 +5461,8 @@ static int hist_show(struct seq_file *m, void *v)
}
if (have_hist_err()) {
- seq_printf(m, "\nERROR: %s\n", hist_err_str);
- seq_printf(m, " Last command: %s\n", last_hist_cmd);
+ seq_printf(m, "\n%s: error: \n", hist_err_str);
+ seq_printf(m, " Last command: %s\n", last_cmd);
}
out_unlock:
@@ -6045,8 +6066,8 @@ static int event_hist_trigger_func(struct event_command *cmd_ops,
lockdep_assert_held(&event_mutex);
if (glob && strlen(glob)) {
- last_cmd_set(param);
hist_err_clear();
+ last_cmd_set(file, param);
}
if (!param)
--
2.14.1
next prev parent reply other threads:[~2019-02-13 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 18:17 [RFC PATCH v2 0/5] tracing: common error_log for ftrace Tom Zanussi
2019-02-13 18:17 ` [RFC PATCH v2 1/5] tracing: Add tracing error log Tom Zanussi
2019-02-13 18:17 ` Tom Zanussi [this message]
2019-02-13 18:17 ` [RFC PATCH v2 3/5] tracing: Use tracing error_log with hist triggers Tom Zanussi
2019-02-13 18:17 ` [RFC PATCH v2 4/5] tracing: Use tracing error_log with kprobe events (incomplete) Tom Zanussi
2019-02-14 3:13 ` Masami Hiramatsu
2019-02-14 15:16 ` Tom Zanussi
2019-02-13 18:17 ` [RFC PATCH v2 5/5] tracing: Use tracing error_log with trace event filters Tom Zanussi
2019-02-13 18:27 ` [RFC PATCH v2 0/5] tracing: common error_log for ftrace Steven Rostedt
2019-02-14 3:13 ` Masami Hiramatsu
2019-02-14 15:15 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a38aaa21424c23f225c8d2b1e77f0c0a07f7ffd.1550074795.git.tom.zanussi@linux.intel.com \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).