From: daniel.baluta@nxp.com
To: jassisinghbrar@gmail.com, o.rempel@pengutronix.de
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: [RFC PATCH 1/2] mailbox: imx: Clear GIEn bit at shutdown
Date: Mon, 10 Jun 2019 22:16:08 +0800 [thread overview]
Message-ID: <20190610141609.17559-2-daniel.baluta@nxp.com> (raw)
In-Reply-To: <20190610141609.17559-1-daniel.baluta@nxp.com>
From: Daniel Baluta <daniel.baluta@nxp.com>
GIEn is enabled at startup for RX doorbell mailboxes so
we need to clear the bit at shutdown in order to avoid
leaving the interrupt line enabled.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
drivers/mailbox/imx-mailbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 25be8bb5e371..9f74dee1a58c 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -217,8 +217,8 @@ static void imx_mu_shutdown(struct mbox_chan *chan)
if (cp->type == IMX_MU_TYPE_TXDB)
tasklet_kill(&cp->txdb_tasklet);
- imx_mu_xcr_rmw(priv, 0,
- IMX_MU_xCR_TIEn(cp->idx) | IMX_MU_xCR_RIEn(cp->idx));
+ imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx) |
+ IMX_MU_xCR_RIEn(cp->idx) | IMX_MU_xCR_GIEn(cp->idx));
free_irq(priv->irq, chan);
}
--
2.17.1
next prev parent reply other threads:[~2019-06-10 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 14:16 [RFC PATCH 0/2] Introduce Tx doorbell with ACK daniel.baluta
2019-06-10 14:16 ` daniel.baluta [this message]
2019-06-11 4:33 ` [RFC PATCH 1/2] mailbox: imx: Clear GIEn bit at shutdown Oleksij Rempel
2019-06-10 14:16 ` [RFC PATCH 2/2] imx: mailbox: Introduce TX doorbell with ACK daniel.baluta
2019-06-11 5:55 ` Oleksij Rempel
2019-06-11 7:52 ` Daniel Baluta
2019-06-11 8:40 ` Oleksij Rempel
2019-06-12 6:51 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610141609.17559-2-daniel.baluta@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).