From: Saravana Kannan <saravanak@google.com>
To: Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Saravana Kannan <saravanak@google.com>,
Stephen Boyd <sboyd@kernel.org>,
kernel-team@android.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: [PATCH v1 1/3] of: property: Minor code formatting/style clean ups
Date: Fri, 11 Oct 2019 12:15:19 -0700 [thread overview]
Message-ID: <20191011191521.179614-2-saravanak@google.com> (raw)
In-Reply-To: <20191011191521.179614-1-saravanak@google.com>
Better variable and function names. Remove "," after the sentinel in an
array initialization list.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/of/property.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 923d6f88a99c..6f6e1d9644cf 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1147,11 +1147,11 @@ struct supplier_bindings {
const char *prop_name, int index);
};
-static const struct supplier_bindings bindings[] = {
+static const struct supplier_bindings of_supplier_bindings[] = {
{ .parse_prop = parse_clocks, },
{ .parse_prop = parse_interconnects, },
{ .parse_prop = parse_regulators, },
- {},
+ {}
};
/**
@@ -1177,7 +1177,7 @@ static int of_link_property(struct device *dev, struct device_node *con_np,
const char *prop_name)
{
struct device_node *phandle;
- const struct supplier_bindings *s = bindings;
+ const struct supplier_bindings *s = of_supplier_bindings;
unsigned int i = 0;
bool matched = false;
int ret = 0;
@@ -1196,7 +1196,7 @@ static int of_link_property(struct device *dev, struct device_node *con_np,
return ret;
}
-static int __of_link_to_suppliers(struct device *dev,
+static int of_link_to_suppliers(struct device *dev,
struct device_node *con_np)
{
struct device_node *child;
@@ -1208,7 +1208,7 @@ static int __of_link_to_suppliers(struct device *dev,
ret = -EAGAIN;
for_each_child_of_node(con_np, child)
- if (__of_link_to_suppliers(dev, child))
+ if (of_link_to_suppliers(dev, child))
ret = -EAGAIN;
return ret;
@@ -1226,7 +1226,7 @@ static int of_fwnode_add_links(const struct fwnode_handle *fwnode,
if (unlikely(!is_of_node(fwnode)))
return 0;
- return __of_link_to_suppliers(dev, to_of_node(fwnode));
+ return of_link_to_suppliers(dev, to_of_node(fwnode));
}
const struct fwnode_operations of_fwnode_ops = {
--
2.23.0.700.g56cf767bdb-goog
next prev parent reply other threads:[~2019-10-11 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 19:15 [PATCH v1 0/3] Documentation/minor coding style fix ups Saravana Kannan
2019-10-11 19:15 ` Saravana Kannan [this message]
2019-10-15 12:04 ` [PATCH v1 1/3] of: property: Minor code formatting/style clean ups Rob Herring
2019-10-11 19:15 ` [PATCH v1 2/3] driver: core: Improve documentation for fwnode_operations.add_links() Saravana Kannan
2019-10-11 19:15 ` [PATCH v1 3/3] docs: driver-model: Add documentation for sync_state Saravana Kannan
2019-10-14 23:28 ` Stephen Boyd
2019-10-14 23:35 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011191521.179614-2-saravanak@google.com \
--to=saravanak@google.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).