From: "Adam J. Richter" <adam@yggdrasil.com>
To: ink@jurassic.park.msu.ru
Cc: linux-kernel@vger.kernel.org, david.rusling@reo.mts.dec.com,
davidm@cs.arizona.edu
Subject: Patch: linux-2.5.47/arch/alpha/kernel/pci.c - do not directly set pci_dev.dma_mask where possible
Date: Sat, 16 Nov 2002 06:38:42 -0800 [thread overview]
Message-ID: <20021116063842.A20141@baldur.yggdrasil.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
pcibios_fixup_final in linux-2.5.47/arch/alpha/kernel/pci.c
directly sets pci_dev->dma_mask instead of calling pci_set_dma_mask.
pci_dev.dma_mask may be moved soon (probably to
pci_dev.device.dma_mask). So, applying this patch will reduce or
eliminate the need to change this code when that happens, and it will
be one less change to maintain between 2.4 and 2.5+ kernels.
I am not quite sure who to directly alpha architecture patches
to, so I'm sending this to the authors listed in the file and to lkml.
If there is a more appropriate address to submit this to, I would
appreciate it if someone would let me know. Otherwise, I'd ask
that someone who actually uses Linux on Alpha give this patch a
whirl and submit it to Linus if it works.
--
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 404 bytes --]
--- linux-2.5.47/arch/alpha/kernel/pci.c 2002-11-10 19:28:03.000000000 -0800
+++ linux/arch/alpha/kernel/pci.c 2002-11-16 05:54:00.000000000 -0800
@@ -124,7 +124,7 @@
unsigned int class = dev->class >> 8;
if (class == PCI_CLASS_BRIDGE_ISA || class == PCI_CLASS_BRIDGE_ISA) {
- dev->dma_mask = MAX_ISA_DMA_ADDRESS - 1;
+ pci_set_dma_mask(dev, MAX_ISA_DMA_ADDRESS - 1);
isa_bridge = dev;
}
}
next reply other threads:[~2002-11-16 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-16 14:38 Adam J. Richter [this message]
2002-11-16 21:24 ` Patch: linux-2.5.47/arch/alpha/kernel/pci.c - do not directly set pci_dev.dma_mask where possible Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021116063842.A20141@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=david.rusling@reo.mts.dec.com \
--cc=davidm@cs.arizona.edu \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).