From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch 02/18] m68k: Use new printk() extension %pS to print symbols
Date: Mon, 13 Oct 2008 21:58:48 +0200 [thread overview]
Message-ID: <20081013195912.989368287@mail.of.borg> (raw)
In-Reply-To: 20081013195846.674654386@mail.of.borg
[-- Attachment #1: m68k-use-percent-pS-infrastructure.diff --]
[-- Type: text/plain, Size: 1514 bytes --]
From: Geert Uytterhoeven <geert@linux-m68k.org>
This changes the oops and backtrace code to use the new `%pS' printk()
extension to print out symbols rather than manually calling print_symbol.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/m68k/kernel/traps.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
--- a/arch/m68k/kernel/traps.c
+++ b/arch/m68k/kernel/traps.c
@@ -883,8 +883,7 @@ void show_trace(unsigned long *stack)
if (i % 5 == 0)
printk("\n ");
#endif
- printk(" [<%08lx>]", addr);
- print_symbol(" %s\n", addr);
+ printk(" [<%08lx>] %pS\n", addr, (void *)addr);
i++;
}
}
@@ -900,10 +899,8 @@ void show_registers(struct pt_regs *regs
int i;
print_modules();
- printk("PC: [<%08lx>]",regs->pc);
- print_symbol(" %s", regs->pc);
- printk("\nSR: %04x SP: %p a2: %08lx\n",
- regs->sr, regs, regs->a2);
+ printk("PC: [<%08lx>] %pS\n", regs->pc, (void *)regs->pc);
+ printk("SR: %04x SP: %p a2: %08lx\n", regs->sr, regs, regs->a2);
printk("d0: %08lx d1: %08lx d2: %08lx d3: %08lx\n",
regs->d0, regs->d1, regs->d2, regs->d3);
printk("d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-10-13 20:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 19:58 [patch 00/18] m68k patches for 2.6.28 Geert Uytterhoeven
2008-10-13 19:58 ` [patch 01/18] m68k: use bcd2bin/bin2bcd Geert Uytterhoeven
2008-10-13 19:58 ` Geert Uytterhoeven [this message]
2008-10-13 19:58 ` [patch 03/18] m68k: Put .bss at the end of the data section Geert Uytterhoeven
2008-10-13 19:58 ` [patch 04/18] m68k: Add NOTES to init data so its discarded at boot Geert Uytterhoeven
2008-10-13 19:58 ` [patch 05/18] m68k: Reverse platform MMU logic so Sun 3 is last Geert Uytterhoeven
2008-10-13 19:58 ` [patch 06/18] m68k: Disable Amiga serial console support if modular Geert Uytterhoeven
2008-10-13 21:08 ` Paul Bolle
2008-10-14 7:29 ` Geert Uytterhoeven
2008-10-14 17:20 ` Linus Torvalds
2008-10-14 19:22 ` Geert Uytterhoeven
2008-10-13 19:58 ` [patch 07/18] m68k: Modular Amiga keyboard needs key_maps Geert Uytterhoeven
2008-10-13 19:58 ` [patch 08/18] m68k: Remove unused atari_kbd_translate() Geert Uytterhoeven
2008-10-13 19:58 ` [patch 09/18] m68k: Define rtc_lock on Atari Geert Uytterhoeven
2008-10-13 19:58 ` [patch 10/18] m68k: Add missing dma_sync_single_range_for_{cpu,device}() Geert Uytterhoeven
2008-10-13 19:58 ` [patch 11/18] m68k: <asm/pci.h> needs <asm-generic/pci-dma-compat.h> Geert Uytterhoeven
2008-10-13 19:58 ` [patch 12/18] HP input: kill warnings due to suseconds_t differences Geert Uytterhoeven
2008-10-13 19:58 ` [patch 13/18] m68k: Remove the broken Hades support Geert Uytterhoeven
2008-10-13 19:59 ` [patch 14/18] m68k: remove the dead PCI code Geert Uytterhoeven
2008-10-13 19:59 ` [patch 15/18] m68k: init_irq_proc depends on CONFIG_PROC_FS Geert Uytterhoeven
2008-10-13 19:59 ` [patch 16/18] m68k: Atari SCSI needs NVRAM Geert Uytterhoeven
2008-10-13 19:59 ` [patch 17/18] net/rfkill/rfkill-input.c needs <linux/sched.h> Geert Uytterhoeven
2008-10-13 20:45 ` Henrique de Moraes Holschuh
2008-10-13 23:09 ` Henrique de Moraes Holschuh
2008-10-14 7:23 ` Geert Uytterhoeven
2008-10-15 3:10 ` Henrique de Moraes Holschuh
2008-10-15 7:50 ` Geert Uytterhoeven
2008-10-15 13:12 ` Adrian Bunk
2008-10-13 19:59 ` [patch 18/18] arch/m68k/mm/kmap.c: introduce missing kfree Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013195912.989368287@mail.of.borg \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).