From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Subject: [PATCH 1/5] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq()
Date: Mon, 9 Nov 2020 09:41:17 +0000 [thread overview]
Message-ID: <20201109094121.29975-2-valentin.schneider@arm.com> (raw)
In-Reply-To: <20201109094121.29975-1-valentin.schneider@arm.com>
handle_percpu_devid_fasteoi_ipi() states:
* The biggest difference with the IRQ version is that the interrupt is
* EOIed early, as the IPI could result in a context switch, and we need to
* make sure the IPI can fire again
All that can actually happen scheduler-wise within the handling of an IPI
is the raising of TIF_NEED_RESCHED (and / or folding thereof into
preempt_count); see scheduler_ipi() or sched_ttwu_pending() for instance.
Said flag / preempt_count is evaluated some time later before returning to
whatever context was interrupted, and this gates a call to
preempt_schedule_irq() (arm64_preempt_schedule_irq() in arm64).
Per the above, SGI's do not need a different handler than PPI's, so make
them use the same (handle_percpu_devid_irq).
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
drivers/irqchip/irq-gic-v3.c | 6 ------
drivers/irqchip/irq-gic.c | 8 +-------
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 16fecc0febe8..3fc65375cbe0 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1302,12 +1302,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
switch (__get_intid_range(hw)) {
case SGI_RANGE:
- irq_set_percpu_devid(irq);
- irq_domain_set_info(d, irq, hw, chip, d->host_data,
- handle_percpu_devid_fasteoi_ipi,
- NULL, NULL);
- break;
-
case PPI_RANGE:
case EPPI_RANGE:
irq_set_percpu_devid(irq);
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 6053245a4754..9edbe5b5c4ac 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1005,13 +1005,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
struct irq_data *irqd = irq_desc_get_irq_data(irq_to_desc(irq));
switch (hw) {
- case 0 ... 15:
- irq_set_percpu_devid(irq);
- irq_domain_set_info(d, irq, hw, &gic->chip, d->host_data,
- handle_percpu_devid_fasteoi_ipi,
- NULL, NULL);
- break;
- case 16 ... 31:
+ case 0 ... 31:
irq_set_percpu_devid(irq);
irq_domain_set_info(d, irq, hw, &gic->chip, d->host_data,
handle_percpu_devid_irq, NULL, NULL);
--
2.27.0
next prev parent reply other threads:[~2020-11-09 9:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:41 [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Valentin Schneider
2020-11-09 9:41 ` Valentin Schneider [this message]
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 2/5] irqchip/armada-370-xp: Make IPIs " Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 3/5] irqchip/bcm2836: " Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-15 0:21 ` [PATCH 3/5] " Guenter Roeck
2020-12-15 10:19 ` Marc Zyngier
2020-12-15 11:14 ` Valentin Schneider
2020-12-15 12:14 ` Marc Zyngier
2020-12-15 15:21 ` Guenter Roeck
2020-12-15 15:26 ` Marc Zyngier
2020-12-15 15:39 ` Guenter Roeck
2020-12-15 15:46 ` Marc Zyngier
2020-12-15 16:23 ` Guenter Roeck
2020-12-18 5:18 ` Guenter Roeck
2020-12-18 18:40 ` Marc Zyngier
2020-12-18 18:47 ` Guenter Roeck
2020-12-18 18:40 ` [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq irqchip-bot for Marc Zyngier
2020-12-18 20:36 ` Valentin Schneider
2020-12-18 20:53 ` Marc Zyngier
2020-11-09 9:41 ` [PATCH 4/5] irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-11 15:01 ` [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109094121.29975-2-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).