From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yhlu.kernel@gmail.com>,
linux-kernel@vger.kernel.org,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [patch 1/2] x86: apic - calibrate_APIC_clock remove redundant irq-enable-disable
Date: Thu, 01 Jan 1970 03:00:01 +0300 [thread overview]
Message-ID: <4916c290.0437560a.270e.0940@mx.google.com> (raw)
In-Reply-To: 20081109105709.222708517@gmail.com
[-- Attachment #1: x86-apic-calibrate_APIC_clock-irq-cleanup --]
[-- Type: text/plain, Size: 910 bytes --]
Impact: cleanup
lapic_timer_setup is self-protected with local_irq_save/restore
no need to use them in caller and levt is the per-cpu variable so
no concurrent access from another cpu.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
arch/x86/kernel/apic.c | 4 ----
1 file changed, 4 deletions(-)
Index: linux-2.6.git/arch/x86/kernel/apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic.c
+++ linux-2.6.git/arch/x86/kernel/apic.c
@@ -672,13 +672,9 @@ static int __init calibrate_APIC_clock(v
while (lapic_cal_loops <= LAPIC_CAL_LOOPS)
cpu_relax();
- local_irq_disable();
-
/* Stop the lapic timer */
lapic_timer_setup(CLOCK_EVT_MODE_SHUTDOWN, levt);
- local_irq_enable();
-
/* Jiffies delta */
deltaj = lapic_cal_j2 - lapic_cal_j1;
apic_printk(APIC_VERBOSE, "... jiffies delta = %lu\n", deltaj);
--
next parent reply other threads:[~2008-11-09 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081109105709.222708517@gmail.com>
1970-01-01 0:00 ` Cyrill Gorcunov [this message]
2008-11-09 11:05 ` [patch 1/2] x86: apic - calibrate_APIC_clock remove redundant irq-enable-disable Cyrill Gorcunov
2008-11-09 12:45 ` Maciej W. Rozycki
2008-11-10 8:17 ` Ingo Molnar
1970-01-01 0:00 ` [patch 2/2] x86: apic - use pr_ macros for logging Cyrill Gorcunov
2008-11-09 12:44 ` Maciej W. Rozycki
2008-11-09 12:59 ` Cyrill Gorcunov
2008-11-10 8:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4916c290.0437560a.270e.0940@mx.google.com \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).