From: Wang ShaoBo <bobo.shaobowang@huawei.com>
To: <bp@alien8.de>
Cc: <mchehab@kernel.org>, <james.morse@arm.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<huawei.libin@huawei.com>, <cj.chengjian@huawei.com>
Subject: [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe()
Date: Tue, 24 Nov 2020 14:30:09 +0800 [thread overview]
Message-ID: <20201124063009.1529-1-bobo.shaobowang@huawei.com> (raw)
Fix to return -ENODEV error code when edac_pci_add_device() failed instaed
of 0 in mv64x60_pci_err_probe(), as done elsewhere in this function.
Fixes: 4f4aeeabc061 ("drivers-edac: add marvell mv64x60 driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/edac/mv64x60_edac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
index 3c68bb525d5d..456b9ca1fe8d 100644
--- a/drivers/edac/mv64x60_edac.c
+++ b/drivers/edac/mv64x60_edac.c
@@ -168,6 +168,7 @@ static int mv64x60_pci_err_probe(struct platform_device *pdev)
if (edac_pci_add_device(pci, pdata->edac_idx) > 0) {
edac_dbg(3, "failed edac_pci_add_device()\n");
+ res = -ENODEV;
goto err;
}
--
2.17.1
next reply other threads:[~2020-11-24 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 6:30 Wang ShaoBo [this message]
2020-12-02 11:25 ` [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe() Borislav Petkov
2020-12-03 11:27 ` Michael Ellerman
2020-12-03 11:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124063009.1529-1-bobo.shaobowang@huawei.com \
--to=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).