From: Justin Ernst <justin.ernst@hpe.com>
To: Borislav Petkov <bp@alien8.de>,
Hans de Goede <hdegoede@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Steve Wahl <steve.wahl@hpe.com>,
x86@kernel.org
Cc: Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Russ Anderson <russ.anderson@hpe.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Ilya Dryomov <idryomov@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
Mike Travis <mike.travis@hpe.com>,
Justin Ernst <justin.ernst@hpe.com>
Subject: [PATCH v3 1/5] x86/platform/uv: Remove existing /sys/firmware/sgi_uv/ interface
Date: Wed, 25 Nov 2020 11:54:40 -0600 [thread overview]
Message-ID: <20201125175444.279074-2-justin.ernst@hpe.com> (raw)
In-Reply-To: <20201125175444.279074-1-justin.ernst@hpe.com>
Remove existing interface at /sys/firmware/sgi_uv/, created by
arch/x86/platform/uv/uv_sysfs.c
This interface includes:
/sys/firmware/sgi_uv/coherence_id
/sys/firmware/sgi_uv/partition_id
Both coherence_id and partition_id will be re-introduced via a
new uv_sysfs driver.
Signed-off-by: Justin Ernst <justin.ernst@hpe.com>
Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
---
arch/x86/platform/uv/Makefile | 2 +-
arch/x86/platform/uv/uv_sysfs.c | 63 ---------------------------------
2 files changed, 1 insertion(+), 64 deletions(-)
delete mode 100644 arch/x86/platform/uv/uv_sysfs.c
diff --git a/arch/x86/platform/uv/Makefile b/arch/x86/platform/uv/Makefile
index 224ff0504890..1441dda8edf7 100644
--- a/arch/x86/platform/uv/Makefile
+++ b/arch/x86/platform/uv/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_X86_UV) += bios_uv.o uv_irq.o uv_sysfs.o uv_time.o uv_nmi.o
+obj-$(CONFIG_X86_UV) += bios_uv.o uv_irq.o uv_time.o uv_nmi.o
diff --git a/arch/x86/platform/uv/uv_sysfs.c b/arch/x86/platform/uv/uv_sysfs.c
deleted file mode 100644
index 266773e2fb37..000000000000
--- a/arch/x86/platform/uv/uv_sysfs.c
+++ /dev/null
@@ -1,63 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * This file supports the /sys/firmware/sgi_uv interfaces for SGI UV.
- *
- * Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
- * Copyright (c) Russ Anderson
- */
-
-#include <linux/device.h>
-#include <asm/uv/bios.h>
-#include <asm/uv/uv.h>
-
-struct kobject *sgi_uv_kobj;
-
-static ssize_t partition_id_show(struct kobject *kobj,
- struct kobj_attribute *attr, char *buf)
-{
- return snprintf(buf, PAGE_SIZE, "%ld\n", sn_partition_id);
-}
-
-static ssize_t coherence_id_show(struct kobject *kobj,
- struct kobj_attribute *attr, char *buf)
-{
- return snprintf(buf, PAGE_SIZE, "%ld\n", sn_coherency_id);
-}
-
-static struct kobj_attribute partition_id_attr =
- __ATTR(partition_id, S_IRUGO, partition_id_show, NULL);
-
-static struct kobj_attribute coherence_id_attr =
- __ATTR(coherence_id, S_IRUGO, coherence_id_show, NULL);
-
-
-static int __init sgi_uv_sysfs_init(void)
-{
- unsigned long ret;
-
- if (!is_uv_system())
- return -ENODEV;
-
- if (!sgi_uv_kobj)
- sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj);
- if (!sgi_uv_kobj) {
- printk(KERN_WARNING "kobject_create_and_add sgi_uv failed\n");
- return -EINVAL;
- }
-
- ret = sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr);
- if (ret) {
- printk(KERN_WARNING "sysfs_create_file partition_id failed\n");
- return ret;
- }
-
- ret = sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);
- if (ret) {
- printk(KERN_WARNING "sysfs_create_file coherence_id failed\n");
- return ret;
- }
-
- return 0;
-}
-
-device_initcall(sgi_uv_sysfs_init);
--
2.26.2
next prev parent reply other threads:[~2020-11-25 17:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 17:54 [PATCH v3 0/5] x86/platform/uv: Add uv_sysfs platform driver Justin Ernst
2020-11-25 17:54 ` Justin Ernst [this message]
2020-11-26 18:20 ` [tip: x86/platform] x86/platform/uv: Remove existing /sys/firmware/sgi_uv/ interface tip-bot2 for Justin Ernst
2020-11-25 17:54 ` [PATCH v3 2/5] x86/platform/uv: Add and export uv_bios_* functions Justin Ernst
2020-11-26 18:20 ` [tip: x86/platform] " tip-bot2 for Justin Ernst
2020-11-25 17:54 ` [PATCH v3 3/5] x86/platform/uv: Add new uv_sysfs platform driver Justin Ernst
2020-11-26 18:20 ` [tip: x86/platform] " tip-bot2 for Justin Ernst
2020-11-25 17:54 ` [PATCH v3 4/5] x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/ Justin Ernst
2020-11-26 18:20 ` [tip: x86/platform] " tip-bot2 for Justin Ernst
2020-12-01 13:05 ` tip-bot2 for Justin Ernst
2020-11-25 17:54 ` [PATCH v3 5/5] x86/platform/uv: Update MAINTAINERS for uv_sysfs driver Justin Ernst
2020-11-26 18:20 ` [tip: x86/platform] " tip-bot2 for Justin Ernst
2020-12-01 13:05 ` tip-bot2 for Justin Ernst
2020-11-26 10:39 ` [PATCH v3 0/5] x86/platform/uv: Add uv_sysfs platform driver Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125175444.279074-2-justin.ernst@hpe.com \
--to=justin.ernst@hpe.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@infradead.org \
--cc=bp@alien8.de \
--cc=cezary.rojewski@intel.com \
--cc=dimitri.sivanich@hpe.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mgross@linux.intel.com \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=russ.anderson@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=tglx@linutronix.de \
--cc=vaibhav@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).