From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiri Kosina <trivial@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-renesas-soc@vger.kernel.org, Pavel Machek <pavel@denx.de>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
stable@vger.kernel.org
Subject: [PATCH v2 3/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
Date: Thu, 26 Nov 2020 19:11:44 +0000 [thread overview]
Message-ID: <20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20201126191146.8753-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Release the node reference by calling of_node_put(flash) in the probe.
Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: stable@vger.kernel.org
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
---
drivers/memory/renesas-rpc-if.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index a8d0ba368625..da0fdb4c7595 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -561,9 +561,11 @@ static int rpcif_probe(struct platform_device *pdev)
} else if (of_device_is_compatible(flash, "cfi-flash")) {
name = "rpc-if-hyperflash";
} else {
+ of_node_put(flash);
dev_warn(&pdev->dev, "unknown flash type\n");
return -ENODEV;
}
+ of_node_put(flash);
vdev = platform_device_alloc(name, pdev->id);
if (!vdev)
--
2.25.1
next prev parent reply other threads:[~2020-11-26 19:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 19:11 [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes Lad Prabhakar
2020-11-26 19:11 ` [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer() Lad Prabhakar
2020-11-27 9:34 ` Geert Uytterhoeven
2020-11-27 22:38 ` Pavel Machek
2020-11-28 11:32 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 2/5] memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in rpcif_{enable,disable}_rpm Lad Prabhakar
2020-11-26 19:33 ` Sergei Shtylyov
2020-11-28 11:33 ` Krzysztof Kozlowski
2020-11-26 19:11 ` Lad Prabhakar [this message]
2020-11-27 9:33 ` [PATCH v2 3/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() Geert Uytterhoeven
2020-11-27 22:41 ` Pavel Machek
2020-11-28 11:35 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 4/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline Lad Prabhakar
2020-11-27 22:41 ` Pavel Machek
2020-11-28 11:37 ` Krzysztof Kozlowski
2020-11-26 19:11 ` [PATCH v2 5/5] memory: renesas-rpc-if: Export symbols as GPL Lad Prabhakar
2020-11-28 11:41 ` Krzysztof Kozlowski
2020-11-28 12:46 ` Prabhakar Mahadev Lad
2021-07-03 15:21 ` Pavel Machek
2020-11-26 19:37 ` [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes Sergei Shtylyov
2020-12-03 10:41 ` Lad, Prabhakar
2020-12-03 10:52 ` Geert Uytterhoeven
2020-12-03 12:34 ` Prabhakar Mahadev Lad
2020-12-03 13:19 ` Krzysztof Kozlowski
2020-12-04 9:46 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pavel@denx.de \
--cc=prabhakar.csengg@gmail.com \
--cc=sergei.shtylyov@gmail.com \
--cc=stable@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).