[VGA16FB] Fix bogus mem_start value
diff mbox series

Message ID 20040608100530.GA26292@gondor.apana.org.au
State New, archived
Headers show
Series
  • [VGA16FB] Fix bogus mem_start value
Related show

Commit Message

Herbert Xu June 8, 2004, 10:05 a.m. UTC
Hi Andrew:

The recent change to vga16fb's memory mapping that you partially
reverted is still broken.  In particular, it's setting fix.mem_start
to a virtual address on i386.  The value of fix.mem_start is meant
to be physical.

We could simply apply virt_to_phys to it, but somehow I doubt that
is what it's meant to do on arm.  So until we hear from someone who
knows how it works on arm, let's just revert this change.

Cheers,

Comments

Andrew Morton June 8, 2004, 10:09 a.m. UTC | #1
Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> The recent change to vga16fb's memory mapping that you partially
>  reverted is still broken.  In particular, it's setting fix.mem_start
>  to a virtual address on i386.  The value of fix.mem_start is meant
>  to be physical.

Sigh.  Fiasco.

>  We could simply apply virt_to_phys to it, but somehow I doubt that
>  is what it's meant to do on arm.  So until we hear from someone who
>  knows how it works on arm, let's just revert this change.

Is this tested?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Herbert Xu June 8, 2004, 10:14 a.m. UTC | #2
On Tue, Jun 08, 2004 at 03:09:06AM -0700, Andrew Morton wrote:
> 
> >  We could simply apply virt_to_phys to it, but somehow I doubt that
> >  is what it's meant to do on arm.  So until we hear from someone who
> >  knows how it works on arm, let's just revert this change.
> 
> Is this tested?

Yes on i386.  It's also what what we've used since the beginning of
time until that change was introduced.

Cheers,

Patch
diff mbox series

===== drivers/video/vga16fb.c 1.38 vs edited =====
--- 1.38/drivers/video/vga16fb.c	2004-05-22 18:18:20 +10:00
+++ edited/drivers/video/vga16fb.c	2004-06-08 19:57:40 +10:00
@@ -1372,8 +1372,6 @@ 
 	vga16fb.par = &vga16_par;
 	vga16fb.flags = FBINFO_FLAG_DEFAULT;
 
-	vga16fb.fix.smem_start	= VGA_MAP_MEM(vga16fb.fix.smem_start);
-
 	i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
 	ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);
 	if (ret) {