From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vincent Sanders <vince@kyllikki.org>
Subject: [VGA16FB] Fix bogus mem_start value
Date: Tue, 8 Jun 2004 20:05:30 +1000 [thread overview]
Message-ID: <20040608100530.GA26292@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
Hi Andrew:
The recent change to vga16fb's memory mapping that you partially
reverted is still broken. In particular, it's setting fix.mem_start
to a virtual address on i386. The value of fix.mem_start is meant
to be physical.
We could simply apply virt_to_phys to it, but somehow I doubt that
is what it's meant to do on arm. So until we hear from someone who
knows how it works on arm, let's just revert this change.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 443 bytes --]
===== drivers/video/vga16fb.c 1.38 vs edited =====
--- 1.38/drivers/video/vga16fb.c 2004-05-22 18:18:20 +10:00
+++ edited/drivers/video/vga16fb.c 2004-06-08 19:57:40 +10:00
@@ -1372,8 +1372,6 @@
vga16fb.par = &vga16_par;
vga16fb.flags = FBINFO_FLAG_DEFAULT;
- vga16fb.fix.smem_start = VGA_MAP_MEM(vga16fb.fix.smem_start);
-
i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);
if (ret) {
next reply other threads:[~2004-06-08 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 10:05 Herbert Xu [this message]
2004-06-08 10:09 ` [VGA16FB] Fix bogus mem_start value Andrew Morton
2004-06-08 10:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040608100530.GA26292@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vince@kyllikki.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).