From: Jason Wang <jasowang@redhat.com>
To: netdev@vger.kernel.org, eric.dumazet@gmail.com,
"David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
stable@kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Amos Kong <akong@redhat.com>
Subject: Possible NULL dereference caused by -stable commit ef81bb40bf15f350fe865f31fa42f1082772a576
Date: Wed, 28 Sep 2011 18:51:58 +0800 [thread overview]
Message-ID: <4E82FC4E.5010101@redhat.com> (raw)
Hi all:
A possible NULL dereference were noticed by the stable commit
ef81bb40bf15f350fe865f31fa42f1082772a576 (which is a backport of
87c48fa3b4630905f98268dde838ee43626a060c). The case happens when bridge
froward a packet from guest to a physical nic, at this time no route is
attached to the skb which may lead a NULL dereference in
ipv6_select_ident(). -Next version have this check so it is fine. The
following patch may be used to avoid this but may also lead the ip
identification predicable, and this defect is also exist -next version
when no route because we still depends on a global variable to generate
the identification. Any thought on this?
Thanks.
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 4ea6e21..414e2f4 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -622,7 +622,9 @@ static u32 __ipv6_select_ident(const struct in6_addr
*addr)
void ipv6_select_ident(struct frag_hdr *fhdr, struct rt6_info *rt)
{
- fhdr->identification =
htonl(__ipv6_select_ident(&rt->rt6i_dst.addr));
+ const struct in6_addr addr = IN6ADDR_ANY_INIT;
+ fhdr->identification =
+ htonl(__ipv6_select_ident(rt ? &rt->rt6i_dst.addr : &addr));
}
int ip6_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *))
next reply other threads:[~2011-09-28 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 10:51 Jason Wang [this message]
2011-09-28 12:09 ` Possible NULL dereference caused by -stable commit ef81bb40bf15f350fe865f31fa42f1082772a576 Eric Dumazet
2011-09-28 17:12 ` David Miller
2011-09-28 18:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E82FC4E.5010101@redhat.com \
--to=jasowang@redhat.com \
--cc=akong@redhat.com \
--cc=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).