From: Herbert Xu <herbert@gondor.apana.org.au>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
viro@parcelfarce.linux.theplanet.co.uk
Subject: [PATCH] Backport Via IRQ mask fix
Date: Tue, 5 Oct 2004 14:05:42 +1000 [thread overview]
Message-ID: <20041005040542.GA10876@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Hi Marcelo:
Here is a backport of the Via APIC IRQ mask fix that Al Viro made to 2.6.
This is his original description:
# ChangeSet
# 2004/06/23 10:55:18-07:00 viro@parcelfarce.linux.theplanet.co.uk
# [PATCH] bug in V-link handling (arch/i386/pci/irq.c)
#
# Via southbridges use register 0x3c of the on-board devices (USB and
# AC97) to control interrupt routing for those. In drivers/pci/quirks.c we
# set it correctly (dev->irq & 15). However, in pirq_enable_irq() where the
# second half of that stuff lives, we forget to apply the mask.
#
# That's what causes problems with ioapic on via motherboards in 2.6.
# One-liner below ACKed by Alan, verified on via-based boxen here, obviously
# doesn't affect non-via ones (we only set interrupt_line_quirk for via
# chipsets).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 455 bytes --]
===== arch/i386/kernel/pci-irq.c 1.29 vs edited =====
--- 1.29/arch/i386/kernel/pci-irq.c 2004-08-24 08:01:27 +10:00
+++ edited/arch/i386/kernel/pci-irq.c 2004-10-05 14:03:34 +10:00
@@ -1129,6 +1129,6 @@
/* VIA bridges use interrupt line for apic/pci steering across
the V-Link */
else if (interrupt_line_quirk)
- pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
+ pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq & 15);
}
reply other threads:[~2004-10-05 4:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041005040542.GA10876@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).