From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Michael Elkins <me@sigpipe.org>
Cc: Rui Sousa <rsousa@grad.physics.sunysb.edu>,
usb@in.tum.de, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] Re: PROBLEM: kernel 2.4.0-test11-ac1 hang with usb-uhci and emu10k1
Date: Thu, 23 Nov 2000 18:06:31 -0500 [thread overview]
Message-ID: <3A1DA2F7.94114CD2@mandrakesoft.com> (raw)
In-Reply-To: <20001123020203.A30491@toesinperil.com> <Pine.LNX.4.21.0011231028030.17678-100000@grad.physics.sunysb.edu> <20001123174952.B7591@in.tum.de> <20001123144517.A31910@toesinperil.com>
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
Michael Elkins wrote:
>
> On Thu, Nov 23, 2000 at 05:49:52PM +0100, Georg Acher wrote:
> > On Thu, Nov 23, 2000 at 04:35:33PM +0000, Rui Sousa wrote:
> > > On Thu, 23 Nov 2000, Michael Elkins wrote:
> > >
> > > Usb controller is sharing a interrupt with the emu10k1.
> > > For what I know the emu10k1 driver doesn't have any problem
> > > sharing irq's, so I would blame the usb driver...
> >
> > usb-uhci doesn't also have any problem with sharing irqs:
> >
> > > cat /proc/interrupts
> > 10: 5597981 XT-PIC aic7xxx, eth0, usb-uhci
> >
> > Hm, no one left to blame...
> > I would debug it as follows:
> > Place various printks in the initialization code (reset_hc(), start_hc() and
> > alloc_uhci) and find out after which printk it hangs. Then it would be
> > possible to investigate this further...
>
> It hangs in start_uhci():
>
> /* disable legacy emulation */
> pci_write_config_word (dev, USBLEGSUP, USBLEGSUP_DEFAULT);
>
> The loop that the call is in gets iterated 5 times. For i < 4, the
> if (!(dev->resource[i].flags & 1))
> is TRUE, but on i==4, it drops into the bottom of the loop to execute
> check_region() and then pci_write_config_word(), where it hangs.
It may not make a difference, but that check is flat out wrong.
Apply this patch... (untested, you may need to include ioport.h)
--
Jeff Garzik |
Building 1024 | The chief enemy of creativity is "good" sense
MandrakeSoft | -- Picasso
[-- Attachment #2: usb.patch --]
[-- Type: text/plain, Size: 606 bytes --]
Index: drivers/usb/usb-uhci.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/usb/usb-uhci.c,v
retrieving revision 1.1.1.9
diff -u -r1.1.1.9 usb-uhci.c
--- drivers/usb/usb-uhci.c 2000/10/22 23:25:12 1.1.1.9
+++ drivers/usb/usb-uhci.c 2000/11/23 23:04:37
@@ -2886,7 +2886,7 @@
unsigned int io_addr = dev->resource[i].start;
unsigned int io_size =
dev->resource[i].end - dev->resource[i].start + 1;
- if (!(dev->resource[i].flags & 1))
+ if (!(dev->resource[i].flags & IORESOURCE_IO))
continue;
/* Is it already in use? */
next prev parent reply other threads:[~2000-11-23 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-23 10:02 PROBLEM: kernel 2.4.0-test11-ac1 hang with usb-uhci and emu10k1 Michael Elkins
2000-11-23 15:32 ` Rui Sousa
2000-11-23 16:49 ` Georg Acher
2000-11-23 22:45 ` Michael Elkins
2000-11-23 23:06 ` Jeff Garzik [this message]
2000-11-23 23:53 ` [PATCH] " Linus Torvalds
2000-11-24 13:04 ` [patch-2.4.0-test11] various small fixes Tigran Aivazian
2000-11-24 7:06 ` [PATCH] Re: PROBLEM: kernel 2.4.0-test11-ac1 hang with usb-uhci and emu10k1 Michael Elkins
2000-11-24 16:30 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A1DA2F7.94114CD2@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=me@sigpipe.org \
--cc=rsousa@grad.physics.sunysb.edu \
--cc=torvalds@transmeta.com \
--cc=usb@in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).